From 26641f938e08b303919626a25d6f697c98d685b2 Mon Sep 17 00:00:00 2001 From: Kalila <69767640+digisomni@users.noreply.github.com> Date: Thu, 7 Oct 2021 02:53:31 -0400 Subject: [PATCH] Fix GHA on MacOS. (#1386) * "macOS-latest" -> "macOS-10.15" & fix OpenSSL discovery. --- .github/workflows/master_build.yml | 6 +++--- .github/workflows/pr_build.yml | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/master_build.yml b/.github/workflows/master_build.yml index f1e7578c02..8d9844e03c 100644 --- a/.github/workflows/master_build.yml +++ b/.github/workflows/master_build.yml @@ -29,7 +29,7 @@ jobs: build: strategy: matrix: - os: [windows-latest, macOS-latest, ubuntu-18.04] + os: [windows-latest, macOS-10.15, ubuntu-18.04] # build_type: [full, client] build_type: [full] include: @@ -59,12 +59,12 @@ jobs: echo "CMAKE_EXTRA=-DBUILD_TOOLS:BOOLEAN=FALSE -DHIFI_PYTHON_EXEC:FILEPATH=$(which python3)" >> $GITHUB_ENV fi # Mac build variables - if [ "${{ matrix.os }}" = "macOS-latest" ]; then + if [ "${{ matrix.os }}" = "macOS-10.15" ]; then echo "PYTHON_EXEC=python3" >> $GITHUB_ENV echo "ZIP_COMMAND=zip" >> $GITHUB_ENV echo "ZIP_ARGS=-r" >> $GITHUB_ENV echo "INSTALLER_EXT=dmg" >> $GITHUB_ENV - echo "CMAKE_EXTRA=-DCMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=OFF -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -G Xcode" >> $GITHUB_ENV + echo "CMAKE_EXTRA=-DCMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=OFF -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DOPENSSL_LIBRARIES=/usr/local/opt/openssl/lib -G Xcode" >> $GITHUB_ENV echo "::set-output name=symbols_archive::${BUILD_NUMBER}-${{ matrix.build_type }}-mac-symbols.zip" echo "APP_TARGET_NAME=Vircadia" >> $GITHUB_ENV fi diff --git a/.github/workflows/pr_build.yml b/.github/workflows/pr_build.yml index 20619983c5..9bd3f7fb12 100644 --- a/.github/workflows/pr_build.yml +++ b/.github/workflows/pr_build.yml @@ -36,9 +36,9 @@ jobs: include: - os: windows-latest build_type: full - - os: macOS-latest + - os: macOS-10.15 build_type: full - - os: macOS-latest + - os: macOS-10.15 build_type: client - os: ubuntu-18.04 build_type: full @@ -81,13 +81,13 @@ jobs: fi fi # Mac build variables - if [ "${{ matrix.os }}" = "macOS-latest" ]; then + if [ "${{ matrix.os }}" = "macOS-10.15" ]; then echo "PYTHON_EXEC=python3" >> $GITHUB_ENV echo "INSTALLER_EXT=dmg" >> $GITHUB_ENV if [ "${{ matrix.build_type }}" = "full" ]; then - echo "CMAKE_EXTRA=-DCMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=OFF -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -G Xcode" >> $GITHUB_ENV + echo "CMAKE_EXTRA=-DCMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=OFF -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DOPENSSL_LIBRARIES=/usr/local/opt/openssl/lib -G Xcode" >> $GITHUB_ENV else - echo "CMAKE_EXTRA=-DCLIENT_ONLY=1 -DCMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=OFF -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -G Xcode" >> $GITHUB_ENV + echo "CMAKE_EXTRA=-DCLIENT_ONLY=1 -DCMAKE_XCODE_ATTRIBUTE_CODE_SIGNING_REQUIRED=OFF -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl -DOPENSSL_LIBRARIES=/usr/local/opt/openssl/lib -G Xcode" >> $GITHUB_ENV fi echo "APP_TARGET_NAME=Vircadia" >> $GITHUB_ENV fi @@ -163,7 +163,7 @@ jobs: if: always() shell: bash run: | - if [ "${{ matrix.os }}" == "macOS-latest" ]; then + if [ "${{ matrix.os }}" == "macOS-10.15" ]; then TAR=gtar else TAR=tar