From 0f46e25368ef52ceb73ec580b4f46dea65af9675 Mon Sep 17 00:00:00 2001
From: Dale Glass <dale@daleglass.net>
Date: Mon, 6 Jun 2022 23:17:25 +0200
Subject: [PATCH] Attempted to mess with the shaders test, but it seems too out
 of date. Disabled.

---
 tests/shaders/CMakeLists.txt      | 45 ++++++++++++++++++++-----------
 tests/shaders/src/ShaderTests.cpp |  4 ++-
 2 files changed, 32 insertions(+), 17 deletions(-)

diff --git a/tests/shaders/CMakeLists.txt b/tests/shaders/CMakeLists.txt
index a2bba2a425..6debe88942 100644
--- a/tests/shaders/CMakeLists.txt
+++ b/tests/shaders/CMakeLists.txt
@@ -1,19 +1,32 @@
+# This doesn't link properly, and it seems it's built against some older library
+# not being in use anymore. At least some of the stuff in the test doesn't seem
+# to match anything in the build tree. If built, it fails with:
+
+# [ 91%] Linking CXX executable shaders-ShaderTests
+# /usr/bin/ld: CMakeFiles/shaders-ShaderTests.dir/src/ShaderTests.cpp.o: in function `rebuildSource(shader::Dialect, shader::Variant, shader::Source const&)':
+# /home/dale/git/vircadia/overte/tests/shaders/src/ShaderTests.cpp:354: undefined reference to `glslang::TShader::TShader(EShLanguage)'
+# /usr/bin/ld: /home/dale/git/vircadia/overte/tests/shaders/src/ShaderTests.cpp:358: undefined reference to `glslang::TShader::setStrings(char const* const*, int)'
+# /usr/bin/ld: /home/dale/git/vircadia/overte/tests/shaders/src/ShaderTests.cpp:417: undefined reference to `glslang::TShader::~TShader()'
+# /usr/bin/ld: /home/dale/git/vircadia/overte/tests/shaders/src/ShaderTests.cpp:417: undefined reference to `glslang::TShader::~TShader()'
+# collect2: error: ld returned 1 exit status
+#
+# So I've disabled the entire thing, but left the code around as a reference in case it can be fixed.
 
 # Declare dependencies
-macro (setup_testcase_dependencies)
-  # link in the shared libraries
-  link_hifi_libraries(shared test-utils gpu shaders gl ${PLATFORM_GL_BACKEND})
-  #target_spirv()
-
-  find_package(spirv_cross_core REQUIRED)
-  find_package(spirv_cross_reflect REQUIRED)
-  find_package(spirv_cross_glsl REQUIRED)
-  target_include_directories(${TARGET_NAME} PRIVATE $<TARGET_PROPERTY:spirv-cross-core,INTERFACE_INCLUDE_DIRECTORIES>)
-  target_include_directories(${TARGET_NAME} PRIVATE $ENV{VULKAN_SDK}/Include)
-  
- 
-  package_libraries_for_deployment()
-endmacro ()
-
-setup_hifi_testcase(Gui)
+#macro (setup_testcase_dependencies)
+#  # link in the shared libraries
+#  link_hifi_libraries(shared test-utils gpu shaders gl ${PLATFORM_GL_BACKEND})
+#  #target_spirv()
+#
+#  find_package(spirv_cross_core REQUIRED)
+#  find_package(spirv_cross_reflect REQUIRED)
+#  find_package(spirv_cross_glsl REQUIRED)
+#  target_include_directories(${TARGET_NAME} PRIVATE $<TARGET_PROPERTY:spirv-cross-core,INTERFACE_INCLUDE_DIRECTORIES>)
+#  target_include_directories(${TARGET_NAME} PRIVATE $ENV{VULKAN_SDK}/Include)
+#
+#
+#  package_libraries_for_deployment()
+#endmacro ()
+#
+#setup_hifi_testcase(Gui)
 
diff --git a/tests/shaders/src/ShaderTests.cpp b/tests/shaders/src/ShaderTests.cpp
index 56b92ed047..e6a4e35c83 100644
--- a/tests/shaders/src/ShaderTests.cpp
+++ b/tests/shaders/src/ShaderTests.cpp
@@ -360,7 +360,9 @@ void rebuildSource(shader::Dialect dialect, shader::Variant variant, const shade
         shader.setEnvClient(EShClientVulkan, EShTargetVulkan_1_1);
         shader.setEnvTarget(EShTargetSpv, EShTargetSpv_1_3);
 
-        bool success = shader.parse(&glslCompilerResources, 450, false, messages);
+        //bool success = shader.parse(&glslCompilerResources, 450, false, messages);
+        QSKIP("Something wasn't fully implemented here, please fix me!");
+        bool success = false;
         if (!success) {
             qWarning() << "Failed to parse shader " << shaderName.c_str();
             qWarning() << shader.getInfoLog();