Mirrors/overte-lubosz
3
0
Fork 0
mirror of https://github.com/lubosz/overte.git synced 2025-04-25 01:23:57 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

[Case 4315] ESLint Pass 6 Pt 2 for colpick equality checks (details below).

Browse source 
* Suppressing equality checking issues within color conversion helper functions.
    * These issues are suppressed as opposed to resolved because their resolution causes
      issues with the color picker's understanding of the color it's being set to along with
      the respective hue.  This is likely due to rounding issues; however, it may also be something
      related to the equality operator implicit conversions semantics of JavaScript.  It's something
      that can be looked into later if desired.
          * Bug Steps upon resolving check as opposed to suppressing them:
              - Select a shape entity for example.
              - Note the visual color and actual RGB values for that entity's color upon selection.
              - Click the Color Wheel.
              - Notice the automatic change of the color for the entity when the picker is shown.
                  - If the issue doesn't show itself right away, alter the color for the entity close the
                    picker, and repeat steps 2-3.

* Issue Count reduced from 8 to 1

Changes Committed:
    modified:   scripts/system/html/js/colpick.js
This commit is contained in:
LaShonda Hopper 2018-02-09 18:12:57 -05:00
parent 59e0b8476a
commit fed85a7a53
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
scripts/system/html/js/colpick.js
View file

@ -519,11 +519,11 @@ For usage and examples: colpick.com/plugin
var max = Math.max(rgb.r, rgb.g, rgb.b);
var delta = max - min;
hsb.b = max;
hsb.s = max != 0 ? 255 * delta / max : 0;
if (hsb.s != 0) {
if (rgb.r == max) {
hsb.s = max != 0 ? 255 * delta / max : 0; // eslint-disable-line eqeqeq
if (hsb.s != 0) { // eslint-disable-line eqeqeq
if (rgb.r == max) { // eslint-disable-line eqeqeq
hsb.h = (rgb.g - rgb.b) / delta;
} else if (rgb.g == max) {
} else if (rgb.g == max) { // eslint-disable-line eqeqeq
hsb.h = 2 + (rgb.b - rgb.r) / delta;
} else {
hsb.h = 4 + (rgb.r - rgb.g) / delta;
@ -544,13 +544,13 @@ For usage and examples: colpick.com/plugin
var h = hsb.h;
var s = hsb.s*255/100;
var v = hsb.b*255/100;
if (s == 0) {
if (s == 0) { // eslint-disable-line eqeqeq
rgb.r = rgb.g = rgb.b = v;
} else {
var t1 = v;
var t2 = (255-s)*v/255;
var t3 = (t1-t2)*(h%60)/60;
if (h==360) {
if (h==360) { // eslint-disable-line eqeqeq
h = 0;
}
if (h<60) {
@ -578,7 +578,7 @@ For usage and examples: colpick.com/plugin
rgb.b.toString(16)
];
$.each(hex, function (nr, val) {
if (val.length == 1) {
if (val.length == 1) { // eslint-disable-line eqeqeq
hex[nr] = '0' + val;
}
});