Mirrors/overte-lubosz
3
0
Fork 0
mirror of https://github.com/lubosz/overte.git synced 2025-04-09 14:34:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Partial fix for asset scripting crash

Browse source
This commit is contained in:
ksuprynowicz 2023-03-22 20:40:15 +01:00
parent e75c671a70
commit e14ae4a96a
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libraries/script-engine/src/AssetScriptingInterface.cpp
View file

@ -245,6 +245,8 @@ void AssetScriptingInterface::jsCallback(const ScriptValue& handler,
const ScriptValue& error, const ScriptValue& result) {
Q_ASSERT(thread() == QThread::currentThread());
Q_ASSERT(engine);
//V8TODO: which kind of script context guard needs to be used here?
ScriptContextGuard scriptContextGuard(engine()->currentContext());
auto errorValue = !error.toBool() ? engine()->nullValue() : error;
JS_VERIFY(handler.isObject() && handler.property("callback").isFunction(),
QString("jsCallback -- .callback is not a function (%1)")
@ -257,6 +259,7 @@ void AssetScriptingInterface::jsCallback(const ScriptValue& handler,
Q_ASSERT(thread() == QThread::currentThread());
Q_ASSERT(handler.engine());
auto engine = handler.engine();
jsCallback(handler, error, engine->toScriptValue(result));
}