Mirrors/overte-lubosz
3
0
Fork 0
mirror of https://github.com/lubosz/overte.git synced 2025-08-04 13:45:04 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #13295 from zfox23/MS15574_WalletMemoryLeak

Browse source 
Fix MS15574: Tiny memory leak in Wallet.h
This commit is contained in:
Zach Fox 2018-06-07 12:42:24 -07:00 committed by GitHub
commit d33875e142
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
interface/src/commerce/Wallet.cpp
View file

@ -314,6 +314,7 @@ Wallet::Wallet() {
auto nodeList = DependencyManager::get<NodeList>(); auto nodeList = DependencyManager::get<NodeList>();
auto ledger = DependencyManager::get<Ledger>(); auto ledger = DependencyManager::get<Ledger>();
auto& packetReceiver = nodeList->getPacketReceiver(); auto& packetReceiver = nodeList->getPacketReceiver();
_passphrase = new QString("");
packetReceiver.registerListener(PacketType::ChallengeOwnership, this, "handleChallengeOwnershipPacket"); packetReceiver.registerListener(PacketType::ChallengeOwnership, this, "handleChallengeOwnershipPacket");
packetReceiver.registerListener(PacketType::ChallengeOwnershipRequest, this, "handleChallengeOwnershipPacket"); packetReceiver.registerListener(PacketType::ChallengeOwnershipRequest, this, "handleChallengeOwnershipPacket");
@ -365,6 +366,10 @@ Wallet::~Wallet() {
if (_securityImage) { if (_securityImage) {
delete _securityImage; delete _securityImage;
} }
if (_passphrase) {
delete _passphrase;
}
} }
bool Wallet::setPassphrase(const QString& passphrase) { bool Wallet::setPassphrase(const QString& passphrase) {

2
interface/src/commerce/Wallet.h
View file

@ -78,7 +78,7 @@ private:
QByteArray _salt; QByteArray _salt;
QByteArray _iv; QByteArray _iv;
QByteArray _ckey; QByteArray _ckey;
QString* _passphrase { new QString("") }; QString* _passphrase { nullptr };
bool _isOverridingServer { false }; bool _isOverridingServer { false };
bool writeWallet(const QString& newPassphrase = QString("")); bool writeWallet(const QString& newPassphrase = QString(""));