Mirrors/overte-lubosz
3
0
Fork 0
mirror of https://github.com/lubosz/overte.git synced 2025-04-08 18:02:23 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fixed assert on ScriptValueV8Wrapper::construct

Browse source
This commit is contained in:
ksuprynowicz 2023-04-16 11:12:25 +02:00
parent 28079eb2df
commit c18fd9092e
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
libraries/script-engine/src/v8/ScriptValueV8Wrapper.cpp
View file

@ -154,8 +154,13 @@ ScriptValue ScriptValueV8Wrapper::construct(const ScriptValueList& args) {
for (ScriptValueList::const_iterator iter = args.begin(); iter != args.end(); ++iter) {
v8Args[argIndex++] = fullUnwrap(*iter).get();
}
//V8TODO should there be a v8 try-catch here?
Q_ASSERT(_value.get()->IsFunction());
//V8TODO: should there be a v8 try-catch here?
//V8TODO: Can something else than a function be callable in this way in JS?
if (!_value.get()->IsFunction()) {
qCWarning(scriptengine_v8) << "ScriptValueV8Wrapper::construct: value is not a function";
return _engine->undefinedValue();
}
v8::Local<v8::Function> v8Function = v8::Local<v8::Function>::Cast(_value.get());
auto maybeResult = v8Function->NewInstance(_engine->getContext(), args.length(), v8Args);
v8::Local<v8::Object> result;