Mirrors/overte-lubosz
3
0
Fork 0
mirror of https://github.com/lubosz/overte.git synced 2025-04-25 18:15:26 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

respond to code-review

Browse source
This commit is contained in:
Seth Alves 2015-04-25 10:50:18 -07:00
parent 0fb1a83e3b
commit b69cba1aba
6 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
interface/src/Application.cpp
View file

@ -1058,7 +1058,6 @@ void Application::keyPressEvent(QKeyEvent* event) {
bool isShifted = event->modifiers().testFlag(Qt::ShiftModifier); bool isShifted = event->modifiers().testFlag(Qt::ShiftModifier);
bool isMeta = event->modifiers().testFlag(Qt::ControlModifier); bool isMeta = event->modifiers().testFlag(Qt::ControlModifier);
bool isOption = event->modifiers().testFlag(Qt::AltModifier); bool isOption = event->modifiers().testFlag(Qt::AltModifier);
// bool isKeypad = event->modifiers().testFlag(Qt::KeypadModifier);
switch (event->key()) { switch (event->key()) {
break; break;
case Qt::Key_L: case Qt::Key_L:

1
interface/src/ui/ApplicationOverlay.cpp
View file

@ -257,7 +257,6 @@ void ApplicationOverlay::displayOverlayTexture() {
if (_alpha == 0.0f) { if (_alpha == 0.0f) {
return; return;
} }
// auto glCanvas = Application::getInstance()->getGLWidget();
glMatrixMode(GL_PROJECTION); glMatrixMode(GL_PROJECTION);
glPushMatrix(); { glPushMatrix(); {
glLoadIdentity(); glLoadIdentity();

1
libraries/gpu/src/gpu/GLBackendOutput.cpp
View file

@ -24,7 +24,6 @@ GLBackend::GLFramebuffer* GLBackend::syncGPUObject(const Framebuffer& framebuffe
GLFramebuffer* object = Backend::getGPUObject<GLBackend::GLFramebuffer>(framebuffer); GLFramebuffer* object = Backend::getGPUObject<GLBackend::GLFramebuffer>(framebuffer);
// If GPU object already created and in sync // If GPU object already created and in sync
// bool needUpdate = false;
if (object) { if (object) {
return object; return object;
} else if (framebuffer.isEmpty()) { } else if (framebuffer.isEmpty()) {

3
libraries/gpu/src/gpu/GLBackendTexture.cpp
View file

@ -177,8 +177,7 @@ public:
break; break;
} }
case gpu::NUM_TYPES: { // quiet compiler case gpu::NUM_TYPES: { // quiet compiler
assert(false); Q_UNREACHABLE();
break;
} }
} }
break; break;

3
libraries/networking/src/DataServerAccountInfo.cpp
View file

@ -35,8 +35,7 @@ DataServerAccountInfo::DataServerAccountInfo() :
} }
DataServerAccountInfo::DataServerAccountInfo(const DataServerAccountInfo& otherInfo) { DataServerAccountInfo::DataServerAccountInfo(const DataServerAccountInfo& otherInfo) : QObject() {
QObject(),
_accessToken = otherInfo._accessToken; _accessToken = otherInfo._accessToken;
_username = otherInfo._username; _username = otherInfo._username;
_xmppPassword = otherInfo._xmppPassword; _xmppPassword = otherInfo._xmppPassword;

1
libraries/render-utils/src/Model.cpp
View file

@ -111,7 +111,6 @@ void Model::RenderPipelineLib::addRenderPipeline(Model::RenderKey key,
slotBindings.insert(gpu::Shader::Binding(std::string("emissiveMap"), 3)); slotBindings.insert(gpu::Shader::Binding(std::string("emissiveMap"), 3));
gpu::ShaderPointer program = gpu::ShaderPointer(gpu::Shader::createProgram(vertexShader, pixelShader)); gpu::ShaderPointer program = gpu::ShaderPointer(gpu::Shader::createProgram(vertexShader, pixelShader));
// bool makeResult =
gpu::Shader::makeProgram(*program, slotBindings); gpu::Shader::makeProgram(*program, slotBindings);