Mirrors/overte-lubosz
3
0
Fork 0
mirror of https://github.com/lubosz/overte.git synced 2025-08-08 04:08:13 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix invalid iterator access

Browse source
This commit is contained in:
Atlante45 2018-02-21 18:06:31 -08:00
parent e12ca2683f
commit a2c94bd9d2
1 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
domain-server/src/AssetsBackupHandler.cpp
View file

@ -279,7 +279,7 @@ void AssetsBackupHandler::recoverBackup(const QString& backupName, QuaZip& zip)
qCWarning(asset_backup) << "Current asset mappings that might be stale."; qCWarning(asset_backup) << "Current asset mappings that might be stale.";
} }
const auto it = find_if(begin(_backups), end(_backups), [&](const AssetServerBackup& backup) { auto it = find_if(begin(_backups), end(_backups), [&](const AssetServerBackup& backup) {
return backup.name == backupName; return backup.name == backupName;
}); });
if (it == end(_backups)) { if (it == end(_backups)) {
@ -306,6 +306,17 @@ void AssetsBackupHandler::recoverBackup(const QString& backupName, QuaZip& zip)
writeAssetFile(asset, zipFile.readAll()); writeAssetFile(asset, zipFile.readAll());
} }
} }
// iterator is end() and has been invalidated in the `loadBackup` call
// grab the new iterator
it = find_if(begin(_backups), end(_backups), [&](const AssetServerBackup& backup) {
return backup.name == backupName;
});
if (it == end(_backups)) {
qCCritical(asset_backup) << "Failed to recover backup:" << backupName;
return;
}
} }
const auto& newMappings = it->mappings; const auto& newMappings = it->mappings;