move getCollisionShapeURL() back to base class

This commit is contained in:
Andrew Meadows 2019-07-09 15:45:41 -07:00
parent 2da0714e36
commit 9a6b42ec28
4 changed files with 7 additions and 7 deletions

View file

@ -959,10 +959,6 @@ QStringList RenderableModelEntityItem::getJointNames() const {
return result; return result;
} }
QString RenderableModelEntityItem::getCollisionShapeURL() const {
return getShapeType() == SHAPE_TYPE_COMPOUND ? getCompoundShapeURL() : getModelURL();
}
scriptable::ScriptableModelBase render::entities::ModelEntityRenderer::getScriptableModel() { scriptable::ScriptableModelBase render::entities::ModelEntityRenderer::getScriptableModel() {
auto model = resultWithReadLock<ModelPointer>([this]{ return _model; }); auto model = resultWithReadLock<ModelPointer>([this]{ return _model; });

View file

@ -113,9 +113,6 @@ public:
virtual int getJointIndex(const QString& name) const override; virtual int getJointIndex(const QString& name) const override;
virtual QStringList getJointNames() const override; virtual QStringList getJointNames() const override;
// Returns the URL used for the collision shape
QString getCollisionShapeURL() const;
private: private:
bool needsUpdateModelBounds() const; bool needsUpdateModelBounds() const;
void autoResizeJointArrays(); void autoResizeJointArrays();

View file

@ -590,6 +590,10 @@ QString ModelEntityItem::getCompoundShapeURL() const {
return _compoundShapeURL.get(); return _compoundShapeURL.get();
} }
QString ModelEntityItem::getCollisionShapeURL() const {
return getShapeType() == SHAPE_TYPE_COMPOUND ? getCompoundShapeURL() : getModelURL();
}
void ModelEntityItem::setColor(const glm::u8vec3& value) { void ModelEntityItem::setColor(const glm::u8vec3& value) {
withWriteLock([&] { withWriteLock([&] {
_color = value; _color = value;

View file

@ -75,6 +75,9 @@ public:
static const QString DEFAULT_COMPOUND_SHAPE_URL; static const QString DEFAULT_COMPOUND_SHAPE_URL;
QString getCompoundShapeURL() const; QString getCompoundShapeURL() const;
// Returns the URL used for the collision shape
QString getCollisionShapeURL() const;
// model related properties // model related properties
virtual void setModelURL(const QString& url); virtual void setModelURL(const QString& url);
virtual void setCompoundShapeURL(const QString& url); virtual void setCompoundShapeURL(const QString& url);