more warnings fixes

This commit is contained in:
Brad Hefta-Gaub 2015-09-22 21:18:04 -07:00
parent 5b00783f18
commit 9436d2922f
4 changed files with 12 additions and 7 deletions

View file

@ -6,4 +6,7 @@
// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
//
#include "GLEscrow.h"
// FIXME - I don't think we need to actually include this in a CPP, all callers will simply
// use the header file and the result will be the code will be expanded inline.
// however, including it in a CPP file produces a linker warning on windows.
//#include "GLEscrow.h"

View file

@ -6,4 +6,7 @@
// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
//
#include "MatrixStack.h"
// FIXME - I don't think we need to actually include this in a CPP, all callers will simply
// use the header file and the result will be the code will be expanded inline.
// however, including it in a CPP file produces a linker warning on windows.
//#include "MatrixStack.h"

View file

@ -6,5 +6,8 @@
// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
//
#include "ReadWriteLockable.h"
// FIXME - I don't think we need to actually include this in a CPP, all callers will simply
// use the header file and the result will be the code will be expanded inline.
// however, including it in a CPP file produces a linker warning on windows.
//#include "ReadWriteLockable.h"

View file

@ -93,10 +93,6 @@ template <typename T>
void testByteCountCoded() {
testByteCountCodedStable<T>(0);
testByteCountCodedStable<T>(1);
// These two can't possibly be right. TODO: figure out what was being tested, here
// testByteCountCodedStable<T>(1 << 8*sizeof(T));
// testByteCountCodedStable<T>(std::numeric_limits<T>::max() >> 8*sizeof(T));
testByteCountCodedStable<T>(std::numeric_limits<T>::max() >> 8);
testByteCountCodedStable<T>(std::numeric_limits<T>::max() >> 1);
testByteCountCodedStable<T>(std::numeric_limits<T>::max());
}