Merge pull request #8075 from ctrlaltdavid/20970

fix reporting of JSON export failure

interface/src/Application.cpp

@@ -2916,7 +2916,7 @@ bool Application::exportEntities(const QString& filename, const QVector<EntityIt
         }
     });
     if (success) {
-        exportTree->writeToJSONFile(filename.toLocal8Bit().constData());
+        success = exportTree->writeToJSONFile(filename.toLocal8Bit().constData());
 
         // restore the main window's active state
         _window->activateWindow();

libraries/octree/src/Octree.cpp

@@ -1868,24 +1868,26 @@ bool Octree::readJSONFromStream(unsigned long streamLength, QDataStream& inputSt
     return success;
 }
 
-void Octree::writeToFile(const char* fileName, OctreeElementPointer element, QString persistAsFileType) {
+bool Octree::writeToFile(const char* fileName, OctreeElementPointer element, QString persistAsFileType) {
     // make the sure file extension makes sense
     QString qFileName = fileNameWithoutExtension(QString(fileName), PERSIST_EXTENSIONS) + "." + persistAsFileType;
     QByteArray byteArray = qFileName.toUtf8();
     const char* cFileName = byteArray.constData();
 
+    bool success = false;
     if (persistAsFileType == "svo") {
-        writeToSVOFile(fileName, element);
+        success = writeToSVOFile(fileName, element);
     } else if (persistAsFileType == "json") {
-        writeToJSONFile(cFileName, element);
+        success = writeToJSONFile(cFileName, element);
     } else if (persistAsFileType == "json.gz") {
-        writeToJSONFile(cFileName, element, true);
+        success = writeToJSONFile(cFileName, element, true);
     } else {
         qCDebug(octree) << "unable to write octree to file of type" << persistAsFileType;
     }
+    return success;
 }
 
-void Octree::writeToJSONFile(const char* fileName, OctreeElementPointer element, bool doGzip) {
+bool Octree::writeToJSONFile(const char* fileName, OctreeElementPointer element, bool doGzip) {
     QVariantMap entityDescription;
 
     qCDebug(octree, "Saving JSON SVO to file %s...", fileName);
@@ -1906,7 +1908,7 @@ void Octree::writeToJSONFile(const char* fileName, OctreeElementPointer element,
     bool entityDescriptionSuccess = writeToMap(entityDescription, top, true, true);
     if (!entityDescriptionSuccess) {
         qCritical("Failed to convert Entities to QVariantMap while saving to json.");
-        return;
+        return false;
     }
 
     // convert the QVariantMap to JSON
@@ -1916,22 +1918,26 @@ void Octree::writeToJSONFile(const char* fileName, OctreeElementPointer element,
     if (doGzip) {
         if (!gzip(jsonData, jsonDataForFile, -1)) {
             qCritical("unable to gzip data while saving to json.");
-            return;
+            return false;
         }
     } else {
         jsonDataForFile = jsonData;
     }
 
     QFile persistFile(fileName);
+    bool success = false;
     if (persistFile.open(QIODevice::WriteOnly)) {
-        persistFile.write(jsonDataForFile);
+        success = persistFile.write(jsonDataForFile) != -1;
     } else {
         qCritical("Could not write to JSON description of entities.");
     }
+
+    return success;
 }
 
-void Octree::writeToSVOFile(const char* fileName, OctreeElementPointer element) {
+bool Octree::writeToSVOFile(const char* fileName, OctreeElementPointer element) {
-    qWarning() << "SVO file format depricated. Support for reading SVO files is no longer support and will be removed soon.";
+    qWarning() << "SVO file format deprecated. Support for reading SVO files is no longer support and will be removed soon.";
+    bool success = false;
 
     std::ofstream file(fileName, std::ios::out|std::ios::binary);
 
@@ -2010,8 +2016,12 @@ void Octree::writeToSVOFile(const char* fileName, OctreeElementPointer element)
         }
 
         releaseSceneEncodeData(&extraEncodeData);
+
+        success = true;
     }
     file.close();
+
+    return success;
 }
 
 unsigned long Octree::getOctreeElementsCount() {

libraries/octree/src/Octree.h

@@ -299,9 +299,9 @@ public:
     void loadOctreeFile(const char* fileName);
 
     // Octree exporters
-    void writeToFile(const char* filename, OctreeElementPointer element = NULL, QString persistAsFileType = "svo");
+    bool writeToFile(const char* filename, OctreeElementPointer element = NULL, QString persistAsFileType = "svo");
-    void writeToJSONFile(const char* filename, OctreeElementPointer element = NULL, bool doGzip = false);
+    bool writeToJSONFile(const char* filename, OctreeElementPointer element = NULL, bool doGzip = false);
-    void writeToSVOFile(const char* filename, OctreeElementPointer element = NULL);
+    bool writeToSVOFile(const char* filename, OctreeElementPointer element = NULL);
     virtual bool writeToMap(QVariantMap& entityDescription, OctreeElementPointer element, bool skipDefaultValues,
                             bool skipThoseWithBadParents) = 0;