error handling, warnings for duplicate textures

This commit is contained in:
David Back 2019-02-14 16:09:48 -08:00
parent 4e4ec9940f
commit 7cffcf2215
2 changed files with 106 additions and 60 deletions

View file

@ -263,6 +263,7 @@ class AvatarExporter : MonoBehaviour {
static string assetPath = "";
static string assetName = "";
static HumanDescription humanDescription;
static Dictionary<string, string> dependencyTextures = new Dictionary<string, string>();
[MenuItem("High Fidelity/Export New Avatar")]
static void ExportNewAvatar() {
@ -304,51 +305,38 @@ class AvatarExporter : MonoBehaviour {
humanDescription = modelImporter.humanDescription;
SetUserBoneInformation();
string textureWarnings = SetTextureDependencies();
// generate the list of bone rule failure strings for any bone rules that are not satisfied by this avatar
SetFailedBoneRules();
// check if we should be substituting a bone for a missing UpperChest mapping
AdjustUpperChestMapping();
// format resulting bone rule failure strings
// consider export-blocking bone rules to be errors and show them in an error dialog,
// and also include any other bone rule failures as warnings in the dialog
// and also include any other bone rule failures plus texture warnings as warnings in the dialog
string boneErrors = "";
string boneWarnings = "";
string warnings = "";
foreach (var failedBoneRule in failedBoneRules) {
if (Array.IndexOf(EXPORT_BLOCKING_BONE_RULES, failedBoneRule.Key) >= 0) {
boneErrors += failedBoneRule.Value + "\n\n";
} else {
boneWarnings += failedBoneRule.Value + "\n\n";
warnings += failedBoneRule.Value + "\n\n";
}
}
warnings += textureWarnings;
if (!string.IsNullOrEmpty(boneErrors)) {
// if there are both errors and warnings then warnings will be displayed with errors in the error dialog
if (!string.IsNullOrEmpty(boneWarnings)) {
if (!string.IsNullOrEmpty(warnings)) {
boneErrors = "Errors:\n\n" + boneErrors;
boneErrors += "Warnings:\n\n" + boneWarnings;
boneErrors += "Warnings:\n\n" + warnings;
}
// remove ending newlines from the last rule failure string that was added above
boneErrors = boneErrors.Substring(0, boneErrors.LastIndexOf("\n\n"));
EditorUtility.DisplayDialog("Error", boneErrors, "Ok");
return;
}
if (!humanoidToUserBoneMappings.ContainsKey("UpperChest")) {
// if parent of Neck is not Chest then map the parent to UpperChest
string neckUserBone;
if (humanoidToUserBoneMappings.TryGetValue("Neck", out neckUserBone)) {
UserBoneInformation neckParentBoneInfo;
string neckParentUserBone = userBoneInfos[neckUserBone].parentName;
if (userBoneInfos.TryGetValue(neckParentUserBone, out neckParentBoneInfo) && !neckParentBoneInfo.HasHumanMapping()) {
neckParentBoneInfo.humanName = "UpperChest";
humanoidToUserBoneMappings.Add("UpperChest", neckParentUserBone);
}
}
// if there is still no UpperChest bone but there is a Chest bone then we remap Chest to UpperChest
string chestUserBone;
if (!humanoidToUserBoneMappings.ContainsKey("UpperChest") &&
humanoidToUserBoneMappings.TryGetValue("Chest", out chestUserBone)) {
userBoneInfos[chestUserBone].humanName = "UpperChest";
humanoidToUserBoneMappings.Remove("Chest");
humanoidToUserBoneMappings.Add("UpperChest", chestUserBone);
}
}
string documentsFolder = System.Environment.GetFolderPath(System.Environment.SpecialFolder.MyDocuments);
string hifiFolder = documentsFolder + "\\High Fidelity Projects";
@ -407,7 +395,13 @@ class AvatarExporter : MonoBehaviour {
return;
} else if (option == 0) { // Yes - copy model to Unity project
// copy the fbx from the project folder to Unity Assets, overwriting the existing fbx, and re-import it
File.Copy(exportModelPath, assetPath, true);
try {
File.Copy(exportModelPath, assetPath, true);
} catch {
EditorUtility.DisplayDialog("Error", "Failed to copy existing file " + exportModelPath + " to " + assetPath +
". Please check the location and try again.", "Ok");
return;
}
AssetDatabase.ImportAsset(assetPath);
// set model to Humanoid animation type and force another refresh on it to process Humanoid
@ -455,12 +449,21 @@ class AvatarExporter : MonoBehaviour {
}
// write out a new fst file in place of the old file
WriteFST(exportFstPath, projectName);
if (!WriteFST(exportFstPath, projectName)) {
return;
}
// copy any external texture files to the project's texture directory that are
// considered dependencies of the model, and overwrite any existing ones
string texturesDirectory = Path.GetDirectoryName(exportFstPath) + "\\textures";
if (!CopyExternalTextures(texturesDirectory, true)) {
return;
}
// display success dialog with any bone rule warnings
string successDialog = "Avatar successfully updated!";
if (!string.IsNullOrEmpty(boneWarnings)) {
successDialog += "\n\nWarnings:\n" + boneWarnings;
if (!string.IsNullOrEmpty(warnings)) {
successDialog += "\n\nWarnings:\n" + warnings;
}
EditorUtility.DisplayDialog("Success!", successDialog, "Ok");
} else { // Export New Avatar menu option
@ -469,33 +472,13 @@ class AvatarExporter : MonoBehaviour {
Directory.CreateDirectory(hifiFolder);
}
if (string.IsNullOrEmpty(boneWarnings)) {
boneWarnings = EMPTY_WARNING_TEXT;
if (string.IsNullOrEmpty(warnings)) {
warnings = EMPTY_WARNING_TEXT;
}
// open a popup window to enter new export project name and project location
ExportProjectWindow window = ScriptableObject.CreateInstance<ExportProjectWindow>();
window.Init(hifiFolder, boneWarnings, OnExportProjectWindowClose);
}
}
static void CopyExternalTextures(string texturesDirectory) {
List<string> texturePaths = new List<string>();
// build the list of all local asset paths for textures that Unity considers dependencies of the model
string[] dependencies = AssetDatabase.GetDependencies(assetPath);
foreach (string dependencyPath in dependencies) {
UnityEngine.Object textureObject = AssetDatabase.LoadAssetAtPath(dependencyPath, typeof(Texture2D));
if (textureObject != null) {
texturePaths.Add(dependencyPath);
}
}
// copy the found dependency textures from the local asset folder to the textures folder in the target export project
foreach (string texturePath in texturePaths) {
string textureName = Path.GetFileName(texturePath);
string targetPath = texturesDirectory + "\\" + textureName;
File.Copy(texturePath, targetPath);
window.Init(hifiFolder, warnings, OnExportProjectWindowClose);
}
}
@ -512,11 +495,15 @@ class AvatarExporter : MonoBehaviour {
// write out the avatar.fst file to the project directory
string exportFstPath = projectDirectory + "avatar.fst";
WriteFST(exportFstPath, projectName);
if (!WriteFST(exportFstPath, projectName)) {
return;
}
// copy any external texture files to the project's texture directory that are considered dependencies of the model
texturesDirectory = texturesDirectory.Replace("\\\\", "\\");
CopyExternalTextures(texturesDirectory);
if (!CopyExternalTextures(texturesDirectory, false)) {
return;
}
// remove any double slashes in texture directory path, display success dialog with any
// bone warnings previously mentioned, and suggest user to copy external textures over
@ -529,7 +516,7 @@ class AvatarExporter : MonoBehaviour {
EditorUtility.DisplayDialog("Success!", successDialog, "Ok");
}
static void WriteFST(string exportFstPath, string projectName) {
static bool WriteFST(string exportFstPath, string projectName) {
// write out core fields to top of fst file
try {
File.WriteAllText(exportFstPath, "name = " + projectName + "\ntype = body+head\nscale = 1\nfilename = " +
@ -537,7 +524,7 @@ class AvatarExporter : MonoBehaviour {
} catch {
EditorUtility.DisplayDialog("Error", "Failed to write file " + exportFstPath +
". Please check the location and try again.", "Ok");
return;
return false;
}
// write out joint mappings to fst file
@ -596,6 +583,8 @@ class AvatarExporter : MonoBehaviour {
// open File Explorer to the project directory once finished
System.Diagnostics.Process.Start("explorer.exe", "/select," + exportFstPath);
return true;
}
static void SetUserBoneInformation() {
@ -625,9 +614,6 @@ class AvatarExporter : MonoBehaviour {
}
}
}
// generate the list of bone rule failure strings for any bone rules that are not satisfied by this avatar
SetFailedBoneRules();
}
static void TraverseUserBoneTree(Transform modelBone) {
@ -675,6 +661,29 @@ class AvatarExporter : MonoBehaviour {
return result;
}
static void AdjustUpperChestMapping() {
if (!humanoidToUserBoneMappings.ContainsKey("UpperChest")) {
// if parent of Neck is not Chest then map the parent to UpperChest
string neckUserBone;
if (humanoidToUserBoneMappings.TryGetValue("Neck", out neckUserBone)) {
UserBoneInformation neckParentBoneInfo;
string neckParentUserBone = userBoneInfos[neckUserBone].parentName;
if (userBoneInfos.TryGetValue(neckParentUserBone, out neckParentBoneInfo) && !neckParentBoneInfo.HasHumanMapping()) {
neckParentBoneInfo.humanName = "UpperChest";
humanoidToUserBoneMappings.Add("UpperChest", neckParentUserBone);
}
}
// if there is still no UpperChest bone but there is a Chest bone then we remap Chest to UpperChest
string chestUserBone;
if (!humanoidToUserBoneMappings.ContainsKey("UpperChest") &&
humanoidToUserBoneMappings.TryGetValue("Chest", out chestUserBone)) {
userBoneInfos[chestUserBone].humanName = "UpperChest";
humanoidToUserBoneMappings.Remove("Chest");
humanoidToUserBoneMappings.Add("UpperChest", chestUserBone);
}
}
}
static void SetFailedBoneRules() {
failedBoneRules.Clear();
@ -888,6 +897,43 @@ class AvatarExporter : MonoBehaviour {
appendage + " (" + rightCount + ").");
}
}
static string SetTextureDependencies() {
string textureWarnings = "";
dependencyTextures.Clear();
// build the list of all local asset paths for textures that Unity considers dependencies of the model
// for any textures that have duplicate names, return a string of duplicate name warnings
string[] dependencies = AssetDatabase.GetDependencies(assetPath);
foreach (string dependencyPath in dependencies) {
UnityEngine.Object textureObject = AssetDatabase.LoadAssetAtPath(dependencyPath, typeof(Texture2D));
if (textureObject != null) {
string textureName = Path.GetFileName(dependencyPath);
if (dependencyTextures.ContainsKey(textureName)) {
textureWarnings += "There is more than one texture with the name " + textureName + ".\n\n";
} else {
dependencyTextures.Add(textureName, dependencyPath);
}
}
}
return textureWarnings;
}
static bool CopyExternalTextures(string texturesDirectory, bool overwriteExisting) {
// copy the found dependency textures from the local asset folder to the textures folder in the target export project
foreach (var texture in dependencyTextures) {
string targetPath = texturesDirectory + "\\" + texture.Key;
try {
File.Copy(texture.Value, targetPath, overwriteExisting);
} catch {
EditorUtility.DisplayDialog("Error", "Failed to copy texture file " + texture.Value + " to " + targetPath +
". Please check the location and try again.", "Ok");
return false;
}
}
return true;
}
}
class ExportProjectWindow : EditorWindow {