Update JSONCallbackParameters to take params in constructor

This commit is contained in:
Ryan Huffman 2014-07-02 11:12:06 -07:00
parent f0c013960d
commit 70121357be
3 changed files with 15 additions and 21 deletions

View file

@ -34,11 +34,7 @@ void UserLocation::requestRename(const QString& newName) {
if (!_updating && newName.toLower() != _name) { if (!_updating && newName.toLower() != _name) {
_updating = true; _updating = true;
JSONCallbackParameters callbackParams; JSONCallbackParameters callbackParams(this, "handleRenameResponse", this, "handleRenameError");
callbackParams.jsonCallbackReceiver = this;
callbackParams.jsonCallbackMethod = "handleRenameResponse";
callbackParams.errorCallbackReceiver = this;
callbackParams.errorCallbackMethod = "handleRenameError";
QJsonObject jsonNameObject; QJsonObject jsonNameObject;
jsonNameObject.insert("name", QJsonValue(newName)); jsonNameObject.insert("name", QJsonValue(newName));
QJsonDocument jsonDocument(jsonNameObject); QJsonDocument jsonDocument(jsonNameObject);
@ -93,11 +89,7 @@ void UserLocation::requestDelete() {
if (!_updating) { if (!_updating) {
_updating = true; _updating = true;
JSONCallbackParameters callbackParams; JSONCallbackParameters callbackParams(this, "handleDeleteResponse", this, "handleDeleteError");
callbackParams.jsonCallbackReceiver = this;
callbackParams.jsonCallbackMethod = "handleDeleteResponse";
callbackParams.errorCallbackReceiver = this;
callbackParams.errorCallbackMethod = "handleDeleteError";
AccountManager::getInstance().authenticatedRequest(PLACES_DELETE.arg(_id), AccountManager::getInstance().authenticatedRequest(PLACES_DELETE.arg(_id),
QNetworkAccessManager::DeleteOperation, QNetworkAccessManager::DeleteOperation,
callbackParams); callbackParams);
@ -160,9 +152,7 @@ void UserLocationsModel::refresh() {
_updating = true; _updating = true;
endResetModel(); endResetModel();
JSONCallbackParameters callbackParams; JSONCallbackParameters callbackParams(this, "handleLocationsResponse");
callbackParams.jsonCallbackReceiver = this;
callbackParams.jsonCallbackMethod = "handleLocationsResponse";
AccountManager::getInstance().authenticatedRequest(PLACES_GET, AccountManager::getInstance().authenticatedRequest(PLACES_GET,
QNetworkAccessManager::GetOperation, QNetworkAccessManager::GetOperation,
callbackParams); callbackParams);

View file

@ -37,13 +37,15 @@ Q_DECLARE_METATYPE(JSONCallbackParameters)
const QString ACCOUNTS_GROUP = "accounts"; const QString ACCOUNTS_GROUP = "accounts";
JSONCallbackParameters::JSONCallbackParameters() : JSONCallbackParameters::JSONCallbackParameters(QObject* jsonCallbackReceiver, const QString& jsonCallbackMethod,
jsonCallbackReceiver(NULL), QObject* errorCallbackReceiver, const QString& errorCallbackMethod,
jsonCallbackMethod(), QObject* updateReceiver, const QString& updateSlot) :
errorCallbackReceiver(NULL), jsonCallbackReceiver(jsonCallbackReceiver),
errorCallbackMethod(), jsonCallbackMethod(jsonCallbackMethod),
updateReciever(NULL), errorCallbackReceiver(errorCallbackReceiver),
updateSlot() errorCallbackMethod(errorCallbackMethod),
updateReciever(updateReceiver),
updateSlot(updateSlot)
{ {
} }

View file

@ -22,7 +22,9 @@
class JSONCallbackParameters { class JSONCallbackParameters {
public: public:
JSONCallbackParameters(); JSONCallbackParameters(QObject* jsonCallbackReceiver = NULL, const QString& jsonCallbackMethod = QString(),
QObject* errorCallbackReceiver = NULL, const QString& errorCallbackMethod = QString(),
QObject* updateReceiver = NULL, const QString& updateSlot = QString());
bool isEmpty() const { return !jsonCallbackReceiver && !errorCallbackReceiver; } bool isEmpty() const { return !jsonCallbackReceiver && !errorCallbackReceiver; }