Merge pull request #13311 from ElderOrb/FB14390

terminate thread if it didn't complete during MAX_SCRIPT_QUITTING_TIME
This commit is contained in:
John Conklin II 2018-06-07 11:22:57 -07:00 committed by GitHub
commit 66b66d5248
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -419,7 +419,7 @@ void ScriptEngine::waitTillDoneRunning() {
// Wait for the scripting thread to stop running, as
// flooding it with aborts/exceptions will persist it longer
static const auto MAX_SCRIPT_QUITTING_TIME = 0.5 * MSECS_PER_SECOND;
if (workerThread->wait(MAX_SCRIPT_QUITTING_TIME)) {
if (!workerThread->wait(MAX_SCRIPT_QUITTING_TIME)) {
workerThread->terminate();
}
}