From 1759e360b1e1cf0e5a688ce53e39dce0c6651a7e Mon Sep 17 00:00:00 2001 From: Dale Glass Date: Mon, 29 Mar 2021 22:44:34 +0200 Subject: [PATCH] Capture by value rather than by reference This fixes a stack-use-after-return error in RenderableModelEntityItem. Fixes #1128 --- .../entities-renderer/src/RenderableModelEntityItem.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/entities-renderer/src/RenderableModelEntityItem.cpp b/libraries/entities-renderer/src/RenderableModelEntityItem.cpp index 3c245e5d4f..69bd752395 100644 --- a/libraries/entities-renderer/src/RenderableModelEntityItem.cpp +++ b/libraries/entities-renderer/src/RenderableModelEntityItem.cpp @@ -1254,13 +1254,13 @@ void ModelEntityRenderer::doRenderUpdateAsynchronousTyped(const TypedEntityPoint if (_hasModel && !model) { model = std::make_shared(nullptr, entity.get(), _created); connect(model.get(), &Model::requestRenderUpdate, this, &ModelEntityRenderer::requestRenderUpdate); - connect(model.get(), &Model::setURLFinished, this, [&](bool didVisualGeometryRequestSucceed) { + connect(model.get(), &Model::setURLFinished, this, [=](bool didVisualGeometryRequestSucceed) { _didLastVisualGeometryRequestSucceed = didVisualGeometryRequestSucceed; const render::ScenePointer& scene = AbstractViewStateInterface::instance()->getMain3DScene(); render::Transaction transaction; - transaction.updateItem(_renderItemID, [&](PayloadProxyInterface& self) { + transaction.updateItem(_renderItemID, [=](PayloadProxyInterface& self) { const render::ScenePointer& scene = AbstractViewStateInterface::instance()->getMain3DScene(); - withWriteLock([&] { + withWriteLock([=] { setKey(didVisualGeometryRequestSucceed, _model); _model->setVisibleInScene(_visible, scene); _model->setCauterized(_cauterized, scene);