From 4a294b389945937643d58c525c91de6d355825ce Mon Sep 17 00:00:00 2001 From: Ken Cooke Date: Sat, 1 Jun 2019 14:31:14 -0700 Subject: [PATCH] Add sanity check for buffer overflow due to resampling --- libraries/audio-client/src/AudioClient.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libraries/audio-client/src/AudioClient.cpp b/libraries/audio-client/src/AudioClient.cpp index cb8fbbdb0b..8797b90860 100644 --- a/libraries/audio-client/src/AudioClient.cpp +++ b/libraries/audio-client/src/AudioClient.cpp @@ -713,6 +713,10 @@ int possibleResampling(AudioSRC* resampler, } int numDestinationSamples = numDestinationFrames * destinationChannelCount; + if (numDestinationSamples > maxDestinationSamples) { + qCWarning(audioclient) << "Resampler overflow! numDestinationSamples =" << numDestinationSamples + << "but maxDestinationSamples =" << maxDestinationSamples; + } return numDestinationSamples; }