Addressing review comments

This commit is contained in:
samcake 2018-02-09 10:02:16 -08:00
parent 0e25b7bd35
commit 4419dfe622
3 changed files with 2 additions and 4 deletions

View file

@ -64,7 +64,6 @@ vec3 colorToLinearRGB(vec3 srgb) {
void main(void) {
outFragColor.a = 1.0;
outFragColor.rgb = colorToLinearRGB(texture(colorMap, varTexCoord0).rgb);
// outFragColor.rgb = texture(colorMap, varTexCoord0).rgb;
}
)SCRIBE";

View file

@ -134,6 +134,7 @@ vec3 evalSkyboxGlobalColor(mat4 invViewMat, float shadowAttenuation, float obscu
color += directionalDiffuse;
color += directionalSpecular;
// FIXME - temporarily removed until we support it for forward...
// Attenuate the light if haze effect selected
// if ((hazeParams.hazeMode & HAZE_MODE_IS_KEYLIGHT_ATTENUATED) == HAZE_MODE_IS_KEYLIGHT_ATTENUATED) {
// color = computeHazeColorKeyLightAttenuation(color, lightDirection, position);
@ -227,6 +228,7 @@ vec3 evalGlobalLightingAlphaBlendedWithHaze(
color += directionalSpecular / opacity;
// Haze
// FIXME - temporarily removed until we support it for forward...
/* if ((hazeParams.hazeMode & HAZE_MODE_IS_ACTIVE) == HAZE_MODE_IS_ACTIVE) {
vec4 colorV4 = computeHazeColor(
vec4(color, 1.0), // fragment original color

View file

@ -104,9 +104,6 @@ ShapeKey MeshPartPayload::getShapeKey() const {
if (drawMaterialKey.isNormalMap()) {
builder.withTangents();
}
/* if (drawMaterialKey.isMetallicMap()) {
builder.withSpecular();
}*/
if (drawMaterialKey.isLightmapMap()) {
builder.withLightmap();
}