Mirrors/overte-lubosz
3
0
Fork 0
mirror of https://github.com/lubosz/overte.git synced 2025-08-07 20:06:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix for crash in QtWebEngineCore when rapidly switching domains

Browse source 
Call stop on the QWebEngineView before destroying OffscreenQMLSurface.
This commit is contained in:
Anthony J. Thibault 2016-10-27 18:55:24 -07:00
parent 03946748bc
commit 1fc310434e
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
interface/resources/qml/controls/WebView.qml
View file

@ -27,6 +27,7 @@ Item {
WebEngineView { WebEngineView {
id: root id: root
objectName: "webEngineView"
x: 0 x: 0
y: 0 y: 0
width: parent.width width: parent.width

10
libraries/entities-renderer/src/RenderableWebEntityItem.cpp
View file

@ -326,7 +326,17 @@ void RenderableWebEntityItem::handlePointerEvent(const PointerEvent& event) {
void RenderableWebEntityItem::destroyWebSurface() { void RenderableWebEntityItem::destroyWebSurface() {
if (_webSurface) { if (_webSurface) {
--_currentWebCount; --_currentWebCount;
QQuickItem* rootItem = _webSurface->getRootItem();
if (rootItem) {
QObject* obj = rootItem->findChild<QObject*>("webEngineView");
if (obj) {
QMetaObject::invokeMethod(obj, "stop");
}
}
_webSurface->pause(); _webSurface->pause();
_webSurface->disconnect(_connection); _webSurface->disconnect(_connection);
QObject::disconnect(_mousePressConnection); QObject::disconnect(_mousePressConnection);
_mousePressConnection = QMetaObject::Connection(); _mousePressConnection = QMetaObject::Connection();