From 133b7e66b763d6712c7f460a1a89b6b412a68fc6 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Wed, 23 Aug 2017 16:38:23 -0700 Subject: [PATCH] adjust a comment and remove some debug --- domain-server/src/DomainServer.cpp | 2 -- libraries/networking/src/HifiSockAddr.cpp | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/domain-server/src/DomainServer.cpp b/domain-server/src/DomainServer.cpp index 3171fc066d..5bd6020c92 100644 --- a/domain-server/src/DomainServer.cpp +++ b/domain-server/src/DomainServer.cpp @@ -486,8 +486,6 @@ bool DomainServer::isPacketVerified(const udt::Packet& packet) { bool bothPrivateAddresses = nodeData->getSendingSockAddr().hasPrivateAddress() && packet.getSenderSockAddr().hasPrivateAddress(); - qDebug() << exactAddressMatch << bothPrivateAddresses; - if (nodeData && (exactAddressMatch || bothPrivateAddresses)) { // to the best of our ability we've verified that this packet comes from the right place // let the NodeList do its checks now (but pass it the sourceNode so it doesn't need to look it up again) diff --git a/libraries/networking/src/HifiSockAddr.cpp b/libraries/networking/src/HifiSockAddr.cpp index a053610df0..e2a3e79c79 100644 --- a/libraries/networking/src/HifiSockAddr.cpp +++ b/libraries/networking/src/HifiSockAddr.cpp @@ -114,7 +114,7 @@ QString HifiSockAddr::toString() const { } bool HifiSockAddr::hasPrivateAddress() const { - // an address is private if it falls in any of the RFC1918 address spaces + // an address is private if it is loopback or falls in any of the RFC1918 address spaces const QPair TWENTY_FOUR_BIT_BLOCK = { QHostAddress("10.0.0.0"), 8 }; const QPair TWENTY_BIT_BLOCK = { QHostAddress("172.16.0.0") , 12 }; const QPair SIXTEEN_BIT_BLOCK = { QHostAddress("192.168.0.0"), 16 };