Changes according to Philip's feedback: spacing around operators, removed

unused variables, moved font family names to #defines.
This commit is contained in:
Andrzej Kapolka 2013-05-01 12:17:57 -07:00
parent 15e46bac82
commit 11a750f6a0
5 changed files with 15 additions and 8 deletions

View file

@ -677,7 +677,7 @@ void Avatar::setDisplayingHead( bool displayingHead ) {
static TextRenderer* textRenderer() {
static TextRenderer* renderer = new TextRenderer("Helvetica", 24);
static TextRenderer* renderer = new TextRenderer(SANS_FONT_FAMILY, 24);
return renderer;
}

View file

@ -24,6 +24,8 @@ namespace {
unsigned const LINE_BUFFER_SIZE = 256; // number of lines that are buffered
unsigned const MAX_MESSAGE_LENGTH = 512; // maximum number of characters for a message
const char* FONT_FAMILY = SANS_FONT_FAMILY;
bool const TEXT_MONOSPACED = true;
float const TEXT_RED = 0.7f;
@ -196,7 +198,7 @@ void Log::setCharacterSize(unsigned width, unsigned height) {
}
static TextRenderer* textRenderer() {
static TextRenderer* renderer = new TextRenderer("Helvetica");
static TextRenderer* renderer = new TextRenderer(FONT_FAMILY);
return renderer;
}

View file

@ -153,8 +153,8 @@ double diffclock(timeval *clock1,timeval *clock2)
}
static TextRenderer* textRenderer(int mono) {
static TextRenderer* monoRenderer = new TextRenderer("Courier");
static TextRenderer* proportionalRenderer = new TextRenderer("Helvetica");
static TextRenderer* monoRenderer = new TextRenderer(MONO_FONT_FAMILY);
static TextRenderer* proportionalRenderer = new TextRenderer(SANS_FONT_FAMILY);
return mono ? monoRenderer : proportionalRenderer;
}

View file

@ -19,6 +19,13 @@
#include <Orientation.h>
// the standard sans serif font family
#define SANS_FONT_FAMILY "Helvetica"
// the standard mono font family
#define MONO_FONT_FAMILY "Courier"
void eulerToOrthonormals(glm::vec3 * angles, glm::vec3 * fwd, glm::vec3 * left, glm::vec3 * up);
float azimuth_to(glm::vec3 head_pos, glm::vec3 source_pos);

View file

@ -139,13 +139,11 @@ int MenuColumn::getMaxRowWidth() {
}
static TextRenderer* textRenderer() {
static TextRenderer* renderer = new TextRenderer("Helvetica", 11);
static TextRenderer* renderer = new TextRenderer(SANS_FONT_FAMILY, 11);
return renderer;
}
void MenuColumn::render(int yOffset, int menuHeight, int lineHeight) {
float scale = 0.09;
int mono = 0;
int numberOfRows = rows.size();
if (numberOfRows > 0) {
@ -165,7 +163,7 @@ void MenuColumn::render(int yOffset, int menuHeight, int lineHeight) {
for (unsigned int i = 0; i < rows.size(); ++i) {
rowName = rows[i].getName();
glColor3f(0, 0, 0);
textRenderer()->draw(leftPosition + SPACE_BEFORE_ROW_NAME, y+5 + yOffset, rowName);
textRenderer()->draw(leftPosition + SPACE_BEFORE_ROW_NAME, y + 5 + yOffset, rowName);
y += lineHeight;
}
renderMouseOver(yOffset);