From 076349a4880035b0305d7f88d1a77127cc062686 Mon Sep 17 00:00:00 2001
From: ksuprynowicz <ksuprynowicz@post.pl>
Date: Sat, 14 Jan 2023 19:46:49 +0100
Subject: [PATCH] Re-enabled script module cache creation

---
 libraries/script-engine/src/ScriptManager.cpp          | 5 ++---
 libraries/script-engine/src/v8/ScriptEngineV8_cast.cpp | 2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/libraries/script-engine/src/ScriptManager.cpp b/libraries/script-engine/src/ScriptManager.cpp
index 3db51d0c86..b66da2b0db 100644
--- a/libraries/script-engine/src/ScriptManager.cpp
+++ b/libraries/script-engine/src/ScriptManager.cpp
@@ -683,15 +683,14 @@ void ScriptManager::init() {
 
     scriptEngine->registerGlobalObject("Script", this);
 
-    //V8TODO: V8 has no such global object?
-    /*{
+    {
         // set up Script.require.resolve and Script.require.cache
         auto Script = scriptEngine->globalObject().property("Script");
         auto require = Script.property("require");
         auto resolve = Script.property("_requireResolve");
         require.setProperty("resolve", resolve, READONLY_PROP_FLAGS);
         resetModuleCache();
-    }*/
+    }
 
     scriptEngine->registerEnum("Script.ExternalPaths", QMetaEnum::fromType<ExternalResource::Bucket>());
 
diff --git a/libraries/script-engine/src/v8/ScriptEngineV8_cast.cpp b/libraries/script-engine/src/v8/ScriptEngineV8_cast.cpp
index ca505278fc..e1bb822a0c 100644
--- a/libraries/script-engine/src/v8/ScriptEngineV8_cast.cpp
+++ b/libraries/script-engine/src/v8/ScriptEngineV8_cast.cpp
@@ -547,7 +547,7 @@ bool ScriptEngineV8::castValueToVariant(const V8ScriptValue& v8Val, QVariant& de
 bool ScriptEngineV8::convertJSObjectToVariant(v8::Local<v8::Object> object, QVariant &dest) {
     auto context = getContext();
     v8::Local<v8::Array> names;
-    if(object->GetPropertyNames(context).ToLocal(&names)) {
+    if(!object->GetPropertyNames(context).ToLocal(&names)) {
         qDebug() << "ScriptEngineV8::convertJSObjectToVariant could not get property names";
         return false;
     }