CR feedback; whitespace / remove unnecessary diffs

This commit is contained in:
humbletim 2018-02-23 09:11:23 -05:00
parent ebdb5b3c17
commit f8fe06213d
6 changed files with 8 additions and 8 deletions

View file

@ -24,9 +24,9 @@
#include <PerfStat.h> #include <PerfStat.h>
#include <ViewFrustum.h> #include <ViewFrustum.h>
#include <GLMHelpers.h> #include <GLMHelpers.h>
#include <model-networking/SimpleMeshProxy.h>
#include <TBBHelpers.h> #include <TBBHelpers.h>
#include <model-networking/SimpleMeshProxy.h>
#include <graphics-scripting/Forward.h> #include <graphics-scripting/Forward.h>
#include <graphics/BufferViewHelpers.h> #include <graphics/BufferViewHelpers.h>
#include <DualQuaternion.h> #include <DualQuaternion.h>

View file

@ -317,13 +317,12 @@ public:
int getResourceDownloadAttempts() { return _renderWatcher.getResourceDownloadAttempts(); } int getResourceDownloadAttempts() { return _renderWatcher.getResourceDownloadAttempts(); }
int getResourceDownloadAttemptsRemaining() { return _renderWatcher.getResourceDownloadAttemptsRemaining(); } int getResourceDownloadAttemptsRemaining() { return _renderWatcher.getResourceDownloadAttemptsRemaining(); }
Q_INVOKABLE MeshProxyList getMeshes() const;
virtual scriptable::ScriptableModelBase getScriptableModel() override; virtual scriptable::ScriptableModelBase getScriptableModel() override;
virtual bool replaceScriptableModelMeshPart(scriptable::ScriptableModelBasePointer model, int meshIndex, int partIndex) override; virtual bool replaceScriptableModelMeshPart(scriptable::ScriptableModelBasePointer model, int meshIndex, int partIndex) override;
void scaleToFit(); void scaleToFit();
Q_INVOKABLE MeshProxyList getMeshes() const;
void addMaterial(graphics::MaterialLayer material, const std::string& parentMaterialName); void addMaterial(graphics::MaterialLayer material, const std::string& parentMaterialName);
void removeMaterial(graphics::MaterialPointer material, const std::string& parentMaterialName); void removeMaterial(graphics::MaterialPointer material, const std::string& parentMaterialName);

View file

@ -1,3 +1,4 @@
// FIXME: temporary workaround for duplicating the FBXModel when dynamically replacing an underlying mesh part
#include <graphics/BufferViewHelpers.h> #include <graphics/BufferViewHelpers.h>
#include <graphics-scripting/GraphicsScriptingUtil.h> #include <graphics-scripting/GraphicsScriptingUtil.h>
class MyGeometryResource : public GeometryResource { class MyGeometryResource : public GeometryResource {

View file

@ -535,7 +535,6 @@ void ScriptEngines::onScriptEngineLoaded(const QString& rawScriptURL) {
} }
int ScriptEngines::runScriptInitializers(ScriptEnginePointer scriptEngine) { int ScriptEngines::runScriptInitializers(ScriptEnginePointer scriptEngine) {
// register our application services and set it off on its own thread
int ii=0; int ii=0;
for (auto initializer : _scriptInitializers) { for (auto initializer : _scriptInitializers) {
ii++; ii++;
@ -554,6 +553,7 @@ void ScriptEngines::launchScriptEngine(ScriptEnginePointer scriptEngine) {
loadScript(scriptName, userLoaded, false, false, true); loadScript(scriptName, userLoaded, false, false, true);
}); });
// register our application services and set it off on its own thread
runScriptInitializers(scriptEngine); runScriptInitializers(scriptEngine);
// FIXME disabling 'shift key' debugging for now. If you start up the application with // FIXME disabling 'shift key' debugging for now. If you start up the application with