Mirrors/overte-JulianGro
3
0
Fork 0
mirror of https://github.com/JulianGro/overte.git synced 2025-04-09 15:33:02 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Guard against invalid data channel address

Browse source
This commit is contained in:
David Rowe 2021-10-07 21:03:23 +13:00
parent de37734e18
commit f5452a4324
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libraries/networking/src/webrtc/WebRTCDataChannels.cpp
View file

@ -328,6 +328,10 @@ void WDCConnection::onDataChannelMessageReceived(const DataBuffer& buffer) {
qCDebug(networking_webrtc) << "Echo message back";
#endif
auto addressParts = _dataChannelID.split(":");
if (addressParts.length() != 2) {
qCWarning(networking_webrtc) << "Invalid dataChannelID:" << _dataChannelID;
return;
}
auto address = SockAddr(SocketType::WebRTC, QHostAddress(addressParts[0]), addressParts[1].toInt());
_parent->sendDataMessage(address, byteArray); // Use parent method to exercise the code stack.
return;
@ -498,6 +502,10 @@ void WebRTCDataChannels::emitDataMessage(const QString& dataChannelID, const QBy
<< byteArray.length();
#endif
auto addressParts = dataChannelID.split(":");
if (addressParts.length() != 2) {
qCWarning(networking_webrtc) << "Invalid dataChannelID:" << dataChannelID;
return;
}
auto address = SockAddr(SocketType::WebRTC, QHostAddress(addressParts[0]), addressParts[1].toInt());
emit dataMessage(address, byteArray);
}