From f3732aaa62f4dce292f3dfcfa9fac8a239ad8dea Mon Sep 17 00:00:00 2001 From: ksuprynowicz Date: Sat, 22 Jul 2023 12:47:15 +0200 Subject: [PATCH] Clarified comment on controller endpoint cleanup --- interface/src/Application.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 5f75195f64..10574f330d 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -7557,8 +7557,8 @@ void Application::registerScriptEngineWithApplicationServices(ScriptManagerPoint // Request removal of controller routes with callbacks to a given script engine auto userInputMapper = DependencyManager::get(); userInputMapper->scheduleScriptEndpointCleanup(scriptManager->engine().get()); + // V8TODO: Maybe we should wait until endpoint cleanup is finished before deleting the script engine if there are still crashes QObject::disconnect(*connection); - // V8TODO: Maybe we should wait until removal is finished if there are still crashes }); }