Enum coding standard

interface/src/Application.cpp

@@ -370,6 +370,8 @@ Application::Application(int& argc, char** argv, QElapsedTimer &startup_time) :
         _lastFaceTrackerUpdate(0),
         _applicationOverlay()
 {
+    thread()->setObjectName("Main Thread");
+    
     setInstance(this);
 
     _entityClipboard->createRootElement();

libraries/networking/src/AssetClient.cpp

@@ -11,16 +11,16 @@
 
 #include "AssetClient.h"
 
-#include <QBuffer>
-#include <QThread>
-
 #include <cstdint>
 
+#include <QtCore/QBuffer>
+#include <QtCore/QThread>
+
 #include "AssetRequest.h"
 #include "AssetUpload.h"
+#include "AssetUtils.h"
 #include "NodeList.h"
 #include "PacketReceiver.h"
-#include "AssetUtils.h"
 
 MessageID AssetClient::_currentID = 0;
 

libraries/networking/src/AssetRequest.cpp

@@ -13,7 +13,7 @@
 
 #include <algorithm>
 
-#include <QThread>
+#include <QtCore/QThread>
 
 #include "AssetClient.h"
 #include "NetworkLogging.h"
@@ -59,7 +59,6 @@ void AssetRequest::start() {
 
         if (_error != NoError) {
             qCDebug(networking) << "Got error retrieving asset info for" << _hash;
-
             _state = Finished;
             emit finished(this);
             

libraries/networking/src/AssetResourceRequest.cpp

@@ -32,7 +32,6 @@ void AssetResourceRequest::doSend() {
         _state = Finished;
 
         emit finished();
-
         return;
     }
 
@@ -43,12 +42,11 @@ void AssetResourceRequest::doSend() {
         _state = Finished;
 
         emit finished();
-
         return;
     }
 
     connect(_assetRequest, &AssetRequest::progress, this, &AssetResourceRequest::progress);
-    QObject::connect(_assetRequest, &AssetRequest::finished, [this](AssetRequest* req) mutable {
+    connect(_assetRequest, &AssetRequest::finished, [this](AssetRequest* req) {
         Q_ASSERT(_state == InProgress);
         Q_ASSERT(req == _assetRequest);
         Q_ASSERT(req->getState() == AssetRequest::Finished);

libraries/networking/src/HTTPResourceRequest.cpp

@@ -29,8 +29,7 @@ HTTPResourceRequest::~HTTPResourceRequest() {
 }
 
 void HTTPResourceRequest::doSend() {
-    QNetworkAccessManager& networkAccessManager = NetworkAccessManager::getInstance();
-    QNetworkRequest networkRequest = QNetworkRequest(_url);
+    QNetworkRequest networkRequest(_url);
     networkRequest.setHeader(QNetworkRequest::UserAgentHeader, HIGH_FIDELITY_USER_AGENT);
 
     if (_cacheEnabled) {
@@ -39,7 +38,7 @@ void HTTPResourceRequest::doSend() {
         networkRequest.setAttribute(QNetworkRequest::CacheLoadControlAttribute, QNetworkRequest::AlwaysNetwork);
     }
 
-    _reply = networkAccessManager.get(networkRequest);
+    _reply = NetworkAccessManager::getInstance().get(networkRequest);
     
     connect(_reply, &QNetworkReply::finished, this, &HTTPResourceRequest::onRequestFinished);
     connect(_reply, &QNetworkReply::downloadProgress, this, &HTTPResourceRequest::onDownloadProgress);

libraries/networking/src/NetworkAccessManager.cpp

@@ -18,6 +18,7 @@ QThreadStorage<QNetworkAccessManager*> networkAccessManagers;
 QNetworkAccessManager& NetworkAccessManager::getInstance() {
     if (!networkAccessManagers.hasLocalData()) {
         networkAccessManagers.setLocalData(new QNetworkAccessManager());
+        
     }
     
     return *networkAccessManagers.localData();

libraries/networking/src/NetworkAccessManager.h

@@ -12,7 +12,7 @@
 #ifndef hifi_NetworkAccessManager_h
 #define hifi_NetworkAccessManager_h
 
-#include <QtNetwork/qnetworkaccessmanager.h>
+#include <QtNetwork/QNetworkAccessManager>
 
 /// Wrapper around QNetworkAccessManager to restrict at one instance by thread
 class NetworkAccessManager : public QObject {