From e08d8e904651afe946a6400b3027aae9c6de09b9 Mon Sep 17 00:00:00 2001
From: Thijs Wenker <me@thoys.nl>
Date: Wed, 22 Aug 2018 21:03:29 +0200
Subject: [PATCH] only show InteractiveWindow on top of interface window

---
 libraries/ui/src/InteractiveWindow.cpp | 30 ++++++++++++++++++++++++++
 libraries/ui/src/InteractiveWindow.h   |  4 ++++
 libraries/ui/src/MainWindow.cpp        | 13 +++++++++++
 libraries/ui/src/MainWindow.h          |  2 ++
 libraries/ui/src/OffscreenUi.cpp       | 16 ++------------
 5 files changed, 51 insertions(+), 14 deletions(-)

diff --git a/libraries/ui/src/InteractiveWindow.cpp b/libraries/ui/src/InteractiveWindow.cpp
index 5078fcb602..b4d5a068eb 100644
--- a/libraries/ui/src/InteractiveWindow.cpp
+++ b/libraries/ui/src/InteractiveWindow.cpp
@@ -13,12 +13,19 @@
 
 #include <QtQml/QQmlContext>
 #include <QtCore/QThread>
+#include <QtGui/QGuiApplication>
+#include <QtQuick/QQuickWindow>
 
 #include <DependencyManager.h>
 #include <RegisteredMetaTypes.h>
 
 #include "OffscreenUi.h"
 #include "shared/QtHelpers.h"
+#include "MainWindow.h"
+
+#ifdef Q_OS_WIN
+#include <WinUser.h>
+#endif
 
 static auto CONTENT_WINDOW_QML = QUrl("InteractiveWindow.qml");
 
@@ -87,6 +94,11 @@ InteractiveWindow::InteractiveWindow(const QString& sourceUrl, const QVariantMap
         connect(object, SIGNAL(windowClosed()), this, SIGNAL(closed()), Qt::QueuedConnection);
         connect(object, SIGNAL(selfDestruct()), this, SLOT(close()), Qt::QueuedConnection);
 
+#ifdef Q_OS_WIN
+        connect(object, SIGNAL(nativeWindowChanged()), this, SLOT(parentNativeWindowToMainWindow()), Qt::QueuedConnection);
+        connect(object, SIGNAL(interactiveWindowVisibleChanged()), this, SLOT(parentNativeWindowToMainWindow()), Qt::QueuedConnection);
+#endif
+
         QUrl sourceURL{ sourceUrl };
         // If the passed URL doesn't correspond to a known scheme, assume it's a local file path
         if (!KNOWN_SCHEMES.contains(sourceURL.scheme(), Qt::CaseInsensitive)) {
@@ -279,6 +291,24 @@ int InteractiveWindow::getPresentationMode() const {
     return _qmlWindow->property(PRESENTATION_MODE_PROPERTY).toInt();
 }
 
+#ifdef Q_OS_WIN
+void InteractiveWindow::parentNativeWindowToMainWindow() {
+    if (QThread::currentThread() != thread()) {
+        QMetaObject::invokeMethod(this, "parentNativeWindowToMainWindow");
+        return;
+    }
+    if (_qmlWindow.isNull()) {
+        return;
+    }
+    const auto nativeWindowProperty = _qmlWindow->property("nativeWindow");
+    if (nativeWindowProperty.isNull() || !nativeWindowProperty.isValid()) {
+        return;
+    }
+    const auto nativeWindow = qvariant_cast<QQuickWindow*>(nativeWindowProperty);
+    SetWindowLongPtr((HWND)nativeWindow->winId(), GWLP_HWNDPARENT, (LONG)MainWindow::findMainWindow()->winId());
+}
+#endif
+
 void InteractiveWindow::setPresentationMode(int presentationMode) {
     if (QThread::currentThread() != thread()) {
         QMetaObject::invokeMethod(this, "setPresentationMode", Q_ARG(int, presentationMode));
diff --git a/libraries/ui/src/InteractiveWindow.h b/libraries/ui/src/InteractiveWindow.h
index bf832550b5..f456b32e8d 100644
--- a/libraries/ui/src/InteractiveWindow.h
+++ b/libraries/ui/src/InteractiveWindow.h
@@ -84,6 +84,10 @@ private:
     Q_INVOKABLE void setPresentationMode(int presentationMode);
     Q_INVOKABLE int getPresentationMode() const;
 
+#ifdef Q_OS_WIN
+    Q_INVOKABLE void parentNativeWindowToMainWindow();
+#endif
+
 public slots:
 
     /**jsdoc
diff --git a/libraries/ui/src/MainWindow.cpp b/libraries/ui/src/MainWindow.cpp
index f9fc71e417..1a13194974 100644
--- a/libraries/ui/src/MainWindow.cpp
+++ b/libraries/ui/src/MainWindow.cpp
@@ -22,6 +22,7 @@
 #include <QDragEnterEvent>
 #include <QDropEvent>
 #include <QMimeData>
+#include <QWindow>
 #include <QDebug>
 
 #include "ui/Logging.h"
@@ -39,6 +40,18 @@ MainWindow::~MainWindow() {
     qCDebug(uiLogging) << "Destroying main window";
 }
 
+QWindow* MainWindow::findMainWindow() {
+    auto windows = qApp->topLevelWindows();
+    QWindow* result = nullptr;
+    for (auto window : windows) {
+        if (window->objectName().contains("MainWindow")) {
+            result = window;
+            break;
+        }
+    }
+    return result;
+}
+
 void MainWindow::restoreGeometry() {
     // Did not use setGeometry() on purpose,
     // see http://doc.qt.io/qt-5/qsettings.html#restoring-the-state-of-a-gui-application
diff --git a/libraries/ui/src/MainWindow.h b/libraries/ui/src/MainWindow.h
index 75421340a2..fbd48e5eb1 100644
--- a/libraries/ui/src/MainWindow.h
+++ b/libraries/ui/src/MainWindow.h
@@ -21,6 +21,8 @@ class MainWindow : public QMainWindow {
 public:
     explicit MainWindow(QWidget* parent = NULL);
     ~MainWindow();
+
+    static QWindow* findMainWindow();
     
 public slots:
     void restoreGeometry();
diff --git a/libraries/ui/src/OffscreenUi.cpp b/libraries/ui/src/OffscreenUi.cpp
index a5ef1457db..d82cfbbf3f 100644
--- a/libraries/ui/src/OffscreenUi.cpp
+++ b/libraries/ui/src/OffscreenUi.cpp
@@ -29,6 +29,7 @@
 #include "ui/Logging.h"
 
 #include <PointerManager.h>
+#include "MainWindow.h"
 
 /**jsdoc
  * @namespace OffscreenFlags
@@ -649,20 +650,7 @@ public:
     }
 
 private:
-    
-    static QWindow* findMainWindow() {
-        auto windows = qApp->topLevelWindows();
-        QWindow* result = nullptr;
-        for (auto window : windows) {
-            if (window->objectName().contains("MainWindow")) {
-                result = window;
-                break;
-            }
-        }
-        return result;
-    }
-
-    QWindow* const _mainWindow { findMainWindow() };
+    QWindow* const _mainWindow { MainWindow::findMainWindow() };
     QWindow* _hackWindow { nullptr };
 };