CR Changes - remove double constructor, use creation function instead

This commit is contained in:
Thijs Wenker 2017-03-22 17:28:10 +01:00
parent b60534a855
commit dff67886d0
2 changed files with 7 additions and 9 deletions

View file

@ -8,7 +8,7 @@
// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
//
/* globals BoppoClownEntity:true LookAtTarget */
/* globals LookAtTarget */
(function() {
var SFX_PREFIX = 'https://hifi-content.s3-us-west-1.amazonaws.com/caitlyn/production/elBoppo/sfx/';
@ -21,7 +21,7 @@
Script.include('lookAtEntity.js');
BoppoClownEntity = function() {
var createBoppoClownEntity = function() {
var _this,
_entityID,
_boppoUserData,
@ -38,7 +38,7 @@
return {};
};
BoppoClownEntity = function () {
var BoppoClownEntity = function () {
_this = this;
PUNCH_SOUNDS.forEach(function(punch) {
_punchSounds.push(SoundCache.getSound(SFX_PREFIX + punch));
@ -76,5 +76,5 @@
return new BoppoClownEntity();
};
return new BoppoClownEntity();
return createBoppoClownEntity();
});

View file

@ -8,8 +8,6 @@
// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
//
/* globals BoppoServer:true */
(function() {
var SFX_PREFIX = 'https://hifi-content.s3-us-west-1.amazonaws.com/caitlyn/production/elBoppo/sfx/';
var CLOWN_LAUGHS = [
@ -41,7 +39,7 @@
var TICK_TOCK_FROM = 3; // seconds
var COOLDOWN_TIME_MS = MILLISECONDS_PER_SECOND * 3;
BoppoServer = function() {
var createBoppoServer = function() {
var _this,
_isInitialized = false,
_clownLaughs = [],
@ -164,7 +162,7 @@
}
};
BoppoServer = function () {
var BoppoServer = function () {
_this = this;
_hits = 0;
_boppoClownID = null;
@ -301,5 +299,5 @@
return new BoppoServer();
};
return new BoppoServer();
return createBoppoServer();
});