From c743abc3489f3efbb2bfa15eec5abb755d9e77c9 Mon Sep 17 00:00:00 2001
From: Dale Glass <dale@daleglass.net>
Date: Sat, 22 Oct 2022 23:56:09 +0200
Subject: [PATCH] Added threaded settings test.

Test setValue() while a thread is constantly trying to save the file
to disk to test the absolute worst case performance.
---
 tests/shared/src/SettingsTests.cpp | 56 ++++++++++++++++++++++++++++++
 tests/shared/src/SettingsTests.h   | 17 +++++++++
 2 files changed, 73 insertions(+)

diff --git a/tests/shared/src/SettingsTests.cpp b/tests/shared/src/SettingsTests.cpp
index 18039a231a..060a8cbceb 100644
--- a/tests/shared/src/SettingsTests.cpp
+++ b/tests/shared/src/SettingsTests.cpp
@@ -20,6 +20,24 @@
 
 QTEST_MAIN(SettingsTests)
 
+void SettingsTestThread::saveSettings() {
+    auto sm = DependencyManager::get<Setting::Manager>();
+    QThread *thread = QThread::currentThread();
+
+    while(! thread->isInterruptionRequested() ) {
+        //qDebug() << "Thread is saving config";
+        sm->forceSave();
+
+        // Not having any wait here for some reason locks up the benchmark.
+        // Logging a message also does the trick.
+        //
+        // This looks like a bug somewhere and needs investigating.
+        thread->yieldCurrentThread();
+    }
+
+    thread->exit(0);
+}
+
 void SettingsTests::initTestCase() {
     QCoreApplication::setOrganizationName("OverteTest");
 
@@ -49,6 +67,18 @@ void SettingsTests::saveSettings() {
     qDebug() << "Wrote" << s.fileName();
 }
 
+void SettingsTests::benchmarkSetValue() {
+    auto sm = DependencyManager::get<Setting::Manager>();
+    int i = 0;
+
+    QBENCHMARK {
+        sm->setValue("BenchmarkSetValue", ++i);
+    }
+
+    sm->forceSave();
+}
+
+
 void SettingsTests::benchmarkSaveSettings() {
     auto sm = DependencyManager::get<Setting::Manager>();
     int i = 0;
@@ -59,3 +89,29 @@ void SettingsTests::benchmarkSaveSettings() {
     }
 
 }
+
+
+void SettingsTests::benchmarkSetValueConcurrent() {
+    auto sm = DependencyManager::get<Setting::Manager>();
+    int i = 0;
+
+    _settingsThread = new QThread(qApp);
+    _settingsThreadObj = new SettingsTestThread;
+
+    _settingsThread->setObjectName("Save thread");
+    _settingsThreadObj->moveToThread(_settingsThread);
+
+    QObject::connect(_settingsThread, &QThread::started, _settingsThreadObj, &SettingsTestThread::saveSettings, Qt::QueuedConnection );
+
+    _settingsThread->start();
+    QBENCHMARK {
+        sm->setValue("BenchmarkSetValue", ++i);
+    }
+
+    _settingsThread->requestInterruption();
+    _settingsThread->wait();
+
+    delete _settingsThreadObj;
+    delete _settingsThread;
+}
+
diff --git a/tests/shared/src/SettingsTests.h b/tests/shared/src/SettingsTests.h
index 927863adb6..7de6f0df1d 100644
--- a/tests/shared/src/SettingsTests.h
+++ b/tests/shared/src/SettingsTests.h
@@ -11,15 +11,32 @@
 
 #include <QtCore/QObject>
 
+
+class SettingsTestThread : public QObject {
+    Q_OBJECT
+
+public slots:
+    void saveSettings();
+};
+
+
 class SettingsTests : public QObject {
     Q_OBJECT
 private slots:
     void initTestCase();
     void loadSettings();
     void saveSettings();
+
+    void benchmarkSetValue();
     void benchmarkSaveSettings();
+    void benchmarkSetValueConcurrent();
 
     void cleanupTestCase();
+
+private:
+    QThread *_settingsThread = nullptr;
+    SettingsTestThread *_settingsThreadObj = nullptr;
+
 };
 
 #endif // overte_SettingsTests_h