diff --git a/interface/src/raypick/LaserPointer.cpp b/interface/src/raypick/LaserPointer.cpp index 8d18479091..ce44d3011c 100644 --- a/interface/src/raypick/LaserPointer.cpp +++ b/interface/src/raypick/LaserPointer.cpp @@ -197,8 +197,9 @@ std::shared_ptr LaserPointer::buildRenderState(const QVaria if (propMap["startPropertyIndex"].isValid()) { int startPropertyIndex = propMap["startPropertyIndex"].toInt(); if (startPropertyIndex >= 0 && startPropertyIndex < entityProperties.length()) { - //startMap.remove("visible"); - startID = DependencyManager::get()->addEntityInternal(entityProperties[startPropertyIndex], entity::HostType::LOCAL); + EntityItemProperties startProperties(entityProperties[startPropertyIndex]); + startProperties.getGrab().setGrabbable(false); + startID = DependencyManager::get()->addEntityInternal(startProperties, entity::HostType::LOCAL); } } @@ -207,9 +208,10 @@ std::shared_ptr LaserPointer::buildRenderState(const QVaria // laser paths must be PolyLine int pathPropertyIndex = propMap["pathPropertyIndex"].toInt(); if (pathPropertyIndex >= 0 && pathPropertyIndex < entityProperties.length()) { - //startMap.remove("visible"); //pathMap["type"].toString() == "PolyLine" - pathID = DependencyManager::get()->addEntityInternal(entityProperties[pathPropertyIndex], entity::HostType::LOCAL); + EntityItemProperties pathProperties(entityProperties[pathPropertyIndex]); + pathProperties.getGrab().setGrabbable(false); + pathID = DependencyManager::get()->addEntityInternal(pathProperties, entity::HostType::LOCAL); } } @@ -217,8 +219,9 @@ std::shared_ptr LaserPointer::buildRenderState(const QVaria if (propMap["endPropertyIndex"].isValid()) { int endPropertyIndex = propMap["endPropertyIndex"].toInt(); if (endPropertyIndex >= 0 && endPropertyIndex < entityProperties.length()) { - //startMap.remove("visible"); - endID = DependencyManager::get()->addEntityInternal(entityProperties[endPropertyIndex], entity::HostType::LOCAL); + EntityItemProperties endProperties(entityProperties[endPropertyIndex]); + endProperties.getGrab().setGrabbable(false); + endID = DependencyManager::get()->addEntityInternal(endProperties, entity::HostType::LOCAL); } } diff --git a/interface/src/raypick/ParabolaPointer.cpp b/interface/src/raypick/ParabolaPointer.cpp index 63a17b217c..5f045c5504 100644 --- a/interface/src/raypick/ParabolaPointer.cpp +++ b/interface/src/raypick/ParabolaPointer.cpp @@ -238,8 +238,9 @@ std::shared_ptr ParabolaPointer::buildRenderState(const QVa if (propMap["startPropertyIndex"].isValid()) { int startPropertyIndex = propMap["startPropertyIndex"].toInt(); if (startPropertyIndex >= 0 && startPropertyIndex < entityProperties.length()) { - //startMap.remove("visible"); - startID = DependencyManager::get()->addEntityInternal(entityProperties[startPropertyIndex], entity::HostType::LOCAL); + EntityItemProperties startProperties(entityProperties[startPropertyIndex]); + startProperties.getGrab().setGrabbable(false); + startID = DependencyManager::get()->addEntityInternal(startProperties, entity::HostType::LOCAL); } } @@ -278,8 +279,9 @@ std::shared_ptr ParabolaPointer::buildRenderState(const QVa if (propMap["endPropertyIndex"].isValid()) { int endPropertyIndex = propMap["endPropertyIndex"].toInt(); if (endPropertyIndex >= 0 && endPropertyIndex < entityProperties.length()) { - //endMap.remove("visible"); - endID = DependencyManager::get()->addEntityInternal(entityProperties[endPropertyIndex], entity::HostType::LOCAL); + EntityItemProperties endProperties(entityProperties[endPropertyIndex]); + endProperties.getGrab().setGrabbable(false); + endID = DependencyManager::get()->addEntityInternal(endProperties, entity::HostType::LOCAL); } } diff --git a/scripts/system/controllers/controllerScripts.js b/scripts/system/controllers/controllerScripts.js index 928d1fef86..de185e3fe0 100644 --- a/scripts/system/controllers/controllerScripts.js +++ b/scripts/system/controllers/controllerScripts.js @@ -17,9 +17,8 @@ var CONTOLLER_SCRIPTS = [ "squeezeHands.js", "controllerDisplayManager.js", "grab.js", - //"toggleAdvancedMovementForHandControllers.js", + "toggleAdvancedMovementForHandControllers.js", "handTouch.js", - //"controllerDispatcher.js", "controllerModules/nearParentGrabOverlay.js", "controllerModules/stylusInput.js", "controllerModules/equipEntity.js", diff --git a/scripts/system/create/entitySelectionTool/entitySelectionTool.js b/scripts/system/create/entitySelectionTool/entitySelectionTool.js index 8b23ef051a..7a188f3dc0 100644 --- a/scripts/system/create/entitySelectionTool/entitySelectionTool.js +++ b/scripts/system/create/entitySelectionTool/entitySelectionTool.js @@ -2539,7 +2539,6 @@ SelectionDisplay = (function() { var pickPlanePosition = null; var pickPlaneNormal = { x: 0, y: 1, z: 0 }; var greatestDimension = 0.0; - var startingDistance = 0.0; var startingElevation = 0.0; addHandleTool(toolEntity, { mode: mode, @@ -2581,11 +2580,9 @@ SelectionDisplay = (function() { greatestDimension = Math.max(Math.max(SelectionManager.worldDimensions.x, SelectionManager.worldDimensions.y), SelectionManager.worldDimensions.z); - startingDistance = Vec3.distance(pickRay.origin, SelectionManager.position); startingElevation = this.elevation(pickRay.origin, pickPlanePosition); if (wantDebug) { print(" longest dimension: " + greatestDimension); - print(" starting distance: " + startingDistance); print(" starting elevation: " + startingElevation); }