code review

This commit is contained in:
Seth Alves 2016-08-04 13:47:43 -07:00
parent 45c21ca523
commit 981a8d76fa
2 changed files with 2 additions and 2 deletions

View file

@ -91,7 +91,7 @@ void Settings::setValue(const QString& name, const QVariant& value) {
QVariant Settings::value(const QString& name, const QVariant& defaultValue) const {
QVariant result = _manager->value(name, defaultValue);
if (result == _manager->unsetValue()) {
return QVariant(QString());
return defaultValue;
}
return result;
}

View file

@ -28,7 +28,7 @@ namespace Setting {
public:
void customDeleter() override;
QVariant unsetValue() { return UNSET_VALUE; }
const QVariant& unsetValue() { return UNSET_VALUE; }
protected:
~Manager();