From 932f5dbfb313ffb65bdb3bd67bcbc9d34c7f55cc Mon Sep 17 00:00:00 2001 From: HifiExperiments Date: Sun, 6 Sep 2020 22:41:17 -0700 Subject: [PATCH] CR --- interface/src/Application.cpp | 14 +------------- .../src/display-plugins/CompositorHelper.cpp | 1 + .../src/display-plugins/CompositorHelper.h | 1 + .../src/input-plugins/KeyboardMouseDevice.cpp | 1 + .../src/input-plugins/KeyboardMouseDevice.h | 1 + libraries/shared/src/shared/Camera.h | 5 +++-- 6 files changed, 8 insertions(+), 15 deletions(-) diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 270013a80d..a83b2c4431 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -5922,19 +5922,7 @@ void Application::cameraModeChanged() { } bool Application::shouldCaptureMouse() const { - if (!_captureMouse) { - return false; - } - - if (!_glWidget->isActiveWindow()) { - return false; - } - - if (ui::Menu::isSomeSubmenuShown()) { - return false; - } - - return true; + return _captureMouse && _glWidget->isActiveWindow() && !ui::Menu::isSomeSubmenuShown(); } void Application::captureMouseChanged(bool captureMouse) { diff --git a/libraries/display-plugins/src/display-plugins/CompositorHelper.cpp b/libraries/display-plugins/src/display-plugins/CompositorHelper.cpp index 0cc3e5216e..9b6946bbcc 100644 --- a/libraries/display-plugins/src/display-plugins/CompositorHelper.cpp +++ b/libraries/display-plugins/src/display-plugins/CompositorHelper.cpp @@ -1,6 +1,7 @@ // // Created by Benjamin Arnold on 5/27/14. // Copyright 2014 High Fidelity, Inc. +// Copyright 2020 Vircadia contributors. // // Distributed under the Apache License, Version 2.0. // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html diff --git a/libraries/display-plugins/src/display-plugins/CompositorHelper.h b/libraries/display-plugins/src/display-plugins/CompositorHelper.h index 1279050a57..c45119fd63 100644 --- a/libraries/display-plugins/src/display-plugins/CompositorHelper.h +++ b/libraries/display-plugins/src/display-plugins/CompositorHelper.h @@ -1,6 +1,7 @@ // // Created by Bradley Austin Davis Arnold on 2015/06/13 // Copyright 2015 High Fidelity, Inc. +// Copyright 2020 Vircadia contributors. // // Distributed under the Apache License, Version 2.0. // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html diff --git a/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.cpp b/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.cpp index a49c822014..c7c5543d44 100755 --- a/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.cpp +++ b/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.cpp @@ -4,6 +4,7 @@ // // Created by Sam Gateau on 4/27/15. // Copyright 2015 High Fidelity, Inc. +// Copyright 2020 Vircadia contributors. // // Distributed under the Apache License, Version 2.0. // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html diff --git a/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.h b/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.h index 158e2f594f..216194a712 100644 --- a/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.h +++ b/libraries/input-plugins/src/input-plugins/KeyboardMouseDevice.h @@ -4,6 +4,7 @@ // // Created by Sam Gateau on 4/27/15. // Copyright 2015 High Fidelity, Inc. +// Copyright 2020 Vircadia contributors. // // Distributed under the Apache License, Version 2.0. // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html diff --git a/libraries/shared/src/shared/Camera.h b/libraries/shared/src/shared/Camera.h index d8ed98c0a2..76d344c21c 100644 --- a/libraries/shared/src/shared/Camera.h +++ b/libraries/shared/src/shared/Camera.h @@ -3,6 +3,7 @@ // interface/src // // Copyright 2013 High Fidelity, Inc. +// Copyright 2020 Vircadia contributors. // // Distributed under the Apache License, Version 2.0. // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html @@ -119,9 +120,9 @@ public slots: bool getCaptureMouse() const { return _captureMouse; } /**jsdoc - * Sets mouse capture state. + * Sets the mouse capture state. * @function Camera.setCaptureMouse - * @param {boolean} captureMouse - Whether or not to capture the mouse. + * @param {boolean} captureMouse - true to capture the mouse, false to release the mouse. */ void setCaptureMouse(bool captureMouse) { _captureMouse = captureMouse; emit captureMouseUpdated(captureMouse); }