Misc. tidying

This commit is contained in:
David Rowe 2020-08-04 09:15:05 +12:00
parent 257eadc99f
commit 7da91d9557
3 changed files with 2 additions and 9 deletions

View file

@ -1218,7 +1218,7 @@ Node::LocalID DomainGatekeeper::findOrCreateLocalID(const QUuid& uuid) {
bool DomainGatekeeper::domainHasLogin() {
// The domain may have its own users and groups in a WordPress site.
// ####### TODO: Add checks of any further domain server settings used.
// ####### TODO: Add checks of any further domain server settings used. [plugin, groups]
return _server->_settingsManager.valueForKeyPath(AUTHENTICATION_ENAABLED).toBool()
&& !_server->_settingsManager.valueForKeyPath(AUTHENTICATION_OAUTH2_URL_PATH).toString().isEmpty()
&& !_server->_settingsManager.valueForKeyPath(AUTHENTICATION_WORDPRESS_URL_BASE).toString().isEmpty();
@ -1226,12 +1226,6 @@ bool DomainGatekeeper::domainHasLogin() {
void DomainGatekeeper::requestDomainUser(const QString& username, const QString& accessToken, const QString& refreshToken) {
// ####### TODO: Move this further up the chain such that generates "invalid username or password" condition?
// Don't request identity for the standard psuedo-account-names.
if (NodePermissions::standardNames.contains(username, Qt::CaseInsensitive)) {
return;
}
if (_inFlightDomainUserIdentityRequests.contains(username)) {
// Domain identify request for this username is already in progress.
return;

View file

@ -2186,7 +2186,7 @@ QList<QUuid> DomainServerSettingsManager::getBlacklistGroupIDs() {
}
QStringList DomainServerSettingsManager::getDomainGroupNames() {
// Names as configured in domain server; not necessarily mnetaverse groups.
// Names as configured in domain server; not necessarily metaverse groups.
QSet<QString> result;
foreach(NodePermissionsKey groupKey, _groupPermissions.keys()) {
result += _groupPermissions[groupKey]->getID();

View file

@ -9444,7 +9444,6 @@ void Application::forceDisplayName(const QString& displayName) {
getMyAvatar()->setDisplayName(displayName);
}
void Application::forceLoginWithTokens(const QString& tokens) {
// ####### TODO
DependencyManager::get<AccountManager>()->setAccessTokens(tokens);
Setting::Handle<bool>(KEEP_ME_LOGGED_IN_SETTING_NAME, true).set(true);
}