From 6b53c1e85d13e5cd6e80412ec859bc6600d38781 Mon Sep 17 00:00:00 2001 From: Zach Pomerantz Date: Wed, 27 Apr 2016 11:55:02 -0700 Subject: [PATCH] Avoid leaking ScriptableResource --- libraries/networking/src/ResourceCache.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libraries/networking/src/ResourceCache.cpp b/libraries/networking/src/ResourceCache.cpp index 2bd85ce5d2..48bc1dfc0c 100644 --- a/libraries/networking/src/ResourceCache.cpp +++ b/libraries/networking/src/ResourceCache.cpp @@ -157,7 +157,7 @@ void ScriptableResource::disconnectHelper() { } ScriptableResource* ResourceCache::prefetch(const QUrl& url, void* extra) { - auto result = new ScriptableResource(url); + ScriptableResource* result = nullptr; if (QThread::currentThread() != thread()) { // Must be called in thread to ensure getResource returns a valid pointer @@ -167,6 +167,7 @@ ScriptableResource* ResourceCache::prefetch(const QUrl& url, void* extra) { return result; } + result = new ScriptableResource(url); auto resource = getResource(url, QUrl(), false, extra); result->_resource = resource;