Mirrors/overte-JulianGro
3
0
Fork 0
mirror of https://github.com/JulianGro/overte.git synced 2025-05-08 05:29:46 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add comment explaining why visualPickResult is a copy

Browse source
This commit is contained in:
sabrina-shanman 2018-09-24 17:36:24 -07:00
parent 7f189e4d10
commit 5dbebd4aae
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
libraries/pointers/src/Pointer.cpp
View file

@ -68,6 +68,7 @@ void Pointer::update(unsigned int pointerID) {
// This only needs to be a read lock because update won't change any of the properties that can be modified from scripts // This only needs to be a read lock because update won't change any of the properties that can be modified from scripts
withReadLock([&] { withReadLock([&] {
auto pickResult = getPrevPickResult(); auto pickResult = getPrevPickResult();
// Pointer needs its own PickResult object so it doesn't modify the cached pick result
auto visualPickResult = getVisualPickResult(std::make_shared<PickResult>(*pickResult.get())); auto visualPickResult = getVisualPickResult(std::make_shared<PickResult>(*pickResult.get()));
updateVisuals(visualPickResult); updateVisuals(visualPickResult);
generatePointerEvents(pointerID, visualPickResult); generatePointerEvents(pointerID, visualPickResult);