From a089c43fdcce07a9ab808d7a87aaeef3ff63e239 Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Thu, 11 Feb 2016 14:07:05 -0800 Subject: [PATCH 1/2] don't send ice heartbeat with no ice-server socket --- domain-server/src/DomainServer.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/domain-server/src/DomainServer.cpp b/domain-server/src/DomainServer.cpp index d1cb9d4e4a..9e3b69854f 100644 --- a/domain-server/src/DomainServer.cpp +++ b/domain-server/src/DomainServer.cpp @@ -1073,7 +1073,9 @@ void DomainServer::sendHeartbeatToDataServer(const QString& networkAddress) { // TODO: have data-web respond with ice-server hostname to use void DomainServer::sendHeartbeatToIceServer() { - DependencyManager::get()->sendHeartbeatToIceServer(_iceServerSocket); + if (!_iceServerSocket.getAddress().isNull()) { + DependencyManager::get()->sendHeartbeatToIceServer(_iceServerSocket); + } } void DomainServer::processNodeJSONStatsPacket(QSharedPointer packetList, SharedNodePointer sendingNode) { From a6ba8dd8e54f4d9262254ef43ba5d5808bbfe08e Mon Sep 17 00:00:00 2001 From: Stephen Birarda Date: Thu, 11 Feb 2016 14:14:16 -0800 Subject: [PATCH 2/2] fix null STUN server socket check in LNL --- libraries/networking/src/LimitedNodeList.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/networking/src/LimitedNodeList.cpp b/libraries/networking/src/LimitedNodeList.cpp index 67237ee269..a3707d19ba 100644 --- a/libraries/networking/src/LimitedNodeList.cpp +++ b/libraries/networking/src/LimitedNodeList.cpp @@ -671,7 +671,7 @@ const int NUM_BYTES_STUN_HEADER = 20; void LimitedNodeList::sendSTUNRequest() { - if (!_stunSockAddr.isNull()) { + if (!_stunSockAddr.getAddress().isNull()) { const int NUM_INITIAL_STUN_REQUESTS_BEFORE_FAIL = 10; if (!_hasCompletedInitialSTUN) { @@ -840,7 +840,7 @@ void LimitedNodeList::startSTUNPublicSocketUpdate() { } void LimitedNodeList::possiblyTimeoutSTUNAddressLookup() { - if (_stunSockAddr.isNull()) { + if (_stunSockAddr.getAddress().isNull()) { // our stun address is still NULL, but we've been waiting for long enough - time to force a fail stopInitialSTUNUpdate(false); }