diff --git a/interface/src/Application.cpp b/interface/src/Application.cpp index 946bad2cc3..1bde51d6cc 100644 --- a/interface/src/Application.cpp +++ b/interface/src/Application.cpp @@ -583,7 +583,7 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo Model::setAbstractViewStateInterface(this); // The model class will sometimes need to know view state details from us // TODO: This is temporary, while developing - fingerprint::getMachineFingerprint(); + FingerprintUtils::getMachineFingerprint(); // End TODO auto nodeList = DependencyManager::get(); diff --git a/libraries/networking/src/FingerprintUtils.cpp b/libraries/networking/src/FingerprintUtils.cpp index 1dc17e0c5b..42a617e93d 100644 --- a/libraries/networking/src/FingerprintUtils.cpp +++ b/libraries/networking/src/FingerprintUtils.cpp @@ -24,11 +24,8 @@ #endif //Q_OS_MAC static const QString FALLBACK_FINGERPRINT_KEY = "fallbackFingerprint"; - -QUuid fingerprint::getMachineFingerprint() { - +QString FingerprintUtils::getMachineFingerprintString() { QString uuidString; - #ifdef Q_OS_LINUX // sadly need to be root to get smbios guid from linux, so // for now lets do nothing. @@ -56,6 +53,7 @@ QUuid fingerprint::getMachineFingerprint() { if (FAILED(hres)) { qDebug() << "Failed to initialize WbemLocator"; + return uuidString; } // Connect to WMI through the IWbemLocator::ConnectServer method @@ -78,6 +76,7 @@ QUuid fingerprint::getMachineFingerprint() { if (FAILED(hres)) { pLoc->Release(); qDebug() << "Failed to connect to WMI"; + return uuidString; } // Set security levels on the proxy @@ -96,6 +95,7 @@ QUuid fingerprint::getMachineFingerprint() { pSvc->Release(); pLoc->Release(); qDebug() << "Failed to set security on proxy blanket"; + return uuidString; } // Use the IWbemServices pointer to grab the Win32_BIOS stuff @@ -111,6 +111,7 @@ QUuid fingerprint::getMachineFingerprint() { pSvc->Release(); pLoc->Release(); qDebug() << "query to get Win32_ComputerSystemProduct info"; + return uuidString; } // Get the SerialNumber from the Win32_BIOS data @@ -150,8 +151,17 @@ QUuid fingerprint::getMachineFingerprint() { qDebug() << "Windows BIOS UUID: " << uuidString; #endif //Q_OS_WIN + return uuidString; + +} + +QUuid FingerprintUtils::getMachineFingerprint() { + + QString uuidString = getMachineFingerprintString(); + // now, turn into uuid. A malformed string will - // return QUuid() ("{00000...}") + // return QUuid() ("{00000...}"), which handles + // any errors in getting the string QUuid uuid(uuidString); if (uuid == QUuid()) { // read fallback key (if any) diff --git a/libraries/networking/src/FingerprintUtils.h b/libraries/networking/src/FingerprintUtils.h index 1d59bd20a5..572b150ec4 100644 --- a/libraries/networking/src/FingerprintUtils.h +++ b/libraries/networking/src/FingerprintUtils.h @@ -15,8 +15,12 @@ #include #include -namespace fingerprint { - QUuid getMachineFingerprint(); +class FingerprintUtils { +public: + static QUuid getMachineFingerprint(); + +private: + static QString getMachineFingerprintString(); }; #endif // hifi_FingerprintUtils_h