From 49d2e997bf4cdeb3633fd60ec3d4658fb6f6b675 Mon Sep 17 00:00:00 2001
From: milad <milad@miladnazeri.com>
Date: Thu, 14 Nov 2019 15:47:02 -0800
Subject: [PATCH] updated readme and made sure there is an exact application
 title match

---
 screenshare/README.md             | 30 ++++++++++++------------------
 screenshare/src/screenshareApp.js |  3 ++-
 2 files changed, 14 insertions(+), 19 deletions(-)

diff --git a/screenshare/README.md b/screenshare/README.md
index 53e8a00ea2..e57f37adc1 100644
--- a/screenshare/README.md
+++ b/screenshare/README.md
@@ -1,22 +1,16 @@
-# Hifi-Screenshare
+# Screen Sharing within High Fidelity
+This Screen Share app, built using Electron, allows for easy desktop screen sharing when used in conjuction with various scripts in the `hifi-content` repository.
 
-The Screenshare app will allow easy desktop sharing by being launced from within the highfidelity interface.
+# Screen Sharing Source Files
+## `packager.js`
+Calling npm run packager will use this file to create the actual Electron `hifi-screenshare` executable.
+It will kick out a folder `hifi-screenshare-<platform>` which contains an executable.
 
-# Setup
-Create the following environment variable the hifi-screenshare app will use to get the proper connection info:
-hifiScreenshareURL="<URL for authentication>"
+## `src/screenshareApp.js`
+The main process file to configure the electron app.
 
-# Screenshare API
-In order to launch the hifi-screenshare app from within interface, you will call the following:
-Screenshare.startScreenshare(displayName, userName, token, sessionID, apiKey);
-The app won't run without the correct info.
+## `src/screenshareMainProcess.js`
+The render file to display the app's UI.
 
-# Files included
-packager.js : 
-Calling npm run packager will use this file to create the actual electron hifi-screenshare executable
-
-src/main.js :
-The main process file to configure the electron app
-
-srce/app.js :
-The render file to dispaly the screenshare UI
\ No newline at end of file
+## `screenshareApp.html`
+The HTML that displays the screen selection UI and the confirmation screen UI.
\ No newline at end of file
diff --git a/screenshare/src/screenshareApp.js b/screenshare/src/screenshareApp.js
index 9fae20e0aa..3c1acb3722 100644
--- a/screenshare/src/screenshareApp.js
+++ b/screenshare/src/screenshareApp.js
@@ -140,6 +140,7 @@ function addSources(){
 // 5. Add thse sources
 const electron = require('electron');
 const SCREENSHARE_TITLE = "Screen share";
+const SCREENSHARE_TITLE_REGEX = new RegExp("^" + SCREENSHARE_TITLE + "$");
 const IMAGE_WIDTH = 265;
 const IMAGE_HEIGHT = 165;
 let screenshareSourceArray = [];
@@ -158,7 +159,7 @@ function showSources() {
             console.log("Error getting sources", error);
         }
         for (let source of sources) {
-            if (source.name.indexOf(SCREENSHARE_TITLE) > -1){
+            if (source.name.match(SCREENSHARE_TITLE_REGEX)){
                 continue;
             }
             sourceMap[source.id] = source;