merge upstream/master into andrew/bispinor

assignment-client/src/Agent.cpp

@@ -194,7 +194,7 @@ void Agent::run() {
     
     // setup an Avatar for the script to use
     ScriptableAvatar scriptedAvatar(&_scriptEngine);
-    scriptedAvatar.setForceFaceshiftConnected(true);
+    scriptedAvatar.setForceFaceTrackerConnected(true);
 
     // call model URL setters with empty URLs so our avatar, if user, will have the default models
     scriptedAvatar.setFaceModelURL(QUrl());

examples/example/games/billiards.js

@@ -105,37 +105,27 @@ function makeTable(pos) {
 }
 
 function makeBalls(pos) {
-	var colors =   [{ red: 255, green: 255, blue: 0},   		//  Yellow
-					{ red: 0, green: 0, blue: 255},     		//  Blue
-					{ red: 255, green: 0, blue: 0},				//  Red 
-					{ red: 128, green: 0, blue: 128},			//  Purple
-					{ red: 255, green: 165, blue: 0},			//  Orange 
-					{ red: 0, green: 255, blue: 0},				//  Green 
-					{ red: 128, green: 0, blue: 0},				//  Maroon
-					{ red: 0, green: 0, blue: 0},				//  Black 
-					{ red: 255, green: 255, blue: 224},     	//  Light Yellow
-					{ red: 173, green: 216, blue: 230},         //  Light Blue
-					{ red: 205, green: 92, blue: 92},           //  Indian Red
-					{ red: 218, green: 112, blue: 214},			//  Orchid
-					{ red: 218, green: 165, blue: 32},			//  GoldenRod
-					{ red: 255, green: 99, blue: 71},			//  Tomato
-					{ red: 128, green: 128, blue: 128}];		//  Gray
-
 	// Object balls 
+    var whichBall = [ 1, 14, 15, 4, 8, 7, 12, 9, 3, 13, 10, 5, 6, 11, 2 ];
+    var ballNumber = 0;
 	var ballPosition = { x: pos.x + (LENGTH / 4.0) * SCALE, y: pos.y + HEIGHT / 2.0 + DROP_HEIGHT, z: pos.z }; 
 	for (var row = 1; row <= 5; row++) {
 		ballPosition.z = pos.z - ((row - 1.0) / 2.0 * (BALL_SIZE + BALL_GAP) * SCALE); 
 		for (var spot = 0; spot < row; spot++) {
 			balls.push(Entities.addEntity(
-	    	{ type: "Sphere",
+	    	{ type: "Model",
+            modelURL: "https://s3.amazonaws.com/hifi-public/models/props/Pool/ball_" + whichBall[ballNumber].toString() + ".fbx",
 	        position: ballPosition,   
 			dimensions: { x: BALL_SIZE * SCALE, y: BALL_SIZE * SCALE, z: BALL_SIZE * SCALE }, 
-	      	color: colors[balls.length],
+            rotation: Quat.fromPitchYawRollDegrees((Math.random() - 0.5) * 20, (Math.random() - 0.5) * 20, (Math.random() - 0.5) * 20),
+	      	color: { red: 255, green: 255, blue: 255 },
 	      	gravity: {  x: 0, y: GRAVITY, z: 0 },
 	        ignoreCollisions: false,
 	        damping: 0.50,
+            shapeType: 2,
 	        collisionsWillMove: true }));
 	        ballPosition.z += (BALL_SIZE + BALL_GAP) * SCALE;
+            ballNumber++;
 		}
 		ballPosition.x += (BALL_GAP + Math.sqrt(3.0) / 2.0 * BALL_SIZE) * SCALE;
 	}
@@ -143,7 +133,8 @@ function makeBalls(pos) {
     // Cue Ball 
     cuePosition = { x: pos.x - (LENGTH / 4.0) * SCALE, y: pos.y + HEIGHT / 2.0 + DROP_HEIGHT, z: pos.z }; 
     cueBall = Entities.addEntity(
-	    	{ type: "Sphere",
+	    	{ type: "Model",
+            modelURL: "https://s3.amazonaws.com/hifi-public/models/props/Pool/cue_ball.fbx",
 	        position: cuePosition,   
 			dimensions: { x: BALL_SIZE * SCALE, y: BALL_SIZE * SCALE, z: BALL_SIZE * SCALE }, 
 	      	color: { red: 255, green: 255, blue: 255 },
@@ -152,6 +143,7 @@ function makeBalls(pos) {
 	      	velocity: {x: 0, y: 0, z: 0 },
 	        ignoreCollisions: false,
 	        damping: 0.50,
+            shapeType: 2,
 	        collisionsWillMove: true });
 	       
 }

examples/notifications.js

@@ -84,7 +84,7 @@ var users = [];
 var ctrlIsPressed = false;
 var ready = true;
 
-var randomSounds = new SoundArray({}, true);
+var randomSounds = new SoundArray({ localOnly: true }, true);
 var numberOfSounds = 2;
 for (var i = 1; i <= numberOfSounds; i++) {
     randomSounds.addSound(HIFI_PUBLIC_BUCKET + "sounds/UI/notification-general" + i + ".raw");

interface/external/faceshift/readme.txt

@@ -13,9 +13,14 @@ You may optionally choose to place this folder in a location outside the reposit
 
 If so our CMake find module expects you to set the ENV variable 'HIFI_LIB_DIR' to a directory containing a subfolder ‘faceshift’ that contains the lib and include folders. 
 
-1. Build a Faceshift static library from the fsbinarystream.cpp file. If you build a release version call it libfaceshift.a. The debug version should be called libfaceshiftd.a. Place this in the ‘lib’ folder in your Faceshift folder.
+1. Build a Faceshift static library from the fsbinarystream.cpp file.
+    Windows: Win32 console application; no precompiled header or SDL checks; no ATL or MFC headers; Project Properties, Configuration Type = Static Library (.lib).
 
-2. Copy the fsbinarystream.h header file from the Faceshift SDK into the ‘include’ folder in your Faceshift folder.
+2. Copy the library files to the ‘lib’ folder in your Faceshift folder.
+    OSX: If you build a release version call it libfaceshift.a. The debug version should be called libfaceshiftd.a.
+    Windows: The release and debug versions should be called faceshift.lib and faceshiftd.lib, respectively. Copy them into a ‘Win32’ folder in your ‘lib’ folder.
 
-3. Clear your build directory, run cmake and build, and you should be all set.
+3. Copy the fsbinarystream.h header file from the Faceshift SDK into the ‘include’ folder in your Faceshift folder.
+
+4. Clear your build directory, run cmake and build, and you should be all set.
 

interface/src/Application.cpp

@@ -1624,6 +1624,16 @@ FaceTracker* Application::getActiveFaceTracker() {
              (visage->isActive() ? static_cast<FaceTracker*>(visage.data()) : NULL)));
 }
 
+void Application::setActiveFaceTracker() {
+#ifdef HAVE_FACESHIFT
+    DependencyManager::get<Faceshift>()->setTCPEnabled(Menu::getInstance()->isOptionChecked(MenuOption::Faceshift));
+#endif 
+    DependencyManager::get<DdeFaceTracker>()->setEnabled(Menu::getInstance()->isOptionChecked(MenuOption::DDEFaceRegression));
+#ifdef HAVE_VISAGE
+    DependencyManager::get<Visage>()->updateEnabled();
+#endif
+}
+
 bool Application::exportEntities(const QString& filename, float x, float y, float z, float scale) {
     QVector<EntityItem*> entities;
     _entities.getTree()->findEntities(AACube(glm::vec3(x / (float)TREE_SCALE, 
@@ -1741,6 +1751,7 @@ void Application::init() {
 
     // initialize our face trackers after loading the menu settings
     DependencyManager::get<Faceshift>()->init();
+    DependencyManager::get<DdeFaceTracker>()->init();
     DependencyManager::get<Visage>()->init();
 
     Leapmotion::init();

interface/src/Application.h

@@ -366,6 +366,8 @@ public slots:
 
     void notifyPacketVersionMismatch();
 
+    void setActiveFaceTracker();
+
 private slots:
     void clearDomainOctreeDetails();
     void checkFPS();

interface/src/Menu.cpp

@@ -27,6 +27,7 @@
 #include "audio/AudioIOStatsRenderer.h"
 #include "audio/AudioScope.h"
 #include "avatar/AvatarManager.h"
+#include "devices/DdeFaceTracker.h"
 #include "devices/Faceshift.h"
 #include "devices/RealSense.h"
 #include "devices/SixenseManager.h"
@@ -357,18 +358,35 @@ Menu::Menu() {
                                   dialogsManager.data(), SLOT(lodTools()));
 
     QMenu* avatarDebugMenu = developerMenu->addMenu("Avatar");
+
+    QMenu* faceTrackingMenu = avatarDebugMenu->addMenu("Face Tracking");
+    {
+        QActionGroup* faceTrackerGroup = new QActionGroup(avatarDebugMenu);
+
+        QAction* noFaceTracker = addCheckableActionToQMenuAndActionHash(faceTrackingMenu, MenuOption::NoFaceTracking,
+            0, true,
+            qApp, SLOT(setActiveFaceTracker()));
+        faceTrackerGroup->addAction(noFaceTracker);
+
 #ifdef HAVE_FACESHIFT
-    addCheckableActionToQMenuAndActionHash(avatarDebugMenu,
+        QAction* faceshiftFaceTracker = addCheckableActionToQMenuAndActionHash(faceTrackingMenu, MenuOption::Faceshift,
-                                           MenuOption::Faceshift,
+            0, false,
-                                           0,
+            qApp, SLOT(setActiveFaceTracker()));
-                                           true,
+        faceTrackerGroup->addAction(faceshiftFaceTracker);
-                                           DependencyManager::get<Faceshift>().data(),
-                                           SLOT(setTCPEnabled(bool)));
 #endif
+
+        QAction* ddeFaceTracker = addCheckableActionToQMenuAndActionHash(faceTrackingMenu, MenuOption::DDEFaceRegression, 
+            0, false,
+            qApp, SLOT(setActiveFaceTracker()));
+        faceTrackerGroup->addAction(ddeFaceTracker);
+
 #ifdef HAVE_VISAGE
-    addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::Visage, 0, false,
+        QAction* visageFaceTracker = addCheckableActionToQMenuAndActionHash(faceTrackingMenu, MenuOption::Visage, 
-            DependencyManager::get<Visage>().data(), SLOT(updateEnabled()));
+            0, false,
+            qApp, SLOT(setActiveFaceTracker()));
+        faceTrackerGroup->addAction(visageFaceTracker);
 #endif
+    }
 
     addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::RenderSkeletonCollisionShapes);
     addCheckableActionToQMenuAndActionHash(avatarDebugMenu, MenuOption::RenderHeadCollisionShapes);

interface/src/Menu.h

@@ -133,13 +133,12 @@ namespace MenuOption {
     const QString CollideWithEnvironment = "Collide With World Boundaries";
     const QString Collisions = "Collisions";
     const QString Console = "Console...";
+    const QString ControlWithSpeech = "Control With Speech";
     const QString CopyAddress = "Copy Address to Clipboard";
     const QString CopyPath = "Copy Path to Clipboard";
-    const QString ControlWithSpeech = "Control With Speech";
+    const QString DDEFaceRegression = "DDE Face Regression";
-    const QString DeleteBookmark = "Delete Bookmark...";
-    const QString DontRenderEntitiesAsScene = "Don't Render Entities as Scene";
-    const QString DontDoPrecisionPicking = "Don't Do Precision Picking";
     const QString DecreaseAvatarSize = "Decrease Avatar Size";
+    const QString DeleteBookmark = "Delete Bookmark...";
     const QString DisableActivityLogger = "Disable Activity Logger";
     const QString DisableAutoAdjustLOD = "Disable Automatically Adjusting LOD";
     const QString DisableLightEntities = "Disable Light Entities";
@@ -152,7 +151,9 @@ namespace MenuOption {
     const QString DisplayModelElementChildProxies = "Display Model Element Children";
     const QString DisplayModelElementProxy = "Display Model Element Bounds";
     const QString DisplayTimingDetails = "Display Timing Details";
+    const QString DontDoPrecisionPicking = "Don't Do Precision Picking";
     const QString DontFadeOnOctreeServerChanges = "Don't Fade In/Out on Octree Server Changes";
+    const QString DontRenderEntitiesAsScene = "Don't Render Entities as Scene";
     const QString EchoLocalAudio = "Echo Local Audio";
     const QString EchoServerAudio = "Echo Server Audio";
     const QString EditEntitiesHelp = "Edit Entities Help...";
@@ -192,6 +193,7 @@ namespace MenuOption {
     const QString MuteEnvironment = "Mute Environment";
     const QString NetworkSimulator = "Network Simulator...";
     const QString NewVoxelCullingMode = "New Voxel Culling Mode";
+    const QString NoFaceTracking = "None";
     const QString ObeyEnvironmentalGravity = "Obey Environmental Gravity";
     const QString OctreeStats = "Voxel and Entity Statistics";
     const QString OffAxisProjection = "Off-Axis Projection";

interface/src/UIUtil.cpp

@@ -12,6 +12,9 @@
 #include <QStyle>
 #include <QStyleOptionTitleBar>
 
+#include "DependencyManager.h"
+#include "GLCanvas.h"
+
 #include "UIUtil.h"
 
 int UIUtil::getWindowTitleBarHeight(const QWidget* window) {
@@ -27,3 +30,49 @@ int UIUtil::getWindowTitleBarHeight(const QWidget* window) {
 
     return titleBarHeight;
 }
+
+// When setting the font size of a widget in points, the rendered text will be larger
+// on Windows and Linux than on Mac OSX.  This is because Windows and Linux use a DPI
+// of 96, while OSX uses 72.  In order to get consistent results across platforms, the
+// font sizes need to be scaled based on the system DPI.
+// This function will scale the font size of widget and all
+// of its children recursively.
+//
+// When creating widgets, if a font size isn't explicitly set Qt will choose a
+// reasonable, but often different font size across platforms.  This means
+// YOU SHOUD EXPLICITLY SET ALL FONT SIZES and call this function OR not use
+// this function at all.  If you mix both you will end up with inconsistent results
+// across platforms.
+void UIUtil::scaleWidgetFontSizes(QWidget* widget) {
+    auto glCanvas = DependencyManager::get<GLCanvas>();
+
+    // This is the base dpi that we are targetting.  This is based on Mac OSXs default DPI,
+    // and is the basis for all font sizes.
+    const float BASE_DPI = 72.0f;
+
+#ifdef Q_OS_MAC
+    const float NATIVE_DPI = 72.0f;
+#else
+    const float NATIVE_DPI = 96.0f;
+#endif
+
+    // Scale fonts based on the native dpi.  On Windows, where the native DPI is 96,
+    // the scale will be: 72.0 / 96.0 = 0.75
+    float fontScale = BASE_DPI / NATIVE_DPI;
+
+    internalScaleWidgetFontSizes(widget, fontScale);
+}
+
+// Depth-first traversal through widget hierarchy.  It is important to do a depth-first
+// traversal because modifying the font size of a parent node can affect children.
+void UIUtil::internalScaleWidgetFontSizes(QWidget* widget, float scale) {
+    for (auto child : widget->findChildren<QWidget*>()) {
+        if (child->parent() == widget) {
+            internalScaleWidgetFontSizes(child, scale);
+        }
+    }
+
+    QFont font = widget->font();
+    font.setPointSizeF(font.pointSizeF() * scale);
+    widget->setFont(font);
+}

interface/src/UIUtil.h

@@ -18,7 +18,10 @@
 class UIUtil {
 public:
     static int getWindowTitleBarHeight(const QWidget* window);
+    static void scaleWidgetFontSizes(QWidget* widget);
 
+private:
+    static void internalScaleWidgetFontSizes(QWidget* widget, float scale);
 };
 
 #endif // hifi_UIUtil_h

interface/src/audio/AudioScope.h

@@ -75,4 +75,4 @@ private:
 
 };
 
-#endif // hifi_AudioScope_h
+#endif // hifi_AudioScope_h

interface/src/avatar/Head.cpp

@@ -80,15 +80,10 @@ void Head::simulate(float deltaTime, bool isMine, bool billboard) {
         // Only use face trackers when not playing back a recording.
         if (!myAvatar->isPlaying()) {
             FaceTracker* faceTracker = Application::getInstance()->getActiveFaceTracker();
-            auto dde = DependencyManager::get<DdeFaceTracker>();
+            _isFaceTrackerConnected = faceTracker != NULL;
-            auto faceshift = DependencyManager::get<Faceshift>();
+            if (_isFaceTrackerConnected) {
-            
-            if ((_isFaceshiftConnected = (faceshift == faceTracker))) {
                 _blendshapeCoefficients = faceTracker->getBlendshapeCoefficients();
-            } else if (dde->isActive()) {
+            }
-                faceTracker = dde.data();
-                _blendshapeCoefficients = faceTracker->getBlendshapeCoefficients();
-            }            
         }
         //  Twist the upper body to follow the rotation of the head, but only do this with my avatar,
         //  since everyone else will see the full joint rotations for other people.  
@@ -109,7 +104,7 @@ void Head::simulate(float deltaTime, bool isMine, bool billboard) {
         _longTermAverageLoudness = glm::mix(_longTermAverageLoudness, _averageLoudness, glm::min(deltaTime / AUDIO_LONG_TERM_AVERAGING_SECS, 1.0f));
     }
     
-    if (!(_isFaceshiftConnected || billboard)) {
+    if (!(_isFaceTrackerConnected || billboard)) {
         // Update eye saccades
         const float AVERAGE_MICROSACCADE_INTERVAL = 0.50f;
         const float AVERAGE_SACCADE_INTERVAL = 4.0f;

interface/src/devices/DdeFaceTracker.cpp

@@ -44,58 +44,40 @@ struct Packet{
 };
 
 DdeFaceTracker::DdeFaceTracker() :
-_lastReceiveTimestamp(0),
+    DdeFaceTracker(QHostAddress::Any, DDE_FEATURE_POINT_SERVER_PORT)
-_reset(false),
+{
-_leftBlinkIndex(0), // see http://support.faceshift.com/support/articles/35129-export-of-blendshapes
+
-_rightBlinkIndex(1),
+}
-_leftEyeOpenIndex(8),
+
-_rightEyeOpenIndex(9),
+DdeFaceTracker::DdeFaceTracker(const QHostAddress& host, quint16 port) :
-_browDownLeftIndex(14),
+    _lastReceiveTimestamp(0),
-_browDownRightIndex(15),
+    _reset(false),
-_browUpCenterIndex(16),
+    _leftBlinkIndex(0), // see http://support.faceshift.com/support/articles/35129-export-of-blendshapes
-_browUpLeftIndex(17),
+    _rightBlinkIndex(1),
-_browUpRightIndex(18),
+    _leftEyeOpenIndex(8),
-_mouthSmileLeftIndex(28),
+    _rightEyeOpenIndex(9),
-_mouthSmileRightIndex(29),
+    _browDownLeftIndex(14),
-_jawOpenIndex(21)
+    _browDownRightIndex(15),
+    _browUpCenterIndex(16),
+    _browUpLeftIndex(17),
+    _browUpRightIndex(18),
+    _mouthSmileLeftIndex(28),
+    _mouthSmileRightIndex(29),
+    _jawOpenIndex(21),
+    _host(host),
+    _port(port)
 {
     _blendshapeCoefficients.resize(NUM_EXPRESSION);
     
     connect(&_udpSocket, SIGNAL(readyRead()), SLOT(readPendingDatagrams()));
     connect(&_udpSocket, SIGNAL(error(QAbstractSocket::SocketError)), SLOT(socketErrorOccurred(QAbstractSocket::SocketError)));
     connect(&_udpSocket, SIGNAL(stateChanged(QAbstractSocket::SocketState)), SLOT(socketStateChanged(QAbstractSocket::SocketState)));
-    
-    bindTo(DDE_FEATURE_POINT_SERVER_PORT);
-}
-
-DdeFaceTracker::DdeFaceTracker(const QHostAddress& host, quint16 port) :
-_lastReceiveTimestamp(0),
-_reset(false),
-_leftBlinkIndex(0), // see http://support.faceshift.com/support/articles/35129-export-of-blendshapes
-_rightBlinkIndex(1),
-_leftEyeOpenIndex(8),
-_rightEyeOpenIndex(9),
-_browDownLeftIndex(14),
-_browDownRightIndex(15),
-_browUpCenterIndex(16),
-_browUpLeftIndex(17),
-_browUpRightIndex(18),
-_mouthSmileLeftIndex(28),
-_mouthSmileRightIndex(29),
-_jawOpenIndex(21)
-{
-    _blendshapeCoefficients.resize(NUM_EXPRESSION);
-    
-    connect(&_udpSocket, SIGNAL(readyRead()), SLOT(readPendingDatagrams()));
-    connect(&_udpSocket, SIGNAL(error(QAbstractSocket::SocketError)), SLOT(socketErrorOccurred(QAbstractSocket::SocketError)));
-    connect(&_udpSocket, SIGNAL(stateChanged(QAbstractSocket::SocketState)), SIGNAL(socketStateChanged(QAbstractSocket::SocketState)));
-    
-    bindTo(host, port);
 }
 
 DdeFaceTracker::~DdeFaceTracker() {
-    if(_udpSocket.isOpen())
+    if (_udpSocket.isOpen()) {
         _udpSocket.close();
+    }
 }
 
 void DdeFaceTracker::init() {
@@ -110,15 +92,12 @@ void DdeFaceTracker::update() {
     
 }
 
-void DdeFaceTracker::bindTo(quint16 port) {
+void DdeFaceTracker::setEnabled(bool enabled) {
-    bindTo(QHostAddress::Any, port);
+    // isOpen() does not work as one might expect on QUdpSocket; don't test isOpen() before closing socket.
-}
+    _udpSocket.close();
-
+    if (enabled) {
-void DdeFaceTracker::bindTo(const QHostAddress& host, quint16 port) {
+        _udpSocket.bind(_host, _port);
-    if(_udpSocket.isOpen()) {
-        _udpSocket.close();
     }
-    _udpSocket.bind(host, port);
 }
 
 bool DdeFaceTracker::isActive() const {
@@ -135,7 +114,7 @@ void DdeFaceTracker::socketStateChanged(QAbstractSocket::SocketState socketState
     QString state;
     switch(socketState) {
         case QAbstractSocket::BoundState:
-            state = "Bounded";
+            state = "Bound";
             break;
         case QAbstractSocket::ClosingState:
             state = "Closing";
@@ -156,7 +135,7 @@ void DdeFaceTracker::socketStateChanged(QAbstractSocket::SocketState socketState
             state = "Unconnected";
             break;
     }
-    qDebug() << "[Info] DDE Face Tracker Socket: " << socketState;
+    qDebug() << "[Info] DDE Face Tracker Socket: " << state;
 }
 
 void DdeFaceTracker::readPendingDatagrams() {

interface/src/devices/DdeFaceTracker.h

@@ -28,9 +28,6 @@ public:
     void reset();
     void update();
     
-    //sockets
-    void bindTo(quint16 port);
-    void bindTo(const QHostAddress& host, quint16 port);
     bool isActive() const;
     
     float getLeftBlink() const { return getBlendshapeCoefficient(_leftBlinkIndex); }
@@ -47,7 +44,10 @@ public:
     float getMouthSize() const { return getBlendshapeCoefficient(_jawOpenIndex); }
     float getMouthSmileLeft() const { return getBlendshapeCoefficient(_mouthSmileLeftIndex); }
     float getMouthSmileRight() const { return getBlendshapeCoefficient(_mouthSmileRightIndex); }
-    
+
+public slots:
+    void setEnabled(bool enabled);
+
 private slots:
     
     //sockets
@@ -59,6 +59,9 @@ private:
     DdeFaceTracker();
     DdeFaceTracker(const QHostAddress& host, quint16 port);
     ~DdeFaceTracker();
+
+    QHostAddress _host;
+    quint16 _port;
     
     float getBlendshapeCoefficient(int index) const;
     void decodePacket(const QByteArray& buffer);

interface/src/devices/Visage.cpp

@@ -174,7 +174,8 @@ void Visage::reset() {
 void Visage::updateEnabled() {
     setEnabled(Menu::getInstance()->isOptionChecked(MenuOption::Visage) &&
         !(Menu::getInstance()->isOptionChecked(MenuOption::Faceshift) &&
-            DependencyManager::get<Faceshift>()->isConnectedOrConnecting()));
+            DependencyManager::get<Faceshift>()->isConnectedOrConnecting()) &&
+        !Menu::getInstance()->isOptionChecked(MenuOption::DDEFaceRegression));
 }
 
 void Visage::setEnabled(bool enabled) {

interface/src/ui/LoginDialog.cpp

@@ -21,6 +21,7 @@
 #include "AccountManager.h"
 #include "ui_loginDialog.h"
 #include "LoginDialog.h"
+#include "UIUtil.h"
 
 const QString FORGOT_PASSWORD_URL = "https://metaverse.highfidelity.io/users/password/new";
 
@@ -42,6 +43,8 @@ LoginDialog::LoginDialog(QWidget* parent) :
     connect(_ui->closeButton, &QPushButton::clicked,
             this, &LoginDialog::close);
 
+    UIUtil::scaleWidgetFontSizes(this);
+
     // Initialize toggle connection
     toggleQAction();
 };

interface/src/ui/PreferencesDialog.cpp

@@ -10,6 +10,7 @@
 //
 
 #include <QFileDialog>
+#include <QFont>
 
 #include <AudioClient.h>
 #include <avatar/AvatarManager.h>
@@ -23,6 +24,7 @@
 #include "PreferencesDialog.h"
 #include "Snapshot.h"
 #include "UserActivityLogger.h"
+#include "UIUtil.h"
 
 const int PREFERENCES_HEIGHT_PADDING = 20;
 
@@ -46,6 +48,8 @@ PreferencesDialog::PreferencesDialog(QWidget* parent) :
     // move dialog to left side
     move(parentWidget()->geometry().topLeft());
     setFixedHeight(parentWidget()->size().height() - PREFERENCES_HEIGHT_PADDING);
+
+    UIUtil::scaleWidgetFontSizes(this);
 }
 
 void PreferencesDialog::accept() {

interface/src/ui/RunningScriptsWidget.cpp

@@ -64,6 +64,8 @@ RunningScriptsWidget::RunningScriptsWidget(QWidget* parent) :
     connect(ui->loadScriptFromURLButton, &QPushButton::clicked,
             Application::getInstance(), &Application::loadScriptURLDialog);
     connect(&_signalMapper, SIGNAL(mapped(QString)), Application::getInstance(), SLOT(stopScript(const QString&)));
+
+    UIUtil::scaleWidgetFontSizes(this);
 }
 
 RunningScriptsWidget::~RunningScriptsWidget() {
@@ -103,6 +105,7 @@ void RunningScriptsWidget::setRunningScripts(const QStringList& list) {
             hash.insert(list.at(i), 1);
         }
         QWidget* row = new QWidget(ui->scriptListWidget);
+        row->setFont(ui->scriptListWidget->font());
         row->setLayout(new QHBoxLayout(row));
 
         QUrl url = QUrl(list.at(i));

interface/ui/runningScriptsWidget.ui

@@ -10,6 +10,12 @@
     <height>728</height>
    </rect>
   </property>
+  <property name="font">
+   <font>
+    <family>Helvetica,Arial,sans-serif</family>
+    <pointsize>13</pointsize>
+   </font>
+  </property>
   <property name="windowTitle">
    <string>Running Scripts</string>
   </property>
@@ -31,6 +37,12 @@
        <height>141</height>
       </size>
      </property>
+     <property name="font">
+      <font>
+       <family>Helvetica,Arial,sans-serif</family>
+       <pointsize>13</pointsize>
+      </font>
+     </property>
      <layout class="QVBoxLayout" name="verticalLayout_4">
       <property name="spacing">
        <number>0</number>
@@ -113,6 +125,12 @@ font: bold 16pt;
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="font">
+         <font>
+          <family>Helvetica,Arial,sans-serif</family>
+          <pointsize>13</pointsize>
+         </font>
+        </property>
         <property name="styleSheet">
          <string notr="true">reloadStopButtonArea { padding: 0 }</string>
         </property>
@@ -131,6 +149,12 @@ font: bold 16pt;
          </property>
          <item>
           <widget class="QPushButton" name="reloadAllButton">
+           <property name="font">
+            <font>
+             <family>Helvetica,Arial,sans-serif</family>
+             <pointsize>13</pointsize>
+            </font>
+           </property>
            <property name="text">
             <string>Reload all</string>
            </property>
@@ -138,6 +162,12 @@ font: bold 16pt;
          </item>
          <item>
           <widget class="QPushButton" name="stopAllButton">
+           <property name="font">
+            <font>
+             <family>Helvetica,Arial,sans-serif</family>
+             <pointsize>13</pointsize>
+            </font>
+           </property>
            <property name="text">
             <string>Stop all</string>
            </property>
@@ -167,6 +197,12 @@ font: bold 16pt;
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="font">
+         <font>
+          <family>Helvetica,Arial,sans-serif</family>
+          <pointsize>13</pointsize>
+         </font>
+        </property>
         <layout class="QVBoxLayout" name="verticalLayout_8">
          <property name="spacing">
           <number>0</number>
@@ -191,8 +227,14 @@ font: bold 16pt;
              <verstretch>0</verstretch>
             </sizepolicy>
            </property>
+           <property name="font">
+            <font>
+             <family>Helvetica,Arial,sans-serif</family>
+             <pointsize>14</pointsize>
+            </font>
+           </property>
            <property name="styleSheet">
-            <string notr="true">font: 14pt; color: #5f5f5f; margin: 2px;</string>
+            <string notr="true">color: #5f5f5f; margin: 2px;</string>
            </property>
            <property name="text">
             <string>There are no scripts running.</string>
@@ -255,12 +297,15 @@ font: bold 16pt;
               <verstretch>0</verstretch>
              </sizepolicy>
             </property>
+            <property name="font">
+             <font>
+              <family>Helvetica,Arial,sans-serif</family>
+              <pointsize>14</pointsize>
+             </font>
+            </property>
             <property name="layoutDirection">
              <enum>Qt::LeftToRight</enum>
             </property>
-            <property name="styleSheet">
-             <string notr="true">font-size: 14pt;</string>
-            </property>
             <layout class="QVBoxLayout" name="verticalLayout_3">
              <property name="spacing">
               <number>0</number>
@@ -279,6 +324,12 @@ font: bold 16pt;
              </property>
              <item>
               <widget class="QWidget" name="scriptListWidget" native="true">
+               <property name="font">
+                <font>
+                 <family>Helvetica,Arial,sans-serif</family>
+                 <pointsize>14</pointsize>
+                </font>
+               </property>
                <layout class="QVBoxLayout" name="verticalLayout_5">
                 <property name="spacing">
                  <number>0</number>
@@ -300,8 +351,14 @@ font: bold 16pt;
              </item>
              <item>
               <widget class="QLabel" name="tipLabel">
+               <property name="font">
+                <font>
+                 <family>Helvetica,Arial,sans-serif</family>
+                 <pointsize>14</pointsize>
+                </font>
+               </property>
                <property name="styleSheet">
-                <string notr="true">font: 14pt; color: #5f5f5f; margin: 2px;</string>
+                <string notr="true">color: #5f5f5f; margin: 2px;</string>
                </property>
                <property name="text">
                 <string>Tip</string>

libraries/audio-client/src/AudioClient.cpp

@@ -85,16 +85,9 @@ AudioClient::AudioClient() :
     _isStereoInput(false),
     _outputStarveDetectionStartTimeMsec(0),
     _outputStarveDetectionCount(0),
-    _outputBufferSizeFrames("audioOutputBufferSize",
+    _outputBufferSizeFrames("audioOutputBufferSize", DEFAULT_AUDIO_OUTPUT_BUFFER_SIZE_FRAMES),
-                            DEFAULT_MAX_FRAMES_OVER_DESIRED),
-#ifdef Q_OS_ANDROID
-    _outputStarveDetectionEnabled("audioOutputStarveDetectionEnabled",
-                                  false),
-#else
     _outputStarveDetectionEnabled("audioOutputStarveDetectionEnabled",
                                   DEFAULT_AUDIO_OUTPUT_STARVE_DETECTION_ENABLED),
-#endif
-
     _outputStarveDetectionPeriodMsec("audioOutputStarveDetectionPeriod",
                                      DEFAULT_AUDIO_OUTPUT_STARVE_DETECTION_PERIOD),
     _outputStarveDetectionThreshold("audioOutputStarveDetectionThreshold",
@@ -1090,19 +1083,23 @@ void AudioClient::outputNotify() {
     if (recentUnfulfilled > 0) {
         if (_outputStarveDetectionEnabled.get()) {
             quint64 now = usecTimestampNow() / 1000;
-            quint64 dt = now - _outputStarveDetectionStartTimeMsec;
+            int dt = (int)(now - _outputStarveDetectionStartTimeMsec);
             if (dt > _outputStarveDetectionPeriodMsec.get()) {
                 _outputStarveDetectionStartTimeMsec = now;
                 _outputStarveDetectionCount = 0;
             } else {
                 _outputStarveDetectionCount += recentUnfulfilled;
                 if (_outputStarveDetectionCount > _outputStarveDetectionThreshold.get()) {
-                    int newOutputBufferSizeFrames = _outputBufferSizeFrames.get() + 1;
-                    qDebug() << "Starve detection threshold met, increasing buffer size to " << newOutputBufferSizeFrames;
-                    setOutputBufferSize(newOutputBufferSizeFrames);
-
                     _outputStarveDetectionStartTimeMsec = now;
                     _outputStarveDetectionCount = 0;
+
+                    int oldOutputBufferSizeFrames = _outputBufferSizeFrames.get();
+                    int newOutputBufferSizeFrames = oldOutputBufferSizeFrames + 1;
+                    setOutputBufferSize(newOutputBufferSizeFrames);
+                    newOutputBufferSizeFrames = _outputBufferSizeFrames.get();
+                    if (newOutputBufferSizeFrames > oldOutputBufferSizeFrames) {
+                        qDebug() << "Starve detection threshold met, increasing buffer size to " << newOutputBufferSizeFrames;
+                    }
                 }
             }
         }

libraries/audio-client/src/AudioClient.h

@@ -57,7 +57,11 @@ static const int NUM_AUDIO_CHANNELS = 2;
 static const int DEFAULT_AUDIO_OUTPUT_BUFFER_SIZE_FRAMES = 3;
 static const int MIN_AUDIO_OUTPUT_BUFFER_SIZE_FRAMES = 1;
 static const int MAX_AUDIO_OUTPUT_BUFFER_SIZE_FRAMES = 20;
-static const int DEFAULT_AUDIO_OUTPUT_STARVE_DETECTION_ENABLED = true;
+#if defined(Q_OS_ANDROID) || defined(Q_OS_WIN) 
+    static const int DEFAULT_AUDIO_OUTPUT_STARVE_DETECTION_ENABLED = false;
+#else
+    static const int DEFAULT_AUDIO_OUTPUT_STARVE_DETECTION_ENABLED = true;
+#endif
 static const int DEFAULT_AUDIO_OUTPUT_STARVE_DETECTION_THRESHOLD = 3;
 static const quint64 DEFAULT_AUDIO_OUTPUT_STARVE_DETECTION_PERIOD = 10 * 1000; // 10 Seconds
 

libraries/avatars/src/AvatarData.cpp

@@ -44,7 +44,7 @@ AvatarData::AvatarData() :
     _handState(0),
     _keyState(NO_KEY_DOWN),
     _isChatCirclingEnabled(false),
-    _forceFaceshiftConnected(false),
+    _forceFaceTrackerConnected(false),
     _hasNewJointRotations(true),
     _headData(NULL),
     _handData(NULL),
@@ -136,8 +136,8 @@ QByteArray AvatarData::toByteArray() {
     if (!_headData) {
         _headData = new HeadData(this);
     }
-    if (_forceFaceshiftConnected) {
+    if (_forceFaceTrackerConnected) {
-        _headData->_isFaceshiftConnected = true;
+        _headData->_isFaceTrackerConnected = true;
     }
     
     QByteArray avatarDataByteArray;
@@ -191,7 +191,7 @@ QByteArray AvatarData::toByteArray() {
         setAtBit(bitItems, HAND_STATE_FINGER_POINTING_BIT);
     }
     // faceshift state
-    if (_headData->_isFaceshiftConnected) {
+    if (_headData->_isFaceTrackerConnected) {
         setAtBit(bitItems, IS_FACESHIFT_CONNECTED);
     }
     if (_isChatCirclingEnabled) {
@@ -208,7 +208,7 @@ QByteArray AvatarData::toByteArray() {
     }
 
     // If it is connected, pack up the data
-    if (_headData->_isFaceshiftConnected) {
+    if (_headData->_isFaceTrackerConnected) {
         memcpy(destinationBuffer, &_headData->_leftEyeBlink, sizeof(float));
         destinationBuffer += sizeof(float);
 
@@ -417,7 +417,7 @@ int AvatarData::parseDataAtOffset(const QByteArray& packet, int offset) {
         _handState = getSemiNibbleAt(bitItems, HAND_STATE_START_BIT) 
             + (oneAtBit(bitItems, HAND_STATE_FINGER_POINTING_BIT) ? IS_FINGER_POINTING_FLAG : 0);
         
-        _headData->_isFaceshiftConnected = oneAtBit(bitItems, IS_FACESHIFT_CONNECTED);
+        _headData->_isFaceTrackerConnected = oneAtBit(bitItems, IS_FACESHIFT_CONNECTED);
         _isChatCirclingEnabled = oneAtBit(bitItems, IS_CHAT_CIRCLING_ENABLED);
         bool hasReferential = oneAtBit(bitItems, HAS_REFERENTIAL);
         
@@ -436,7 +436,7 @@ int AvatarData::parseDataAtOffset(const QByteArray& packet, int offset) {
         }
     
     
-        if (_headData->_isFaceshiftConnected) {
+        if (_headData->_isFaceTrackerConnected) {
             float leftEyeBlink, rightEyeBlink, averageLoudness, browAudioLift;
             minPossibleSize += sizeof(leftEyeBlink) + sizeof(rightEyeBlink) + sizeof(averageLoudness) + sizeof(browAudioLift);
             minPossibleSize++; // one byte for blendDataSize

libraries/avatars/src/AvatarData.h

@@ -241,7 +241,7 @@ public:
 
     Q_INVOKABLE void setBlendshape(QString name, float val) { _headData->setBlendshape(name, val); }
 
-    void setForceFaceshiftConnected(bool connected) { _forceFaceshiftConnected = connected; }
+    void setForceFaceTrackerConnected(bool connected) { _forceFaceTrackerConnected = connected; }
 
     // key state
     void setKeyState(KeyState s) { _keyState = s; }
@@ -357,7 +357,7 @@ protected:
     KeyState _keyState;
 
     bool _isChatCirclingEnabled;
-    bool _forceFaceshiftConnected;
+    bool _forceFaceTrackerConnected;
     bool _hasNewJointRotations; // set in AvatarData, cleared in Avatar
 
     HeadData* _headData;

libraries/avatars/src/HeadData.cpp

@@ -31,7 +31,7 @@ HeadData::HeadData(AvatarData* owningAvatar) :
     _torsoTwist(0.0f),
     _lookAtPosition(0.0f, 0.0f, 0.0f),
     _audioLoudness(0.0f),
-    _isFaceshiftConnected(false),
+    _isFaceTrackerConnected(false),
     _leftEyeBlink(0.0f),
     _rightEyeBlink(0.0f),
     _averageLoudness(0.0f),

libraries/avatars/src/HeadData.h

@@ -92,7 +92,7 @@ protected:
 
     glm::vec3 _lookAtPosition;
     float _audioLoudness;
-    bool _isFaceshiftConnected;
+    bool _isFaceTrackerConnected;
     float _leftEyeBlink;
     float _rightEyeBlink;
     float _averageLoudness;

libraries/avatars/src/Player.cpp

@@ -110,7 +110,7 @@ void Player::startPlaying() {
         }
         
         // Fake faceshift connection
-        _avatar->setForceFaceshiftConnected(true);
+        _avatar->setForceFaceTrackerConnected(true);
         
         qDebug() << "Recorder::startPlaying()";
         setupAudioThread();
@@ -136,8 +136,8 @@ void Player::stopPlaying() {
     cleanupAudioThread();
     _avatar->clearJointsData();
     
-    // Turn off fake faceshift connection
+    // Turn off fake face tracker connection
-    _avatar->setForceFaceshiftConnected(false);
+    _avatar->setForceFaceTrackerConnected(false);
     
     if (_useAttachments) {
         _avatar->setAttachmentData(_currentContext.attachments);
@@ -255,8 +255,8 @@ void Player::play() {
     
     HeadData* head = const_cast<HeadData*>(_avatar->getHeadData());
     if (head) {
-        // Make sure fake faceshift connection doesn't get turned off
+        // Make sure fake face tracker connection doesn't get turned off
-        _avatar->setForceFaceshiftConnected(true);
+        _avatar->setForceFaceTrackerConnected(true);
         
         QVector<float> blendCoef(currentFrame.getBlendshapeCoefficients().size());
         for (int i = 0; i < currentFrame.getBlendshapeCoefficients().size(); ++i) {