From 43df5b55fe5adf6c3fefdc61c431225fe7587668 Mon Sep 17 00:00:00 2001 From: Brad Hefta-Gaub Date: Sun, 1 Nov 2015 11:55:55 -0800 Subject: [PATCH] fix linker warnings --- .../controllers/src/controllers/DeviceProxy.cpp | 11 +++++++---- .../controllers/src/controllers/impl/Endpoint.cpp | 12 +++++++----- .../controllers/src/controllers/impl/Mapping.cpp | 9 ++++++++- libraries/controllers/src/controllers/impl/Route.cpp | 8 +++++++- .../impl/conditionals/EndpointConditional.cpp | 8 +++++++- .../controllers/impl/conditionals/NotConditional.cpp | 8 +++++++- .../src/controllers/impl/endpoints/ArrayEndpoint.cpp | 8 +++++++- .../src/controllers/impl/endpoints/JSEndpoint.cpp | 8 +++++++- .../controllers/impl/endpoints/StandardEndpoint.cpp | 8 +++++++- .../impl/filters/ConstrainToIntegerFilter.cpp | 8 +++++++- .../filters/ConstrainToPositiveIntegerFilter.cpp | 8 +++++++- .../src/controllers/impl/filters/InvertFilter.cpp | 8 +++++++- 12 files changed, 85 insertions(+), 19 deletions(-) diff --git a/libraries/controllers/src/controllers/DeviceProxy.cpp b/libraries/controllers/src/controllers/DeviceProxy.cpp index f3e9526080..f03354c52d 100644 --- a/libraries/controllers/src/controllers/DeviceProxy.cpp +++ b/libraries/controllers/src/controllers/DeviceProxy.cpp @@ -7,8 +7,11 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "DeviceProxy.h" - -namespace controller { -} +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "DeviceProxy.h" diff --git a/libraries/controllers/src/controllers/impl/Endpoint.cpp b/libraries/controllers/src/controllers/impl/Endpoint.cpp index 9e9b13f8ea..e771b1916f 100644 --- a/libraries/controllers/src/controllers/impl/Endpoint.cpp +++ b/libraries/controllers/src/controllers/impl/Endpoint.cpp @@ -6,9 +6,11 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "Endpoint.h" - -namespace controller { - -} +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "Endpoint.h" diff --git a/libraries/controllers/src/controllers/impl/Mapping.cpp b/libraries/controllers/src/controllers/impl/Mapping.cpp index 68c43da393..dd8e1c1d48 100644 --- a/libraries/controllers/src/controllers/impl/Mapping.cpp +++ b/libraries/controllers/src/controllers/impl/Mapping.cpp @@ -5,4 +5,11 @@ // Distributed under the Apache License, Version 2.0. // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "Mapping.h" + +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "Mapping.h" diff --git a/libraries/controllers/src/controllers/impl/Route.cpp b/libraries/controllers/src/controllers/impl/Route.cpp index 56590e564a..c74f809195 100644 --- a/libraries/controllers/src/controllers/impl/Route.cpp +++ b/libraries/controllers/src/controllers/impl/Route.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "Route.h" +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "Route.h" diff --git a/libraries/controllers/src/controllers/impl/conditionals/EndpointConditional.cpp b/libraries/controllers/src/controllers/impl/conditionals/EndpointConditional.cpp index 03e16b8cf9..f833eedb60 100644 --- a/libraries/controllers/src/controllers/impl/conditionals/EndpointConditional.cpp +++ b/libraries/controllers/src/controllers/impl/conditionals/EndpointConditional.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "EndpointConditional.h" \ No newline at end of file +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "EndpointConditional.h" \ No newline at end of file diff --git a/libraries/controllers/src/controllers/impl/conditionals/NotConditional.cpp b/libraries/controllers/src/controllers/impl/conditionals/NotConditional.cpp index 0c8d602b9e..e30b060985 100644 --- a/libraries/controllers/src/controllers/impl/conditionals/NotConditional.cpp +++ b/libraries/controllers/src/controllers/impl/conditionals/NotConditional.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "NotConditional.h" +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "NotConditional.h" diff --git a/libraries/controllers/src/controllers/impl/endpoints/ArrayEndpoint.cpp b/libraries/controllers/src/controllers/impl/endpoints/ArrayEndpoint.cpp index c083a7147d..5dea1de34e 100644 --- a/libraries/controllers/src/controllers/impl/endpoints/ArrayEndpoint.cpp +++ b/libraries/controllers/src/controllers/impl/endpoints/ArrayEndpoint.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "ArrayEndpoint.h" \ No newline at end of file +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "ArrayEndpoint.h" \ No newline at end of file diff --git a/libraries/controllers/src/controllers/impl/endpoints/JSEndpoint.cpp b/libraries/controllers/src/controllers/impl/endpoints/JSEndpoint.cpp index 4560741d12..7f0e80cbae 100644 --- a/libraries/controllers/src/controllers/impl/endpoints/JSEndpoint.cpp +++ b/libraries/controllers/src/controllers/impl/endpoints/JSEndpoint.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "JSEndpoint.h" \ No newline at end of file +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "JSEndpoint.h" \ No newline at end of file diff --git a/libraries/controllers/src/controllers/impl/endpoints/StandardEndpoint.cpp b/libraries/controllers/src/controllers/impl/endpoints/StandardEndpoint.cpp index 09920d249c..89bbe5d777 100644 --- a/libraries/controllers/src/controllers/impl/endpoints/StandardEndpoint.cpp +++ b/libraries/controllers/src/controllers/impl/endpoints/StandardEndpoint.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "StandardEndpoint.h" \ No newline at end of file +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "StandardEndpoint.h" \ No newline at end of file diff --git a/libraries/controllers/src/controllers/impl/filters/ConstrainToIntegerFilter.cpp b/libraries/controllers/src/controllers/impl/filters/ConstrainToIntegerFilter.cpp index 78ffb47693..8bd3d2db89 100644 --- a/libraries/controllers/src/controllers/impl/filters/ConstrainToIntegerFilter.cpp +++ b/libraries/controllers/src/controllers/impl/filters/ConstrainToIntegerFilter.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "ConstrainToIntegerFilter.h" +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "ConstrainToIntegerFilter.h" diff --git a/libraries/controllers/src/controllers/impl/filters/ConstrainToPositiveIntegerFilter.cpp b/libraries/controllers/src/controllers/impl/filters/ConstrainToPositiveIntegerFilter.cpp index d78942b18f..f1abc8cecd 100644 --- a/libraries/controllers/src/controllers/impl/filters/ConstrainToPositiveIntegerFilter.cpp +++ b/libraries/controllers/src/controllers/impl/filters/ConstrainToPositiveIntegerFilter.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "ConstrainToPositiveIntegerFilter.h" +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "ConstrainToPositiveIntegerFilter.h" diff --git a/libraries/controllers/src/controllers/impl/filters/InvertFilter.cpp b/libraries/controllers/src/controllers/impl/filters/InvertFilter.cpp index db582b84cc..5407c6dd1d 100644 --- a/libraries/controllers/src/controllers/impl/filters/InvertFilter.cpp +++ b/libraries/controllers/src/controllers/impl/filters/InvertFilter.cpp @@ -6,4 +6,10 @@ // See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html // -#include "InvertFilter.h" +// NOTE: we don't need to include this header unless/until we add additional symbols. +// By removing this header we prevent these warnings on windows: +// +// warning LNK4221: This object file does not define any previously undefined public symbols, +// so it will not be used by any link operation that consumes this library +// +//#include "InvertFilter.h"