From 6e9e11993c6bd599cbabd40b7c94ad220a8caed7 Mon Sep 17 00:00:00 2001 From: Dale Glass Date: Fri, 2 Apr 2021 00:04:46 +0200 Subject: [PATCH] Add missing override keywords. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes warnings like: /libraries/entities-renderer/src/RenderableTextEntityItem.h:47:18: warning: ‘virtual bool render::entities::TextEntityRenderer::needsRenderUpdate() const’ can be marked override [-Wsuggest-override] 47 | virtual bool needsRenderUpdate() const; | ^~~~~~~~~~~~~~~~~ --- .../entities-renderer/src/RenderableTextEntityItem.h | 2 +- libraries/networking/src/PacketReceiver.h | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/libraries/entities-renderer/src/RenderableTextEntityItem.h b/libraries/entities-renderer/src/RenderableTextEntityItem.h index b52eddaafe..0dea260763 100644 --- a/libraries/entities-renderer/src/RenderableTextEntityItem.h +++ b/libraries/entities-renderer/src/RenderableTextEntityItem.h @@ -44,7 +44,7 @@ protected: void onRemoveFromSceneTyped(const TypedEntityPointer& entity) override; private: - virtual bool needsRenderUpdate() const; + virtual bool needsRenderUpdate() const override; virtual void doRenderUpdateSynchronousTyped(const ScenePointer& scene, Transaction& transaction, const TypedEntityPointer& entity) override; virtual void doRenderUpdateAsynchronousTyped(const TypedEntityPointer& entity) override; virtual void doRender(RenderArgs* args) override; diff --git a/libraries/networking/src/PacketReceiver.h b/libraries/networking/src/PacketReceiver.h index 071638cda9..4d2f11360e 100644 --- a/libraries/networking/src/PacketReceiver.h +++ b/libraries/networking/src/PacketReceiver.h @@ -85,9 +85,9 @@ private: class UnsourcedListenerReference : public ListenerReference { public: inline UnsourcedListenerReference(T* target, void (T::*slot)(QSharedPointer)); - virtual bool invokeDirectly(const QSharedPointer& receivedMessagePointer, const QSharedPointer& sourceNode); - virtual bool isSourced() const { return false; } - virtual QObject* getObject() const { return _target; } + virtual bool invokeDirectly(const QSharedPointer& receivedMessagePointer, const QSharedPointer& sourceNode) override; + virtual bool isSourced() const override { return false; } + virtual QObject* getObject() const override { return _target; } private: QPointer _target; @@ -98,9 +98,9 @@ private: class SourcedListenerReference : public ListenerReference { public: inline SourcedListenerReference(T* target, void (T::*slot)(QSharedPointer, QSharedPointer)); - virtual bool invokeDirectly(const QSharedPointer& receivedMessagePointer, const QSharedPointer& sourceNode); - virtual bool isSourced() const { return true; } - virtual QObject* getObject() const { return _target; } + virtual bool invokeDirectly(const QSharedPointer& receivedMessagePointer, const QSharedPointer& sourceNode) override; + virtual bool isSourced() const override { return true; } + virtual QObject* getObject() const override { return _target; } private: QPointer _target;