Mirrors/overte-JulianGro
3
0
Fork 0
mirror of https://github.com/JulianGro/overte.git synced 2025-04-15 21:18:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Tried to add GLSL validation in scribe. Issues with determining the correct version...

Browse source
This commit is contained in:
Olivier Prat 2018-01-17 15:09:32 +01:00
parent 54690219e3
commit 157a229a4f
1 changed files with 34 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
tools/scribe/src/main.cpp
View file

@ -56,6 +56,7 @@ int main (int argc, char** argv) {
static const char* shaderCreateString[] = {
"Vertex", "Pixel", "Geometry"
};
std::string shaderStage{ "vert" };
for (int ii = 1; (mode != EXIT) && (ii < argc); ii++) {
inputs.push_back(argv[ii]);
@ -124,10 +125,13 @@ int main (int argc, char** argv) {
case GRAB_SHADER_TYPE:
{
if (inputs.back() == "frag") {
shaderStage = inputs.back();
type = FRAGMENT;
} else if (inputs.back() == "geom") {
shaderStage = inputs.back();
type = GEOMETRY;
} else if (inputs.back() == "vert") {
shaderStage = inputs.back();
type = VERTEX;
} else {
cerr << "Unrecognized shader type. Supported is vert, frag or geom" << endl;
@ -218,6 +222,36 @@ int main (int argc, char** argv) {
scribe->displayTree(cerr, level);
}
// This would be nice to implement but not sure how to handle GLSL version
#if 0
// Check if we need to validate the code
auto validatorPath = getenv("SCRIBE_VALIDATOR");
if (validatorPath) {
// Create temporary file with shader code
char tempFileNameStub[L_tmpnam];
tmpnam(tempFileNameStub);
std::string tempFileName{ tempFileNameStub };
tempFileName += ".";
tempFileName += shaderStage;
std::ofstream tempStream(tempFileName);
if (tempStream.is_open()) {
tempStream << destStringStream.str();
tempStream.close();
std::string validationCommand{ validatorPath };
validationCommand += " ";
validationCommand += tempFileName;
cout << validationCommand << endl;
auto returnCode = system(validationCommand.c_str());
if (returnCode != 0) {
cerr << "Scribe shader " << targetName << " validation error." << endl;
}
//remove(tempFileName.c_str());
} else {
cerr << "Scribe is unable to write shader " << targetName << " to temporary file for validation." << endl;
}
}
#endif
if (makeCPlusPlus) {
// Because there is a maximum size for literal strings declared in source we need to partition the
// full source string stream into pages that seems to be around that value...