Mirrors/overte-JulianGro
3
0
Fork 0
mirror of https://github.com/JulianGro/overte.git synced 2025-04-08 19:23:28 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improving the Factory registration

Browse source
This commit is contained in:
samcake 2015-10-14 10:47:49 -07:00
parent 3d5bf9aa1a
commit 1302b6a238
1 changed files with 17 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
libraries/controllers/src/controllers/Filter.h
View file

@ -75,24 +75,30 @@ namespace controller {
class Entry {
public:
virtual Filter* create() = 0;
virtual const std::string& getName() const = 0;
Entry() = default;
virtual ~Entry() = default;
};
template <class T> class ClassEntry {
template <class T, std::string name> class ClassEntry {
public:
virtual Filter* create() { return (Filter*) new T(); }
Filter* create() override { return (Filter*) new T(); }
const std::string& getName() const override {
return _name
};
ClassEntry() = default;
ClassEntry() : _name(name) {};
virtual ~ClassEntry() = default;
const std::string _name;
};
using EntryMap = std::map<std::string, std::shared_ptr<Entry>>;
void registerEntry(const std::string& name, const std::shared_ptr<Entry>& entry) {
void registerEntry(const std::shared_ptr<Entry>& entry) {
if (entry) {
_entries.insert(EntryMap::value_type(name, entry));
_entries.insert(EntryMap::value_type(entry->getName(), entry));
}
}
@ -115,7 +121,9 @@ namespace controller {
};
}
#define REGISTER_FILTER_CLASS(classEntry) static Filter::Factory::ClassEntry<classEntry> _factoryEntry;
#define REGISTER_FILTER_CLASS(classEntry, className) \
using FactoryEntry = Filter::Factory::ClassEntry<classEntry, className>;\
static FactoryEntry _factoryEntry;
namespace controller {
@ -150,7 +158,8 @@ namespace controller {
}
virtual bool parseParameters(const QJsonArray& parameters);
REGISTER_FILTER_CLASS(ScaleFilter);
// static Filter::Factory::ClassEntry<ScaleFilter, "scale"> _factoryEntry;
REGISTER_FILTER_CLASS(ScaleFilter, "scale");
private:
float _scale = 1.0f;
};