David Back
40fec8a318
reparent after duplication
2018-07-05 11:58:45 -07:00
David Back
2e70853ffc
Merge branch 'master' into editHandleMacFix
2018-07-05 09:51:56 -07:00
David Rowe
a642324a11
Fix oscillating positions as translate when snapping to grid
2018-07-05 11:58:48 +12:00
David Rowe
9709599c1a
Fix translation handle not following mouse at some view angles
2018-07-05 11:47:34 +12:00
David Rowe
94c097fc39
Fix entity y value jumping when translate with grid snapping enabled
2018-07-05 11:42:37 +12:00
David Rowe
b00d07b029
ESLint
2018-07-05 10:50:08 +12:00
David Back
afbe64ec11
missing bracket
2018-07-03 13:32:11 -07:00
David Back
2af0f05cb4
tabs
2018-07-03 12:40:19 -07:00
David Back
ed4d0f2577
early-out if event undefined
2018-07-03 12:39:41 -07:00
David Back
7b9341954f
Merge branch 'master' of https://github.com/highfidelity/hifi into editHandleToggleFix
2018-06-28 12:10:42 -07:00
David Back
05438f3b85
bad avatar collision merge
2018-06-25 15:26:54 -07:00
David Back
f65bc9b5ed
Merge branch 'master' of https://github.com/highfidelity/hifi into editHandleFixesImprovements
2018-06-25 15:22:07 -07:00
David Back
6fa191742c
Merge pull request #13390 from dback2/editHandleDebugWindowFix
...
Prevent edit press events when pointing at tablet or desktop windows
2018-06-25 11:11:37 -07:00
David Back
80adad7965
myAvatar constant
2018-06-22 13:52:43 -07:00
David Back
c019a4816f
CR changes + eslint fixes
2018-06-21 16:45:09 -07:00
David Back
ed56f09fcf
comment
2018-06-21 15:00:10 -07:00
David Back
37b35353d2
space
2018-06-21 14:48:37 -07:00
David Back
54145e0310
use previous pick ray when translate reaches end
2018-06-20 15:53:38 -07:00
David Back
7704e8c2a9
fix stretching too far, improve stretch sphere vs camera dist sizing
2018-06-20 14:47:41 -07:00
David Back
633be87473
fix stretch panel dimensions
2018-06-19 14:57:46 -07:00
David Back
61cbe84ae5
fix stretching below minimum still moving entity
2018-06-19 14:39:58 -07:00
David Back
5b699d1cd4
tabs
2018-06-18 16:14:46 -07:00
David Back
030e697945
fix toggling to world space
2018-06-18 15:55:55 -07:00
David Back
bb0b1cc4a4
no myAvatarIndex needed
2018-06-15 17:35:18 -07:00
David Back
d16b777977
tabs
2018-06-15 17:33:49 -07:00
David Back
6ef8206f3a
temp disable myAvatar collisions when stretching
2018-06-15 17:32:03 -07:00
David Back
cb9c255acd
Merge branch 'master' of https://github.com/highfidelity/hifi into editHandleCollision
2018-06-15 14:51:53 -07:00
David Back
bc06b88afc
tabs
2018-06-15 14:31:18 -07:00
David Back
9b33e6757f
prevent edit press events when pointing at desktop window or tablet
2018-06-15 14:29:47 -07:00
David Back
cde111d601
remove pointing at system overlay and overlay at point checks
2018-06-12 17:55:04 -07:00
David Back
d20d594ae5
use setCollisionEnabled for avatar collisions
2018-05-31 10:50:54 -07:00
Wayne Chen
34120da63f
re-adding toggleSpaceMode
2018-05-30 16:06:34 -07:00
David Rowe
6c3174ccf1
Make particle / light icon translate x-z when inside bounding box
2018-05-17 17:04:12 +12:00
David Rowe
801a4b9aba
Make laser click in sky deselect entity
2018-05-17 15:09:23 +12:00
David Rowe
1ccde9a1b2
Disable moving selection when camera is in inside bounding box
2018-05-06 20:53:20 +12:00
David Rowe
8fd972fce9
Don't disable lasering on particle or light entity icon when is selected
2018-05-06 20:23:49 +12:00
David Rowe
ed1391581e
Merge branch 'master' into 21863
2018-05-05 16:49:51 +12:00
David Rowe
ebd46f1861
Fix intermittent ability to select particle and light entities
2018-05-03 14:43:54 +12:00
David Rowe
5312c81a6f
Match style of surrounding code
2018-05-03 08:49:18 +12:00
David Rowe
4a96dc2fdc
Refactor
2018-05-03 08:48:17 +12:00
David Rowe
f27e363b68
Remove entity from list when it deletes; handle multiple deletions
2018-05-02 15:23:13 +12:00
Thijs Wenker
b741888d77
CR feedback (for real)
2018-04-17 20:31:30 +02:00
Thijs Wenker
91467b6059
CR feedback
2018-04-17 20:30:00 +02:00
Thijs Wenker
0aa0f53925
edit.js - remove ability to clone non-owned avatar-entities
2018-04-17 19:46:45 +02:00
John Conklin II
89127a06b3
Merge pull request #12714 from dback2/editUpDownArrowFix
...
Fix Y arrow translation handle issues
2018-04-04 13:46:31 -07:00
Seth Alves
249a97b5d0
don't move or rotate children if a parent is being changed by the same action
2018-04-03 12:14:59 -07:00
Seth Alves
08b7326bd1
when moving a group of selections, don't move a child if a parent is being moved
2018-04-03 12:14:40 -07:00
unknown
194b00d732
fix translate arrow normals
2018-03-26 16:31:58 -07:00
David Back
554c37d14b
removed undefined event checks in scaling
2018-03-07 19:34:08 -08:00
David Back
9681f0eb77
restore old scale math, disable avatar collisions while scaling
2018-03-07 18:20:26 -08:00
David Back
2047437893
Merge branch 'RC65' of https://github.com/highfidelity/hifi into RC65
2018-03-07 10:30:18 -08:00
David Back
47e8e26255
CR indent fixes
2018-03-06 14:05:24 -08:00
David Back
b74be92fd8
redo scale handles to fix scaling into avatar collision causing chaos
2018-03-06 12:27:51 -08:00
Elisa Lupin-Jimenez
15c1f5ba30
fixed log spam undefined error
2018-03-06 11:01:50 -08:00
Seth Alves
c534e3a6e4
Merge pull request #12356 from ctrlaltdavid/21742
...
Handle tablet entities and overlays not being available
2018-02-22 08:48:13 -08:00
Liv Erickson
175532c444
show outline for zones when rotating
2018-02-15 15:51:54 -08:00
David Rowe
b1f49be790
Merge branch 'master' into 21742
...
# Conflicts:
# scripts/system/libraries/entitySelectionTool.js
2018-02-13 10:04:32 +13:00
David Rowe
adb6f66a05
Handle tablet entities and overlays not being available
2018-02-08 09:51:48 +13:00
David Back
51b55aedcf
CR changes, fix colors, add minimum overlay dimensions for HMD
2018-02-06 16:07:46 -08:00
David Back
ececd1c60f
fix loop index change
2018-02-02 17:14:48 -08:00
David Back
ed4cbe2679
fix fill ring rotation
2018-02-02 17:05:25 -08:00
David Back
900669d937
fix multi-selection rotation yay!
2018-02-02 16:44:59 -08:00
David Back
55f55cd78b
few more updates
2018-02-01 17:59:38 -08:00
David Back
db56246cd6
more fixes, clean up, updates
2018-02-01 17:30:56 -08:00
David Back
c01790bd3e
punch list updates and various fixes
2018-01-31 18:27:15 -08:00
David Back
e679b75e99
fix degree display position
2018-01-29 19:02:36 -08:00
David Back
2f0d92c3cd
ctrl 22.5 snapping
2018-01-29 18:15:01 -08:00
David Back
9ee7153641
fix scale speed, fix stretch panels, fix scale cube highlight
2018-01-29 16:53:02 -08:00
David Back
c4359de859
entity edit tools wip update
2018-01-19 18:20:36 -08:00
David Back
26bf78fb5d
first pass new entity selection edit tools wip
2018-01-17 18:30:31 -08:00
Daniela
ef49aa0b71
Refactor to comply with code standard.
2017-11-29 18:54:08 +00:00
Daniela
8985acd8b6
YAW ROLL PITCH tool now represents angles in a usefull way. Refactoring.
2017-11-29 13:00:36 +00:00
Daniela
68d5d600b7
YAW ROLL PITCH tool gizmos + functionality
2017-11-28 23:16:34 +00:00
Daniela
eb0d925091
YAW ROLL PITCH tool gizmos + functionality
2017-11-28 22:55:09 +00:00
Daniela
123f898f80
Merge branch 'master' of https://github.com/highfidelity/hifi into Gizmos
2017-11-28 15:38:30 +00:00
luiscuenca
7dfdc8da59
Redesign and clean of unused lineWidths
2017-11-09 17:50:38 -07:00
Daniela
2ceba76ba2
yaw tool
2017-10-27 11:28:44 +01:00
Daniela
a1110bf28d
Rotations now happen using the correct axis taking into account the avatar referential
2017-10-26 16:52:58 +01:00
Daniela
f15038c54f
Re-add isFacingAvatar to true and delete rotation of the grabbermoveup tool.
2017-10-23 19:11:32 +01:00
Daniela
a02ee5b7d5
Grabber Tool Move up, remove billboard on grabbermoveupoverlay
2017-10-19 18:05:51 +01:00
Atlante45
6dd49f5c32
Merge branch 'stable' of https://github.com/highfidelity/hifi into new-master
2017-10-10 16:53:34 -07:00
LaShonda Hopper
2f082d9e86
[Case 6491] Fixes issue in normalizeDegrees from last commit (details below).
...
The range of the function is targeting (-180, 180] such that
the statement:
if (degrees < -180)
should be:
if (degrees <= -180)
to account for degrees being -180.
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-06 10:11:26 -04:00
LaShonda Hopper
707569b230
[Case 6491] More efficient version of normalizeDegrees function (details below).
...
Refactoring the original normalizeDegrees function to be
more efficient as suggested via:
https://github.com/highfidelity/hifi/pull/11338#pullrequestreview-67520585
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-06 09:50:24 -04:00
druiz17
347645329e
fixing laser staying on in edit mode
2017-10-05 09:11:02 -07:00
LaShonda Hopper
18d884f6c4
[Case 6491] eslint pass: Fixes no-multiple-empty-lines issues.
...
* eslint pass using .eslintrc.js
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-04 20:51:06 -04:00
LaShonda Hopper
e9ae2099f3
[Case 6491] eslint pass: Fixes indent issues.
...
* eslint pass using .eslintrc.js
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-04 20:37:57 -04:00
LaShonda Hopper
ac81b22cc9
[Case 6491] eslint pass: Fixes references to SelectionManager (details below).
...
SelectionManager was being referred to as selectionManager.
* eslint pass used .eslintrc.js
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-04 20:24:20 -04:00
LaShonda Hopper
a5b913a8b9
[Case 6491] Fixes minor spacing issue, on while loop missed previous eslint pass.
...
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-04 17:36:28 -04:00
LaShonda Hopper
cb264b5552
[Case 6491] eslint pass: Addresses curly bracket, keyword spacing issues.
...
* eslint pass using .eslintrc.js
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-02 13:28:43 -04:00
LaShonda Hopper
97ecf84f3d
[Case 6491] eslint pass: Cleaning up comma-dangle noise.
...
* eslint pass using .eslintrc.js
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-02 13:21:10 -04:00
LaShonda Hopper
c131686f1b
[Case 6491] eslint pass: Addressing some comment issues.
...
* This should reduces the noise for the eslint passes on this script.
* eslint pass using .eslintrc.js
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-02 12:55:51 -04:00
LaShonda Hopper
a610946af1
[Case 6491] eslint pass: fixes undefined center var in that.updateHandles.
...
* eslint pass using .eslintrc.js
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-02 12:31:10 -04:00
LaShonda Hopper
dbf8d19095
[Case 6491] eslint pass: fixes issues with equality checks.
...
* Also adds some paren grouping to help with readability of some statements.
* eslint pass on script using .eslintrc.js
Changes to be committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-10-02 12:26:00 -04:00
LaShonda Hopper
6571aef997
[Case 6491] makeStretchTool: Fix z undefined issue (details below).
...
z:z appears to have been a typo, as there's no var z. Should likely be z:1.
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-09-29 18:52:39 -04:00
LaShonda Hopper
ff051db79a
[Case 6491] Minor: Fixes some paren spacing.
...
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-09-28 15:06:09 -04:00
LaShonda Hopper
0deabf54ef
[Case 6491] Minor: fixes some coding standard spacing with wantDebug statements.
2017-09-28 15:04:28 -04:00
LaShonda Hopper
2bb76a357a
[Case 6491] Some adjustments to isActiveTool (details below).
...
* isActiveTool now respects null and undefined args.
* If null or undefined toolHandle is passed, activeTool
is directly tested against those values. Rather than
explicitly returning false.
* Added some clarification to unknown tool warning message.
Reviewed-by: Leander Hasty <leander@1stplayable.com>
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-09-28 15:04:28 -04:00
LaShonda Hopper
bed50dda2f
[Case 6491] Fixes consistency issue with lights (details below).
...
Fixes issue with light selection actions having inconsistent ui
in comparison to other selections from an earlier commit change.
As of this commit:
* When translating point lights, the edge grabbers are no longer be visible.
* When rotating or translating spot lights, the edge grabbers are no longer visible.
Note:
* For both point & spot lights, when translating and/or rotating, their circle
and/or radial guides should remain visible. This commit shouldn't have any
influence on that behavior.
Tested:
* Rotating and translating spot lights.
* Translating point lights. Didn't test rotation as only spot
lights support rotation.
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-09-28 15:04:28 -04:00
LaShonda Hopper
9fb76340c7
[Case 6491] removes SelectionDisplay.mode (details below).
...
This var isn't needed as the var essentially piggy backed
off of activeTool and activeTool.mode.
This also helps guard against the _majority_ of situations
where mode check fails due to typo inserted when composing
the check.
Most instances of manual string checks have been replaced by
querying activeTool via new isActiveTool function. For instances
that still require a direct mode check getMode will return
the mode string associated with the current activeTool.
TODO: Get this code reviewed.
2017-09-28 15:04:28 -04:00
LaShonda Hopper
3a174780c2
[Case 6491] Minor: Move that.updateHandleSizes up (details below).
...
It was down below the amidst the mouse event handlers. This just moves
it up with the other that.update handle functions definitions.
Changes Committed:
modified: scripts/system/libraries/entitySelectionTool.js
2017-09-28 15:04:28 -04:00