Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-08-09 15:20:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fail in Packet::create if size is invalid

Browse source
This commit is contained in:
Atlante45 2015-07-09 13:11:43 -07:00
parent e1fc242967
commit f90f3a05be
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
assignment-client/src/octree/OctreeQueryNode.h
View file

@ -14,7 +14,6 @@
#include <iostream> #include <iostream>
#include <CoverageMap.h> #include <CoverageMap.h>
#include <NodeData.h> #include <NodeData.h>
#include <OctreeConstants.h> #include <OctreeConstants.h>

7
libraries/networking/src/Packet.cpp
View file

@ -29,10 +29,9 @@ std::unique_ptr<Packet> Packet::create(PacketType::Value type, qint64 size) {
// default size of -1, means biggest packet possible // default size of -1, means biggest packet possible
size = maxPayload; size = maxPayload;
} }
if (size <= 0 || size > maxPayload) {
// Invalid size, return null pointer // Fail with invalid size
return std::unique_ptr<Packet>(); Q_ASSERT(size >= 0 || size < maxPayload);
}
// allocate memory // allocate memory
return std::unique_ptr<Packet>(new Packet(type, size)); return std::unique_ptr<Packet>(new Packet(type, size));