DRY up multiple stat type sending

This commit is contained in:
Stephen Birarda 2013-07-02 14:42:31 -07:00
parent 08c1d54cf3
commit f7f321663a
5 changed files with 9 additions and 25 deletions

View file

@ -138,7 +138,7 @@ int main(int argc, const char* argv[]) {
const char MIXER_LOGSTASH_METRIC_NAME[] = "audio-mixer-frame-time-usage";
float averageFrameTimePercentage = sumFrameTimePercentages / numStatCollections;
Logstash::stashGaugeValue(MIXER_LOGSTASH_METRIC_NAME, averageFrameTimePercentage);
Logstash::stashValue(STAT_TYPE_GAUGE, MIXER_LOGSTASH_METRIC_NAME, averageFrameTimePercentage);
sumFrameTimePercentages = 0.0f;
numStatCollections = 0;

View file

@ -181,7 +181,7 @@ int main(int argc, const char * argv[])
// time to send our count of agents and servers to logstash
const char NODE_COUNT_LOGSTASH_KEY[] = "ds-node-count";
Logstash::stashGaugeValue(NODE_COUNT_LOGSTASH_KEY, agentList->getNumAliveAgents());
Logstash::stashValue(STAT_TYPE_GAUGE, NODE_COUNT_LOGSTASH_KEY, agentList->getNumAliveAgents());
gettimeofday(&lastStatSendTime, NULL);
}

View file

@ -349,7 +349,7 @@ void Application::initializeGL() {
const char LOGSTASH_INTERFACE_START_TIME_KEY[] = "interface-start-time";
// ask the Logstash class to record the startup time
Logstash::stashTimerValue(LOGSTASH_INTERFACE_START_TIME_KEY, startupTime);
Logstash::stashValue(STAT_TYPE_TIMER, LOGSTASH_INTERFACE_START_TIME_KEY, startupTime);
}
// update before the first render

View file

@ -57,20 +57,4 @@ void Logstash::stashValue(char valueType, const char* key, float value) {
if (agentList) {
agentList->getAgentSocket()->send(socket(), logstashPacket, numPacketBytes);
}
}
void Logstash::stashTimerValue(const char* key, float value) {
const char STAT_TYPE_TIMER = 't';
stashValue(STAT_TYPE_TIMER, key, value);
}
void Logstash::stashCounterValue(const char* key, float value) {
const char STAT_TYPE_COUNTER = 'c';
stashValue(STAT_TYPE_COUNTER, key, value);
}
void Logstash::stashGaugeValue(const char* key, float value) {
const char STAT_TYPE_GAUGE = 'g';
stashValue(STAT_TYPE_GAUGE, key, value);
}
}

View file

@ -14,16 +14,16 @@
const int LOGSTASH_UDP_PORT = 9500;
const char LOGSTASH_HOSTNAME[] = "graphite.highfidelity.io";
const char STAT_TYPE_TIMER = 't';
const char STAT_TYPE_COUNTER = 'c';
const char STAT_TYPE_GAUGE = 'g';
class Logstash {
public:
static sockaddr* socket();
static bool shouldSendStats();
static void stashTimerValue(const char* key, float value);
static void stashCounterValue(const char* key, float value);
static void stashGaugeValue(const char* key, float value);
static void stashValue(char statType, const char* key, float value);
private:
static void stashValue(char valueType, const char* key, float value);
static sockaddr_in logstashSocket;
};