Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-08-04 04:24:47 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

Clarified comment on controller endpoint cleanup

Browse source
This commit is contained in:
ksuprynowicz 2023-07-22 12:47:15 +02:00 committed by GitHub
parent 790a55d093
commit f3732aaa62
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
interface/src/Application.cpp
View file

@ -7557,8 +7557,8 @@ void Application::registerScriptEngineWithApplicationServices(ScriptManagerPoint
// Request removal of controller routes with callbacks to a given script engine // Request removal of controller routes with callbacks to a given script engine
auto userInputMapper = DependencyManager::get<UserInputMapper>(); auto userInputMapper = DependencyManager::get<UserInputMapper>();
userInputMapper->scheduleScriptEndpointCleanup(scriptManager->engine().get()); userInputMapper->scheduleScriptEndpointCleanup(scriptManager->engine().get());
// V8TODO: Maybe we should wait until endpoint cleanup is finished before deleting the script engine if there are still crashes
QObject::disconnect(*connection); QObject::disconnect(*connection);
// V8TODO: Maybe we should wait until removal is finished if there are still crashes
}); });
} }