Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-04-29 21:52:14 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

move AddressManager to NodeList thread, fix AccountManager invokes

Browse source
This commit is contained in:
Stephen Birarda 2018-06-25 16:34:07 -07:00
parent e7d5ea561b
commit e90ea82ef5
24 changed files with 222 additions and 225 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
domain-server/src/DomainGatekeeper.cpp
View file

@ -675,19 +675,19 @@ void DomainGatekeeper::requestUserPublicKey(const QString& username, bool isOpti
QNetworkAccessManager::GetOperation, callbackParams); QNetworkAccessManager::GetOperation, callbackParams);
} }
QString extractUsernameFromPublicKeyRequest(QNetworkReply& requestReply) { QString extractUsernameFromPublicKeyRequest(QNetworkReply* requestReply) {
// extract the username from the request url // extract the username from the request url
QString username; QString username;
const QString PUBLIC_KEY_URL_REGEX_STRING = "api\\/v1\\/users\\/([A-Za-z0-9_\\.]+)\\/public_key"; const QString PUBLIC_KEY_URL_REGEX_STRING = "api\\/v1\\/users\\/([A-Za-z0-9_\\.]+)\\/public_key";
QRegExp usernameRegex(PUBLIC_KEY_URL_REGEX_STRING); QRegExp usernameRegex(PUBLIC_KEY_URL_REGEX_STRING);
if (usernameRegex.indexIn(requestReply.url().toString()) != -1) { if (usernameRegex.indexIn(requestReply->url().toString()) != -1) {
username = usernameRegex.cap(1); username = usernameRegex.cap(1);
} }
return username.toLower(); return username.toLower();
} }
void DomainGatekeeper::publicKeyJSONCallback(QNetworkReply& requestReply) { void DomainGatekeeper::publicKeyJSONCallback(QNetworkReply* requestReply) {
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
QString username = extractUsernameFromPublicKeyRequest(requestReply); QString username = extractUsernameFromPublicKeyRequest(requestReply);
bool isOptimisticKey = _inFlightPublicKeyRequests.take(username); bool isOptimisticKey = _inFlightPublicKeyRequests.take(username);
@ -707,8 +707,8 @@ void DomainGatekeeper::publicKeyJSONCallback(QNetworkReply& requestReply) {
} }
} }
void DomainGatekeeper::publicKeyJSONErrorCallback(QNetworkReply& requestReply) { void DomainGatekeeper::publicKeyJSONErrorCallback(QNetworkReply* requestReply) {
qDebug() << "publicKey api call failed:" << requestReply.error(); qDebug() << "publicKey api call failed:" << requestReply->error();
QString username = extractUsernameFromPublicKeyRequest(requestReply); QString username = extractUsernameFromPublicKeyRequest(requestReply);
_inFlightPublicKeyRequests.remove(username); _inFlightPublicKeyRequests.remove(username);
} }
@ -906,18 +906,18 @@ void DomainGatekeeper::getGroupMemberships(const QString& username) {
} }
QString extractUsernameFromGroupMembershipsReply(QNetworkReply& requestReply) { QString extractUsernameFromGroupMembershipsReply(QNetworkReply* requestReply) {
// extract the username from the request url // extract the username from the request url
QString username; QString username;
const QString GROUP_MEMBERSHIPS_URL_REGEX_STRING = "api\\/v1\\/groups\\/members\\/([A-Za-z0-9_\\.]+)"; const QString GROUP_MEMBERSHIPS_URL_REGEX_STRING = "api\\/v1\\/groups\\/members\\/([A-Za-z0-9_\\.]+)";
QRegExp usernameRegex(GROUP_MEMBERSHIPS_URL_REGEX_STRING); QRegExp usernameRegex(GROUP_MEMBERSHIPS_URL_REGEX_STRING);
if (usernameRegex.indexIn(requestReply.url().toString()) != -1) { if (usernameRegex.indexIn(requestReply->url().toString()) != -1) {
username = usernameRegex.cap(1); username = usernameRegex.cap(1);
} }
return username.toLower(); return username.toLower();
} }
void DomainGatekeeper::getIsGroupMemberJSONCallback(QNetworkReply& requestReply) { void DomainGatekeeper::getIsGroupMemberJSONCallback(QNetworkReply* requestReply) {
// { // {
// "data":{ // "data":{
// "username":"sethalves", // "username":"sethalves",
@ -934,7 +934,7 @@ void DomainGatekeeper::getIsGroupMemberJSONCallback(QNetworkReply& requestReply)
// "status":"success" // "status":"success"
// } // }
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
if (jsonObject["status"].toString() == "success") { if (jsonObject["status"].toString() == "success") {
QJsonObject data = jsonObject["data"].toObject(); QJsonObject data = jsonObject["data"].toObject();
QJsonObject groups = data["groups"].toObject(); QJsonObject groups = data["groups"].toObject();
@ -953,8 +953,8 @@ void DomainGatekeeper::getIsGroupMemberJSONCallback(QNetworkReply& requestReply)
_inFlightGroupMembershipsRequests.remove(extractUsernameFromGroupMembershipsReply(requestReply)); _inFlightGroupMembershipsRequests.remove(extractUsernameFromGroupMembershipsReply(requestReply));
} }
void DomainGatekeeper::getIsGroupMemberErrorCallback(QNetworkReply& requestReply) { void DomainGatekeeper::getIsGroupMemberErrorCallback(QNetworkReply* requestReply) {
qDebug() << "getIsGroupMember api call failed:" << requestReply.error(); qDebug() << "getIsGroupMember api call failed:" << requestReply->error();
_inFlightGroupMembershipsRequests.remove(extractUsernameFromGroupMembershipsReply(requestReply)); _inFlightGroupMembershipsRequests.remove(extractUsernameFromGroupMembershipsReply(requestReply));
} }
@ -974,7 +974,7 @@ void DomainGatekeeper::getDomainOwnerFriendsList() {
} }
void DomainGatekeeper::getDomainOwnerFriendsListJSONCallback(QNetworkReply& requestReply) { void DomainGatekeeper::getDomainOwnerFriendsListJSONCallback(QNetworkReply* requestReply) {
// { // {
// status: "success", // status: "success",
// data: { // data: {
@ -991,7 +991,7 @@ void DomainGatekeeper::getDomainOwnerFriendsListJSONCallback(QNetworkReply& requ
// ] // ]
// } // }
// } // }
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
if (jsonObject["status"].toString() == "success") { if (jsonObject["status"].toString() == "success") {
_domainOwnerFriends.clear(); _domainOwnerFriends.clear();
QJsonArray friends = jsonObject["data"].toObject()["friends"].toArray(); QJsonArray friends = jsonObject["data"].toObject()["friends"].toArray();
@ -1003,8 +1003,8 @@ void DomainGatekeeper::getDomainOwnerFriendsListJSONCallback(QNetworkReply& requ
} }
} }
void DomainGatekeeper::getDomainOwnerFriendsListErrorCallback(QNetworkReply& requestReply) { void DomainGatekeeper::getDomainOwnerFriendsListErrorCallback(QNetworkReply* requestReply) {
qDebug() << "getDomainOwnerFriendsList api call failed:" << requestReply.error(); qDebug() << "getDomainOwnerFriendsList api call failed:" << requestReply->error();
} }
void DomainGatekeeper::refreshGroupsCache() { void DomainGatekeeper::refreshGroupsCache() {

12
domain-server/src/DomainGatekeeper.h
View file

@ -51,14 +51,14 @@ public slots:
void processICEPingReplyPacket(QSharedPointer<ReceivedMessage> message); void processICEPingReplyPacket(QSharedPointer<ReceivedMessage> message);
void processICEPeerInformationPacket(QSharedPointer<ReceivedMessage> message); void processICEPeerInformationPacket(QSharedPointer<ReceivedMessage> message);
void publicKeyJSONCallback(QNetworkReply& requestReply); void publicKeyJSONCallback(QNetworkReply* requestReply);
void publicKeyJSONErrorCallback(QNetworkReply& requestReply); void publicKeyJSONErrorCallback(QNetworkReply* requestReply);
void getIsGroupMemberJSONCallback(QNetworkReply& requestReply); void getIsGroupMemberJSONCallback(QNetworkReply* requestReply);
void getIsGroupMemberErrorCallback(QNetworkReply& requestReply); void getIsGroupMemberErrorCallback(QNetworkReply* requestReply);
void getDomainOwnerFriendsListJSONCallback(QNetworkReply& requestReply); void getDomainOwnerFriendsListJSONCallback(QNetworkReply* requestReply);
void getDomainOwnerFriendsListErrorCallback(QNetworkReply& requestReply); void getDomainOwnerFriendsListErrorCallback(QNetworkReply* requestReply);
void refreshGroupsCache(); void refreshGroupsCache();

18
domain-server/src/DomainServer.cpp
View file

@ -519,8 +519,8 @@ void DomainServer::getTemporaryName(bool force) {
QNetworkAccessManager::PostOperation, callbackParameters); QNetworkAccessManager::PostOperation, callbackParameters);
} }
void DomainServer::handleTempDomainSuccess(QNetworkReply& requestReply) { void DomainServer::handleTempDomainSuccess(QNetworkReply* requestReply) {
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
// grab the information for the new domain // grab the information for the new domain
static const QString DATA_KEY = "data"; static const QString DATA_KEY = "data";
@ -565,7 +565,7 @@ void DomainServer::handleTempDomainSuccess(QNetworkReply& requestReply) {
} }
} }
void DomainServer::handleTempDomainError(QNetworkReply& requestReply) { void DomainServer::handleTempDomainError(QNetworkReply* requestReply) {
qWarning() << "A temporary name was requested but there was an error creating one. Please try again via domain-server relaunch" qWarning() << "A temporary name was requested but there was an error creating one. Please try again via domain-server relaunch"
<< "or from the domain-server settings."; << "or from the domain-server settings.";
} }
@ -1453,7 +1453,7 @@ void DomainServer::sendHeartbeatToMetaverse(const QString& networkAddress) {
domainUpdateJSON.toUtf8()); domainUpdateJSON.toUtf8());
} }
void DomainServer::handleMetaverseHeartbeatError(QNetworkReply& requestReply) { void DomainServer::handleMetaverseHeartbeatError(QNetworkReply* requestReply) {
if (!_metaverseHeartbeatTimer) { if (!_metaverseHeartbeatTimer) {
// avoid rehandling errors from the same issue // avoid rehandling errors from the same issue
return; return;
@ -1462,13 +1462,13 @@ void DomainServer::handleMetaverseHeartbeatError(QNetworkReply& requestReply) {
// only attempt to grab a new temporary name if we're already a temporary domain server // only attempt to grab a new temporary name if we're already a temporary domain server
if (_type == MetaverseTemporaryDomain) { if (_type == MetaverseTemporaryDomain) {
// check if we need to force a new temporary domain name // check if we need to force a new temporary domain name
switch (requestReply.error()) { switch (requestReply->error()) {
// if we have a temporary domain with a bad token, we get a 401 // if we have a temporary domain with a bad token, we get a 401
case QNetworkReply::NetworkError::AuthenticationRequiredError: { case QNetworkReply::NetworkError::AuthenticationRequiredError: {
static const QString DATA_KEY = "data"; static const QString DATA_KEY = "data";
static const QString TOKEN_KEY = "api_key"; static const QString TOKEN_KEY = "api_key";
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
auto tokenFailure = jsonObject[DATA_KEY].toObject()[TOKEN_KEY]; auto tokenFailure = jsonObject[DATA_KEY].toObject()[TOKEN_KEY];
if (!tokenFailure.isNull()) { if (!tokenFailure.isNull()) {
@ -1552,7 +1552,7 @@ void DomainServer::sendICEServerAddressToMetaverseAPI() {
domainUpdateJSON.toUtf8()); domainUpdateJSON.toUtf8());
} }
void DomainServer::handleSuccessfulICEServerAddressUpdate(QNetworkReply& requestReply) { void DomainServer::handleSuccessfulICEServerAddressUpdate(QNetworkReply* requestReply) {
_sendICEServerAddressToMetaverseAPIInProgress = false; _sendICEServerAddressToMetaverseAPIInProgress = false;
if (_sendICEServerAddressToMetaverseAPIRedo) { if (_sendICEServerAddressToMetaverseAPIRedo) {
qDebug() << "ice-server address updated with metaverse, but has since changed. redoing update..."; qDebug() << "ice-server address updated with metaverse, but has since changed. redoing update...";
@ -1563,7 +1563,7 @@ void DomainServer::handleSuccessfulICEServerAddressUpdate(QNetworkReply& request
} }
} }
void DomainServer::handleFailedICEServerAddressUpdate(QNetworkReply& requestReply) { void DomainServer::handleFailedICEServerAddressUpdate(QNetworkReply* requestReply) {
_sendICEServerAddressToMetaverseAPIInProgress = false; _sendICEServerAddressToMetaverseAPIInProgress = false;
if (_sendICEServerAddressToMetaverseAPIRedo) { if (_sendICEServerAddressToMetaverseAPIRedo) {
// if we have new data, retry right away, even though the previous attempt didn't go well. // if we have new data, retry right away, even though the previous attempt didn't go well.
@ -1573,7 +1573,7 @@ void DomainServer::handleFailedICEServerAddressUpdate(QNetworkReply& requestRepl
const int ICE_SERVER_UPDATE_RETRY_MS = 2 * 1000; const int ICE_SERVER_UPDATE_RETRY_MS = 2 * 1000;
qWarning() << "Failed to update ice-server address with High Fidelity Metaverse - error was" qWarning() << "Failed to update ice-server address with High Fidelity Metaverse - error was"
<< requestReply.errorString(); << requestReply->errorString();
qWarning() << "\tRe-attempting in" << ICE_SERVER_UPDATE_RETRY_MS / 1000 << "seconds"; qWarning() << "\tRe-attempting in" << ICE_SERVER_UPDATE_RETRY_MS / 1000 << "seconds";
QTimer::singleShot(ICE_SERVER_UPDATE_RETRY_MS, this, SLOT(sendICEServerAddressToMetaverseAPI())); QTimer::singleShot(ICE_SERVER_UPDATE_RETRY_MS, this, SLOT(sendICEServerAddressToMetaverseAPI()));

10
domain-server/src/DomainServer.h
View file

@ -108,10 +108,10 @@ private slots:
void sendHeartbeatToIceServer(); void sendHeartbeatToIceServer();
void handleConnectedNode(SharedNodePointer newNode); void handleConnectedNode(SharedNodePointer newNode);
void handleTempDomainSuccess(QNetworkReply& requestReply); void handleTempDomainSuccess(QNetworkReply* requestReply);
void handleTempDomainError(QNetworkReply& requestReply); void handleTempDomainError(QNetworkReply* requestReply);
void handleMetaverseHeartbeatError(QNetworkReply& requestReply); void handleMetaverseHeartbeatError(QNetworkReply* requestReply);
void queuedQuit(QString quitMessage, int exitCode); void queuedQuit(QString quitMessage, int exitCode);
@ -121,8 +121,8 @@ private slots:
void handleICEHostInfo(const QHostInfo& hostInfo); void handleICEHostInfo(const QHostInfo& hostInfo);
void sendICEServerAddressToMetaverseAPI(); void sendICEServerAddressToMetaverseAPI();
void handleSuccessfulICEServerAddressUpdate(QNetworkReply& requestReply); void handleSuccessfulICEServerAddressUpdate(QNetworkReply* requestReply);
void handleFailedICEServerAddressUpdate(QNetworkReply& requestReply); void handleFailedICEServerAddressUpdate(QNetworkReply* requestReply);
void updateReplicatedNodes(); void updateReplicatedNodes();
void updateDownstreamNodes(); void updateDownstreamNodes();

16
domain-server/src/DomainServerSettingsManager.cpp
View file

@ -1826,7 +1826,7 @@ void DomainServerSettingsManager::apiGetGroupID(const QString& groupName) {
QNetworkAccessManager::GetOperation, callbackParams); QNetworkAccessManager::GetOperation, callbackParams);
} }
void DomainServerSettingsManager::apiGetGroupIDJSONCallback(QNetworkReply& requestReply) { void DomainServerSettingsManager::apiGetGroupIDJSONCallback(QNetworkReply* requestReply) {
// { // {
// "data":{ // "data":{
// "groups":[{ // "groups":[{
@ -1857,7 +1857,7 @@ void DomainServerSettingsManager::apiGetGroupIDJSONCallback(QNetworkReply& reque
// }, // },
// "status":"success" // "status":"success"
// } // }
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
if (jsonObject["status"].toString() == "success") { if (jsonObject["status"].toString() == "success") {
QJsonArray groups = jsonObject["data"].toObject()["groups"].toArray(); QJsonArray groups = jsonObject["data"].toObject()["groups"].toArray();
for (int i = 0; i < groups.size(); i++) { for (int i = 0; i < groups.size(); i++) {
@ -1876,8 +1876,8 @@ void DomainServerSettingsManager::apiGetGroupIDJSONCallback(QNetworkReply& reque
} }
} }
void DomainServerSettingsManager::apiGetGroupIDErrorCallback(QNetworkReply& requestReply) { void DomainServerSettingsManager::apiGetGroupIDErrorCallback(QNetworkReply* requestReply) {
qDebug() << "******************** getGroupID api call failed:" << requestReply.error(); qDebug() << "******************** getGroupID api call failed:" << requestReply->error();
} }
void DomainServerSettingsManager::apiGetGroupRanks(const QUuid& groupID) { void DomainServerSettingsManager::apiGetGroupRanks(const QUuid& groupID) {
@ -1893,7 +1893,7 @@ void DomainServerSettingsManager::apiGetGroupRanks(const QUuid& groupID) {
QNetworkAccessManager::GetOperation, callbackParams); QNetworkAccessManager::GetOperation, callbackParams);
} }
void DomainServerSettingsManager::apiGetGroupRanksJSONCallback(QNetworkReply& requestReply) { void DomainServerSettingsManager::apiGetGroupRanksJSONCallback(QNetworkReply* requestReply) {
// { // {
// "data":{ // "data":{
// "groups":{ // "groups":{
@ -1926,7 +1926,7 @@ void DomainServerSettingsManager::apiGetGroupRanksJSONCallback(QNetworkReply& re
// } // }
bool changed = false; bool changed = false;
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
if (jsonObject["status"].toString() == "success") { if (jsonObject["status"].toString() == "success") {
QJsonObject groups = jsonObject["data"].toObject()["groups"].toObject(); QJsonObject groups = jsonObject["data"].toObject()["groups"].toObject();
@ -1972,8 +1972,8 @@ void DomainServerSettingsManager::apiGetGroupRanksJSONCallback(QNetworkReply& re
} }
} }
void DomainServerSettingsManager::apiGetGroupRanksErrorCallback(QNetworkReply& requestReply) { void DomainServerSettingsManager::apiGetGroupRanksErrorCallback(QNetworkReply* requestReply) {
qDebug() << "******************** getGroupRanks api call failed:" << requestReply.error(); qDebug() << "******************** getGroupRanks api call failed:" << requestReply->error();
} }
void DomainServerSettingsManager::recordGroupMembership(const QString& name, const QUuid groupID, QUuid rankID) { void DomainServerSettingsManager::recordGroupMembership(const QString& name, const QUuid groupID, QUuid rankID) {

8
domain-server/src/DomainServerSettingsManager.h
View file

@ -133,10 +133,10 @@ signals:
void settingsUpdated(); void settingsUpdated();
public slots: public slots:
void apiGetGroupIDJSONCallback(QNetworkReply& requestReply); void apiGetGroupIDJSONCallback(QNetworkReply* requestReply);
void apiGetGroupIDErrorCallback(QNetworkReply& requestReply); void apiGetGroupIDErrorCallback(QNetworkReply* requestReply);
void apiGetGroupRanksJSONCallback(QNetworkReply& requestReply); void apiGetGroupRanksJSONCallback(QNetworkReply* requestReply);
void apiGetGroupRanksErrorCallback(QNetworkReply& requestReply); void apiGetGroupRanksErrorCallback(QNetworkReply* requestReply);
private slots: private slots:
void processSettingsRequestPacket(QSharedPointer<ReceivedMessage> message); void processSettingsRequestPacket(QSharedPointer<ReceivedMessage> message);

7
interface/src/Application.cpp
View file

@ -1081,6 +1081,11 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo
auto nodeList = DependencyManager::get<NodeList>(); auto nodeList = DependencyManager::get<NodeList>();
nodeList->startThread(); nodeList->startThread();
// move the AddressManager to the NodeList thread so that domain resets due to domain changes always occur
// before we tell MyAvatar to go to a new location in the new domain
auto addressManager = DependencyManager::get<AddressManager>();
addressManager->moveToThread(nodeList->thread());
const char** constArgv = const_cast<const char**>(argv); const char** constArgv = const_cast<const char**>(argv);
if (cmdOptionExists(argc, constArgv, "--disableWatchdog")) { if (cmdOptionExists(argc, constArgv, "--disableWatchdog")) {
DISABLE_WATCHDOG = true; DISABLE_WATCHDOG = true;
@ -1231,8 +1236,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo
accountManager->setIsAgent(true); accountManager->setIsAgent(true);
accountManager->setAuthURL(NetworkingConstants::METAVERSE_SERVER_URL()); accountManager->setAuthURL(NetworkingConstants::METAVERSE_SERVER_URL());
auto addressManager = DependencyManager::get<AddressManager>();
// use our MyAvatar position and quat for address manager path // use our MyAvatar position and quat for address manager path
addressManager->setPositionGetter([this]{ return getMyAvatar()->getWorldPosition(); }); addressManager->setPositionGetter([this]{ return getMyAvatar()->getWorldPosition(); });
addressManager->setOrientationGetter([this]{ return getMyAvatar()->getWorldOrientation(); }); addressManager->setOrientationGetter([this]{ return getMyAvatar()->getWorldOrientation(); });

2
interface/src/DiscoverabilityManager.cpp
View file

@ -136,7 +136,7 @@ void DiscoverabilityManager::updateLocation() {
setCrashAnnotation("address", currentAddress.toString().toStdString()); setCrashAnnotation("address", currentAddress.toString().toStdString());
} }
void DiscoverabilityManager::handleHeartbeatResponse(QNetworkReply& requestReply) { void DiscoverabilityManager::handleHeartbeatResponse(QNetworkReply* requestReply) {
auto dataObject = AccountManager::dataObjectFromResponse(requestReply); auto dataObject = AccountManager::dataObjectFromResponse(requestReply);
if (!dataObject.isEmpty()) { if (!dataObject.isEmpty()) {

2
interface/src/DiscoverabilityManager.h
View file

@ -51,7 +51,7 @@ public:
static QString findableByString(Discoverability::Mode discoverabilityMode); static QString findableByString(Discoverability::Mode discoverabilityMode);
private slots: private slots:
void handleHeartbeatResponse(QNetworkReply& requestReply); void handleHeartbeatResponse(QNetworkReply* requestReply);
private: private:
DiscoverabilityManager(); DiscoverabilityManager();

34
interface/src/commerce/Ledger.cpp
View file

@ -28,15 +28,15 @@
// account synthesizes a result {status: 'success', data: {keyStatus: "preexisting"|"conflicting"|"ok"}} // account synthesizes a result {status: 'success', data: {keyStatus: "preexisting"|"conflicting"|"ok"}}
QJsonObject Ledger::apiResponse(const QString& label, QNetworkReply& reply) { QJsonObject Ledger::apiResponse(const QString& label, QNetworkReply* reply) {
QByteArray response = reply.readAll(); QByteArray response = reply->readAll();
QJsonObject data = QJsonDocument::fromJson(response).object(); QJsonObject data = QJsonDocument::fromJson(response).object();
qInfo(commerce) << label << "response" << QJsonDocument(data).toJson(QJsonDocument::Compact); qInfo(commerce) << label << "response" << QJsonDocument(data).toJson(QJsonDocument::Compact);
return data; return data;
} }
// Non-200 responses are not json: // Non-200 responses are not json:
QJsonObject Ledger::failResponse(const QString& label, QNetworkReply& reply) { QJsonObject Ledger::failResponse(const QString& label, QNetworkReply* reply) {
QString response = reply.readAll(); QString response = reply->readAll();
qWarning(commerce) << "FAILED" << label << response; qWarning(commerce) << "FAILED" << label << response;
// tempResult will be NULL if the response isn't valid JSON. // tempResult will be NULL if the response isn't valid JSON.
@ -52,8 +52,8 @@ QJsonObject Ledger::failResponse(const QString& label, QNetworkReply& reply) {
return tempResult.object(); return tempResult.object();
} }
} }
#define ApiHandler(NAME) void Ledger::NAME##Success(QNetworkReply& reply) { emit NAME##Result(apiResponse(#NAME, reply)); } #define ApiHandler(NAME) void Ledger::NAME##Success(QNetworkReply* reply) { emit NAME##Result(apiResponse(#NAME, reply)); }
#define FailHandler(NAME) void Ledger::NAME##Failure(QNetworkReply& reply) { emit NAME##Result(failResponse(#NAME, reply)); } #define FailHandler(NAME) void Ledger::NAME##Failure(QNetworkReply* reply) { emit NAME##Result(failResponse(#NAME, reply)); }
#define Handler(NAME) ApiHandler(NAME) FailHandler(NAME) #define Handler(NAME) ApiHandler(NAME) FailHandler(NAME)
Handler(buy) Handler(buy)
Handler(receiveAt) Handler(receiveAt)
@ -223,12 +223,12 @@ QString transactionString(const QJsonObject& valueObject) {
} }
static const QString MARKETPLACE_ITEMS_BASE_URL = NetworkingConstants::METAVERSE_SERVER_URL().toString() + "/marketplace/items/"; static const QString MARKETPLACE_ITEMS_BASE_URL = NetworkingConstants::METAVERSE_SERVER_URL().toString() + "/marketplace/items/";
void Ledger::historySuccess(QNetworkReply& reply) { void Ledger::historySuccess(QNetworkReply* reply) {
// here we send a historyResult with some extra stuff in it // here we send a historyResult with some extra stuff in it
// Namely, the styled text we'd like to show. The issue is the // Namely, the styled text we'd like to show. The issue is the
// QML cannot do that easily since it doesn't know what the wallet // QML cannot do that easily since it doesn't know what the wallet
// public key(s) are. Let's keep it that way // public key(s) are. Let's keep it that way
QByteArray response = reply.readAll(); QByteArray response = reply->readAll();
QJsonObject data = QJsonDocument::fromJson(response).object(); QJsonObject data = QJsonDocument::fromJson(response).object();
qInfo(commerce) << "history" << "response" << QJsonDocument(data).toJson(QJsonDocument::Compact); qInfo(commerce) << "history" << "response" << QJsonDocument(data).toJson(QJsonDocument::Compact);
@ -262,7 +262,7 @@ void Ledger::historySuccess(QNetworkReply& reply) {
emit historyResult(newData); emit historyResult(newData);
} }
void Ledger::historyFailure(QNetworkReply& reply) { void Ledger::historyFailure(QNetworkReply* reply) {
failResponse("history", reply); failResponse("history", reply);
} }
@ -273,10 +273,10 @@ void Ledger::history(const QStringList& keys, const int& pageNumber, const int&
keysQuery("history", "historySuccess", "historyFailure", params); keysQuery("history", "historySuccess", "historyFailure", params);
} }
void Ledger::accountSuccess(QNetworkReply& reply) { void Ledger::accountSuccess(QNetworkReply* reply) {
// lets set the appropriate stuff in the wallet now // lets set the appropriate stuff in the wallet now
auto wallet = DependencyManager::get<Wallet>(); auto wallet = DependencyManager::get<Wallet>();
QByteArray response = reply.readAll(); QByteArray response = reply->readAll();
QJsonObject data = QJsonDocument::fromJson(response).object()["data"].toObject(); QJsonObject data = QJsonDocument::fromJson(response).object()["data"].toObject();
auto salt = QByteArray::fromBase64(data["salt"].toString().toUtf8()); auto salt = QByteArray::fromBase64(data["salt"].toString().toUtf8());
@ -312,7 +312,7 @@ void Ledger::accountSuccess(QNetworkReply& reply) {
emit accountResult(responseData); emit accountResult(responseData);
} }
void Ledger::accountFailure(QNetworkReply& reply) { void Ledger::accountFailure(QNetworkReply* reply) {
failResponse("account", reply); failResponse("account", reply);
} }
void Ledger::account() { void Ledger::account() {
@ -320,8 +320,8 @@ void Ledger::account() {
} }
// The api/failResponse is called just for the side effect of logging. // The api/failResponse is called just for the side effect of logging.
void Ledger::updateLocationSuccess(QNetworkReply& reply) { apiResponse("updateLocation", reply); } void Ledger::updateLocationSuccess(QNetworkReply* reply) { apiResponse("updateLocation", reply); }
void Ledger::updateLocationFailure(QNetworkReply& reply) { failResponse("updateLocation", reply); } void Ledger::updateLocationFailure(QNetworkReply* reply) { failResponse("updateLocation", reply); }
void Ledger::updateLocation(const QString& asset_id, const QString& location, const bool& alsoUpdateSiblings, const bool controlledFailure) { void Ledger::updateLocation(const QString& asset_id, const QString& location, const bool& alsoUpdateSiblings, const bool controlledFailure) {
auto wallet = DependencyManager::get<Wallet>(); auto wallet = DependencyManager::get<Wallet>();
auto walletScriptingInterface = DependencyManager::get<WalletScriptingInterface>(); auto walletScriptingInterface = DependencyManager::get<WalletScriptingInterface>();
@ -349,11 +349,11 @@ void Ledger::updateLocation(const QString& asset_id, const QString& location, co
} }
} }
void Ledger::certificateInfoSuccess(QNetworkReply& reply) { void Ledger::certificateInfoSuccess(QNetworkReply* reply) {
auto wallet = DependencyManager::get<Wallet>(); auto wallet = DependencyManager::get<Wallet>();
auto accountManager = DependencyManager::get<AccountManager>(); auto accountManager = DependencyManager::get<AccountManager>();
QByteArray response = reply.readAll(); QByteArray response = reply->readAll();
QJsonObject replyObject = QJsonDocument::fromJson(response).object(); QJsonObject replyObject = QJsonDocument::fromJson(response).object();
QStringList keys = wallet->listPublicKeys(); QStringList keys = wallet->listPublicKeys();
@ -366,7 +366,7 @@ void Ledger::certificateInfoSuccess(QNetworkReply& reply) {
qInfo(commerce) << "certificateInfo" << "response" << QJsonDocument(replyObject).toJson(QJsonDocument::Compact); qInfo(commerce) << "certificateInfo" << "response" << QJsonDocument(replyObject).toJson(QJsonDocument::Compact);
emit certificateInfoResult(replyObject); emit certificateInfoResult(replyObject);
} }
void Ledger::certificateInfoFailure(QNetworkReply& reply) { void Ledger::certificateInfoFailure(QNetworkReply* reply) {
emit certificateInfoResult(failResponse("certificateInfo", reply)); emit certificateInfoResult(failResponse("certificateInfo", reply));
} }
void Ledger::certificateInfo(const QString& certificateId) { void Ledger::certificateInfo(const QString& certificateId) {

56
interface/src/commerce/Ledger.h
View file

@ -65,36 +65,36 @@ signals:
void updateCertificateStatus(const QString& certID, uint certStatus); void updateCertificateStatus(const QString& certID, uint certStatus);
public slots: public slots:
void buySuccess(QNetworkReply& reply); void buySuccess(QNetworkReply* reply);
void buyFailure(QNetworkReply& reply); void buyFailure(QNetworkReply* reply);
void receiveAtSuccess(QNetworkReply& reply); void receiveAtSuccess(QNetworkReply* reply);
void receiveAtFailure(QNetworkReply& reply); void receiveAtFailure(QNetworkReply* reply);
void balanceSuccess(QNetworkReply& reply); void balanceSuccess(QNetworkReply* reply);
void balanceFailure(QNetworkReply& reply); void balanceFailure(QNetworkReply* reply);
void inventorySuccess(QNetworkReply& reply); void inventorySuccess(QNetworkReply* reply);
void inventoryFailure(QNetworkReply& reply); void inventoryFailure(QNetworkReply* reply);
void historySuccess(QNetworkReply& reply); void historySuccess(QNetworkReply* reply);
void historyFailure(QNetworkReply& reply); void historyFailure(QNetworkReply* reply);
void accountSuccess(QNetworkReply& reply); void accountSuccess(QNetworkReply* reply);
void accountFailure(QNetworkReply& reply); void accountFailure(QNetworkReply* reply);
void updateLocationSuccess(QNetworkReply& reply); void updateLocationSuccess(QNetworkReply* reply);
void updateLocationFailure(QNetworkReply& reply); void updateLocationFailure(QNetworkReply* reply);
void certificateInfoSuccess(QNetworkReply& reply); void certificateInfoSuccess(QNetworkReply* reply);
void certificateInfoFailure(QNetworkReply& reply); void certificateInfoFailure(QNetworkReply* reply);
void transferAssetToNodeSuccess(QNetworkReply& reply); void transferAssetToNodeSuccess(QNetworkReply* reply);
void transferAssetToNodeFailure(QNetworkReply& reply); void transferAssetToNodeFailure(QNetworkReply* reply);
void transferAssetToUsernameSuccess(QNetworkReply& reply); void transferAssetToUsernameSuccess(QNetworkReply* reply);
void transferAssetToUsernameFailure(QNetworkReply& reply); void transferAssetToUsernameFailure(QNetworkReply* reply);
void alreadyOwnedSuccess(QNetworkReply& reply); void alreadyOwnedSuccess(QNetworkReply* reply);
void alreadyOwnedFailure(QNetworkReply& reply); void alreadyOwnedFailure(QNetworkReply* reply);
void availableUpdatesSuccess(QNetworkReply& reply); void availableUpdatesSuccess(QNetworkReply* reply);
void availableUpdatesFailure(QNetworkReply& reply); void availableUpdatesFailure(QNetworkReply* reply);
void updateItemSuccess(QNetworkReply& reply); void updateItemSuccess(QNetworkReply* reply);
void updateItemFailure(QNetworkReply& reply); void updateItemFailure(QNetworkReply* reply);
private: private:
QJsonObject apiResponse(const QString& label, QNetworkReply& reply); QJsonObject apiResponse(const QString& label, QNetworkReply* reply);
QJsonObject failResponse(const QString& label, QNetworkReply& reply); QJsonObject failResponse(const QString& label, QNetworkReply* reply);
void send(const QString& endpoint, const QString& success, const QString& fail, QNetworkAccessManager::Operation method, AccountManagerAuth::Type authType, QJsonObject request); void send(const QString& endpoint, const QString& success, const QString& fail, QNetworkAccessManager::Operation method, AccountManagerAuth::Type authType, QJsonObject request);
void keysQuery(const QString& endpoint, const QString& success, const QString& fail, QJsonObject& extraRequestParams); void keysQuery(const QString& endpoint, const QString& success, const QString& fail, QJsonObject& extraRequestParams);
void keysQuery(const QString& endpoint, const QString& success, const QString& fail); void keysQuery(const QString& endpoint, const QString& success, const QString& fail);

18
interface/src/ui/LoginDialog.cpp
View file

@ -185,20 +185,20 @@ void LoginDialog::openUrl(const QString& url) const {
} }
} }
void LoginDialog::linkCompleted(QNetworkReply& reply) { void LoginDialog::linkCompleted(QNetworkReply* reply) {
emit handleLinkCompleted(); emit handleLinkCompleted();
} }
void LoginDialog::linkFailed(QNetworkReply& reply) { void LoginDialog::linkFailed(QNetworkReply* reply) {
emit handleLinkFailed(reply.errorString()); emit handleLinkFailed(reply->errorString());
} }
void LoginDialog::createCompleted(QNetworkReply& reply) { void LoginDialog::createCompleted(QNetworkReply* reply) {
emit handleCreateCompleted(); emit handleCreateCompleted();
} }
void LoginDialog::createFailed(QNetworkReply& reply) { void LoginDialog::createFailed(QNetworkReply* reply) {
emit handleCreateFailed(reply.errorString()); emit handleCreateFailed(reply->errorString());
} }
void LoginDialog::signup(const QString& email, const QString& username, const QString& password) { void LoginDialog::signup(const QString& email, const QString& username, const QString& password) {
@ -228,7 +228,7 @@ void LoginDialog::signup(const QString& email, const QString& username, const QS
QJsonDocument(payload).toJson()); QJsonDocument(payload).toJson());
} }
void LoginDialog::signupCompleted(QNetworkReply& reply) { void LoginDialog::signupCompleted(QNetworkReply* reply) {
emit handleSignupCompleted(); emit handleSignupCompleted();
} }
@ -242,10 +242,10 @@ QString errorStringFromAPIObject(const QJsonValue& apiObject) {
} }
} }
void LoginDialog::signupFailed(QNetworkReply& reply) { void LoginDialog::signupFailed(QNetworkReply* reply) {
// parse the returned JSON to see what the problem was // parse the returned JSON to see what the problem was
auto jsonResponse = QJsonDocument::fromJson(reply.readAll()); auto jsonResponse = QJsonDocument::fromJson(reply->readAll());
static const QString RESPONSE_DATA_KEY = "data"; static const QString RESPONSE_DATA_KEY = "data";

12
interface/src/ui/LoginDialog.h
View file

@ -42,14 +42,14 @@ signals:
void handleSignupFailed(QString errorString); void handleSignupFailed(QString errorString);
public slots: public slots:
void linkCompleted(QNetworkReply& reply); void linkCompleted(QNetworkReply* reply);
void linkFailed(QNetworkReply& reply); void linkFailed(QNetworkReply* reply);
void createCompleted(QNetworkReply& reply); void createCompleted(QNetworkReply* reply);
void createFailed(QNetworkReply& reply); void createFailed(QNetworkReply* reply);
void signupCompleted(QNetworkReply& reply); void signupCompleted(QNetworkReply* reply);
void signupFailed(QNetworkReply& reply); void signupFailed(QNetworkReply* reply);
protected slots: protected slots:
Q_INVOKABLE bool isSteamRunning() const; Q_INVOKABLE bool isSteamRunning() const;

24
interface/src/ui/SnapshotUploader.cpp
View file

@ -23,11 +23,11 @@ SnapshotUploader::SnapshotUploader(QUrl inWorldLocation, QString pathname) :
_pathname(pathname) { _pathname(pathname) {
} }
void SnapshotUploader::uploadSuccess(QNetworkReply& reply) { void SnapshotUploader::uploadSuccess(QNetworkReply* reply) {
const QString STORY_UPLOAD_URL = "/api/v1/user_stories"; const QString STORY_UPLOAD_URL = "/api/v1/user_stories";
// parse the reply for the thumbnail_url // parse the reply for the thumbnail_url
QByteArray contents = reply.readAll(); QByteArray contents = reply->readAll();
QJsonParseError jsonError; QJsonParseError jsonError;
auto doc = QJsonDocument::fromJson(contents, &jsonError); auto doc = QJsonDocument::fromJson(contents, &jsonError);
if (jsonError.error == QJsonParseError::NoError) { if (jsonError.error == QJsonParseError::NoError) {
@ -74,11 +74,11 @@ void SnapshotUploader::uploadSuccess(QNetworkReply& reply) {
} }
} }
void SnapshotUploader::uploadFailure(QNetworkReply& reply) { void SnapshotUploader::uploadFailure(QNetworkReply* reply) {
QString replyString = reply.readAll(); QString replyString = reply->readAll();
qDebug() << "Error " << reply.errorString() << " uploading snapshot " << _pathname << " from " << _inWorldLocation; qDebug() << "Error " << reply->errorString() << " uploading snapshot " << _pathname << " from " << _inWorldLocation;
if (replyString.size() == 0) { if (replyString.size() == 0) {
replyString = reply.errorString(); replyString = reply->errorString();
} }
replyString = replyString.left(1000); // Only print first 1000 characters of error replyString = replyString.left(1000); // Only print first 1000 characters of error
qDebug() << "Snapshot upload reply error (truncated):" << replyString; qDebug() << "Snapshot upload reply error (truncated):" << replyString;
@ -86,17 +86,17 @@ void SnapshotUploader::uploadFailure(QNetworkReply& reply) {
this->deleteLater(); this->deleteLater();
} }
void SnapshotUploader::createStorySuccess(QNetworkReply& reply) { void SnapshotUploader::createStorySuccess(QNetworkReply* reply) {
QString replyString = reply.readAll(); QString replyString = reply->readAll();
emit DependencyManager::get<WindowScriptingInterface>()->snapshotShared(false, replyString); emit DependencyManager::get<WindowScriptingInterface>()->snapshotShared(false, replyString);
this->deleteLater(); this->deleteLater();
} }
void SnapshotUploader::createStoryFailure(QNetworkReply& reply) { void SnapshotUploader::createStoryFailure(QNetworkReply* reply) {
QString replyString = reply.readAll(); QString replyString = reply->readAll();
qDebug() << "Error " << reply.errorString() << " uploading snapshot story " << _pathname << " from " << _inWorldLocation; qDebug() << "Error " << reply->errorString() << " uploading snapshot story " << _pathname << " from " << _inWorldLocation;
if (replyString.size() == 0) { if (replyString.size() == 0) {
replyString = reply.errorString(); replyString = reply->errorString();
} }
replyString = replyString.left(1000); // Only print first 1000 characters of error replyString = replyString.left(1000); // Only print first 1000 characters of error
qDebug() << "Snapshot story upload reply error (truncated):" << replyString; qDebug() << "Snapshot story upload reply error (truncated):" << replyString;

10
interface/src/ui/SnapshotUploader.h
View file

@ -21,12 +21,12 @@ class SnapshotUploader : public QObject {
public: public:
SnapshotUploader(QUrl inWorldLocation, QString pathname); SnapshotUploader(QUrl inWorldLocation, QString pathname);
public slots: public slots:
void uploadSuccess(QNetworkReply& reply); void uploadSuccess(QNetworkReply* reply);
void uploadFailure(QNetworkReply& reply); void uploadFailure(QNetworkReply* reply);
void createStorySuccess(QNetworkReply& reply); void createStorySuccess(QNetworkReply* reply);
void createStoryFailure(QNetworkReply& reply); void createStoryFailure(QNetworkReply* reply);
private: private:
QUrl _inWorldLocation; QUrl _inWorldLocation;
QString _pathname; QString _pathname;
}; };
#endif // hifi_SnapshotUploader_h #endif // hifi_SnapshotUploader_h

131
libraries/networking/src/AccountManager.cpp
View file

@ -25,6 +25,7 @@
#include <QtCore/QThreadPool> #include <QtCore/QThreadPool>
#include <QtNetwork/QHttpMultiPart> #include <QtNetwork/QHttpMultiPart>
#include <QtNetwork/QNetworkRequest> #include <QtNetwork/QNetworkRequest>
#include <QtNetwork/QNetworkReply>
#include <qthread.h> #include <qthread.h>
#include <SettingHandle.h> #include <SettingHandle.h>
@ -53,14 +54,14 @@ JSONCallbackParameters::JSONCallbackParameters(QObject* jsonCallbackReceiver, co
jsonCallbackMethod(jsonCallbackMethod), jsonCallbackMethod(jsonCallbackMethod),
errorCallbackReceiver(errorCallbackReceiver), errorCallbackReceiver(errorCallbackReceiver),
errorCallbackMethod(errorCallbackMethod), errorCallbackMethod(errorCallbackMethod),
updateReciever(updateReceiver), updateReceiver(updateReceiver),
updateSlot(updateSlot) updateSlot(updateSlot)
{ {
} }
QJsonObject AccountManager::dataObjectFromResponse(QNetworkReply &requestReply) { QJsonObject AccountManager::dataObjectFromResponse(QNetworkReply* requestReply) {
QJsonObject jsonObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject jsonObject = QJsonDocument::fromJson(requestReply->readAll()).object();
static const QString STATUS_KEY = "status"; static const QString STATUS_KEY = "status";
static const QString DATA_KEY = "data"; static const QString DATA_KEY = "data";
@ -74,8 +75,7 @@ QJsonObject AccountManager::dataObjectFromResponse(QNetworkReply &requestReply)
AccountManager::AccountManager(UserAgentGetter userAgentGetter) : AccountManager::AccountManager(UserAgentGetter userAgentGetter) :
_userAgentGetter(userAgentGetter), _userAgentGetter(userAgentGetter),
_authURL(), _authURL()
_pendingCallbackMap()
{ {
qRegisterMetaType<OAuthAccessToken>("OAuthAccessToken"); qRegisterMetaType<OAuthAccessToken>("OAuthAccessToken");
qRegisterMetaTypeStreamOperators<OAuthAccessToken>("OAuthAccessToken"); qRegisterMetaTypeStreamOperators<OAuthAccessToken>("OAuthAccessToken");
@ -325,73 +325,76 @@ void AccountManager::sendRequest(const QString& path,
if (!callbackParams.isEmpty()) { if (!callbackParams.isEmpty()) {
// if we have information for a callback, insert the callbackParams into our local map if (callbackParams.updateReceiver && !callbackParams.updateSlot.isEmpty()) {
_pendingCallbackMap.insert(networkReply, callbackParams); callbackParams.updateReceiver->connect(networkReply, SIGNAL(uploadProgress(qint64, qint64)),
if (callbackParams.updateReciever && !callbackParams.updateSlot.isEmpty()) {
callbackParams.updateReciever->connect(networkReply, SIGNAL(uploadProgress(qint64, qint64)),
callbackParams.updateSlot.toStdString().c_str()); callbackParams.updateSlot.toStdString().c_str());
} }
} }
// if we ended up firing of a request, hook up to it now // There's a cleaner way to fire the JSON/error callbacks below and ensure that deleteLater is called for the
connect(networkReply, SIGNAL(finished()), SLOT(processReply())); // request reply - unfortunately it requires Qt 5.10 which the Android build does not support as of 06/26/18
}
}
void AccountManager::processReply() { if (callbackParams.jsonCallbackReceiver) {
QNetworkReply* requestReply = reinterpret_cast<QNetworkReply*>(sender()); connect(networkReply, &QNetworkReply::finished, callbackParams.jsonCallbackReceiver, [callbackParams, networkReply] {
if (networkReply->error() == QNetworkReply::NoError) {
if (callbackParams.jsonCallbackReceiver && !callbackParams.jsonCallbackMethod.isEmpty()) {
bool invoked = QMetaObject::invokeMethod(callbackParams.jsonCallbackReceiver,
qPrintable(callbackParams.jsonCallbackMethod),
Q_ARG(QNetworkReply*, networkReply));
if (requestReply->error() == QNetworkReply::NoError) { if (!invoked) {
if (requestReply->hasRawHeader(METAVERSE_SESSION_ID_HEADER)) { QString error = "Could not invoke " + callbackParams.jsonCallbackMethod + " with QNetworkReply* "
_sessionID = requestReply->rawHeader(METAVERSE_SESSION_ID_HEADER); + "on errorCallbackReceiver.";
} Q_ASSERT_X(invoked, "AccountManager::passErrorToCallback", qPrintable(error));
passSuccessToCallback(requestReply); }
} else { } else {
passErrorToCallback(requestReply); if (VERBOSE_HTTP_REQUEST_DEBUGGING) {
} qCDebug(networking) << "Received JSON response from metaverse API that has no matching callback.";
requestReply->deleteLater(); qCDebug(networking) << QJsonDocument::fromJson(networkReply->readAll());
} }
}
void AccountManager::passSuccessToCallback(QNetworkReply* requestReply) { networkReply->deleteLater();
JSONCallbackParameters callbackParams = _pendingCallbackMap.value(requestReply); }
});
if (callbackParams.jsonCallbackReceiver) {
// invoke the right method on the callback receiver
QMetaObject::invokeMethod(callbackParams.jsonCallbackReceiver, qPrintable(callbackParams.jsonCallbackMethod),
Q_ARG(QNetworkReply&, *requestReply));
// remove the related reply-callback group from the map
_pendingCallbackMap.remove(requestReply);
} else {
if (VERBOSE_HTTP_REQUEST_DEBUGGING) {
qCDebug(networking) << "Received JSON response from metaverse API that has no matching callback.";
qCDebug(networking) << QJsonDocument::fromJson(requestReply->readAll());
} }
requestReply->deleteLater(); if (callbackParams.errorCallbackReceiver) {
} connect(networkReply, &QNetworkReply::finished, callbackParams.errorCallbackReceiver, [callbackParams, networkReply]{
} if (networkReply->error() != QNetworkReply::NoError) {
if (callbackParams.errorCallbackReceiver && !callbackParams.errorCallbackMethod.isEmpty()) {
bool invoked = QMetaObject::invokeMethod(callbackParams.errorCallbackReceiver,
qPrintable(callbackParams.errorCallbackMethod),
Q_ARG(QNetworkReply*, networkReply));
void AccountManager::passErrorToCallback(QNetworkReply* requestReply) { if (!invoked) {
JSONCallbackParameters callbackParams = _pendingCallbackMap.value(requestReply); QString error = "Could not invoke " + callbackParams.errorCallbackMethod + " with QNetworkReply* "
+ "on errorCallbackReceiver.";
Q_ASSERT_X(invoked, "AccountManager::passErrorToCallback", qPrintable(error));
}
if (callbackParams.errorCallbackReceiver) { } else {
// invoke the right method on the callback receiver if (VERBOSE_HTTP_REQUEST_DEBUGGING) {
QMetaObject::invokeMethod(callbackParams.errorCallbackReceiver, qPrintable(callbackParams.errorCallbackMethod), qCDebug(networking) << "Received error response from metaverse API that has no matching callback.";
Q_ARG(QNetworkReply&, *requestReply)); qCDebug(networking) << "Error" << networkReply->error() << "-" << networkReply->errorString();
qCDebug(networking) << networkReply->readAll();
}
}
// remove the related reply-callback group from the map networkReply->deleteLater();
_pendingCallbackMap.remove(requestReply); }
} else { });
if (VERBOSE_HTTP_REQUEST_DEBUGGING) {
qCDebug(networking) << "Received error response from metaverse API that has no matching callback.";
qCDebug(networking) << "Error" << requestReply->error() << "-" << requestReply->errorString();
qCDebug(networking) << requestReply->readAll();
} }
requestReply->deleteLater(); // double check if the finished network reply had a session ID in the header and make
// sure that our session ID matches that value if so
connect(networkReply, &QNetworkReply::finished, this, [this, networkReply]{
if (networkReply->error() == QNetworkReply::NoError) {
if (networkReply->hasRawHeader(METAVERSE_SESSION_ID_HEADER)) {
_sessionID = networkReply->rawHeader(METAVERSE_SESSION_ID_HEADER);
}
}
});
} }
} }
@ -826,7 +829,7 @@ void AccountManager::processGeneratedKeypair(QByteArray publicKey, QByteArray pr
callbackParameters, QByteArray(), requestMultiPart); callbackParameters, QByteArray(), requestMultiPart);
} }
void AccountManager::publicKeyUploadSucceeded(QNetworkReply& reply) { void AccountManager::publicKeyUploadSucceeded(QNetworkReply* reply) {
qCDebug(networking) << "Uploaded public key to Metaverse API. RSA keypair generation is completed."; qCDebug(networking) << "Uploaded public key to Metaverse API. RSA keypair generation is completed.";
// public key upload complete - store the matching private key and persist the account to settings // public key upload complete - store the matching private key and persist the account to settings
@ -838,23 +841,17 @@ void AccountManager::publicKeyUploadSucceeded(QNetworkReply& reply) {
_isWaitingForKeypairResponse = false; _isWaitingForKeypairResponse = false;
emit newKeypair(); emit newKeypair();
// delete the reply object now that we are done with it
reply.deleteLater();
} }
void AccountManager::publicKeyUploadFailed(QNetworkReply& reply) { void AccountManager::publicKeyUploadFailed(QNetworkReply* reply) {
// the public key upload has failed // the public key upload has failed
qWarning() << "Public key upload failed from AccountManager" << reply.errorString(); qWarning() << "Public key upload failed from AccountManager" << reply->errorString();
// we aren't waiting for a response any longer // we aren't waiting for a response any longer
_isWaitingForKeypairResponse = false; _isWaitingForKeypairResponse = false;
// clear our pending private key // clear our pending private key
_pendingPrivateKey.clear(); _pendingPrivateKey.clear();
// delete the reply object now that we are done with it
reply.deleteLater();
} }
void AccountManager::handleKeypairGenerationError() { void AccountManager::handleKeypairGenerationError() {

11
libraries/networking/src/AccountManager.h
View file

@ -38,7 +38,7 @@ public:
QString jsonCallbackMethod; QString jsonCallbackMethod;
QObject* errorCallbackReceiver; QObject* errorCallbackReceiver;
QString errorCallbackMethod; QString errorCallbackMethod;
QObject* updateReciever; QObject* updateReceiver;
QString updateSlot; QString updateSlot;
}; };
@ -90,7 +90,7 @@ public:
DataServerAccountInfo& getAccountInfo() { return _accountInfo; } DataServerAccountInfo& getAccountInfo() { return _accountInfo; }
void setAccountInfo(const DataServerAccountInfo &newAccountInfo); void setAccountInfo(const DataServerAccountInfo &newAccountInfo);
static QJsonObject dataObjectFromResponse(QNetworkReply& requestReply); static QJsonObject dataObjectFromResponse(QNetworkReply* requestReply);
QUuid getSessionID() const { return _sessionID; } QUuid getSessionID() const { return _sessionID; }
void setSessionID(const QUuid& sessionID); void setSessionID(const QUuid& sessionID);
@ -126,11 +126,10 @@ signals:
void newKeypair(); void newKeypair();
private slots: private slots:
void processReply();
void handleKeypairGenerationError(); void handleKeypairGenerationError();
void processGeneratedKeypair(QByteArray publicKey, QByteArray privateKey); void processGeneratedKeypair(QByteArray publicKey, QByteArray privateKey);
void publicKeyUploadSucceeded(QNetworkReply& reply); void publicKeyUploadSucceeded(QNetworkReply* reply);
void publicKeyUploadFailed(QNetworkReply& reply); void publicKeyUploadFailed(QNetworkReply* reply);
void generateNewKeypair(bool isUserKeypair = true, const QUuid& domainID = QUuid()); void generateNewKeypair(bool isUserKeypair = true, const QUuid& domainID = QUuid());
private: private:
@ -146,8 +145,6 @@ private:
UserAgentGetter _userAgentGetter; UserAgentGetter _userAgentGetter;
QUrl _authURL; QUrl _authURL;
QMap<QNetworkReply*, JSONCallbackParameters> _pendingCallbackMap;
DataServerAccountInfo _accountInfo; DataServerAccountInfo _accountInfo;
bool _isWaitingForTokenRefresh { false }; bool _isWaitingForTokenRefresh { false };

22
libraries/networking/src/AddressManager.cpp
View file

@ -377,8 +377,8 @@ void AddressManager::handleLookupString(const QString& lookupString, bool fromSu
const QString DATA_OBJECT_DOMAIN_KEY = "domain"; const QString DATA_OBJECT_DOMAIN_KEY = "domain";
void AddressManager::handleAPIResponse(QNetworkReply& requestReply) { void AddressManager::handleAPIResponse(QNetworkReply* requestReply) {
QJsonObject responseObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject responseObject = QJsonDocument::fromJson(requestReply->readAll()).object();
QJsonObject dataObject = responseObject["data"].toObject(); QJsonObject dataObject = responseObject["data"].toObject();
// Lookup succeeded, don't keep re-trying it (especially on server restarts) // Lookup succeeded, don't keep re-trying it (especially on server restarts)
@ -396,7 +396,7 @@ void AddressManager::handleAPIResponse(QNetworkReply& requestReply) {
const char OVERRIDE_PATH_KEY[] = "override_path"; const char OVERRIDE_PATH_KEY[] = "override_path";
const char LOOKUP_TRIGGER_KEY[] = "lookup_trigger"; const char LOOKUP_TRIGGER_KEY[] = "lookup_trigger";
void AddressManager::goToAddressFromObject(const QVariantMap& dataObject, const QNetworkReply& reply) { void AddressManager::goToAddressFromObject(const QVariantMap& dataObject, const QNetworkReply* reply) {
const QString DATA_OBJECT_PLACE_KEY = "place"; const QString DATA_OBJECT_PLACE_KEY = "place";
const QString DATA_OBJECT_USER_LOCATION_KEY = "location"; const QString DATA_OBJECT_USER_LOCATION_KEY = "location";
@ -461,7 +461,7 @@ void AddressManager::goToAddressFromObject(const QVariantMap& dataObject, const
emit possibleDomainChangeRequiredViaICEForID(iceServerAddress, domainID); emit possibleDomainChangeRequiredViaICEForID(iceServerAddress, domainID);
} }
LookupTrigger trigger = (LookupTrigger) reply.property(LOOKUP_TRIGGER_KEY).toInt(); LookupTrigger trigger = (LookupTrigger) reply->property(LOOKUP_TRIGGER_KEY).toInt();
// set our current root place id to the ID that came back // set our current root place id to the ID that came back
@ -495,7 +495,7 @@ void AddressManager::goToAddressFromObject(const QVariantMap& dataObject, const
} }
// check if we had a path to override the path returned // check if we had a path to override the path returned
QString overridePath = reply.property(OVERRIDE_PATH_KEY).toString(); QString overridePath = reply->property(OVERRIDE_PATH_KEY).toString();
if (!overridePath.isEmpty() && overridePath != "/") { if (!overridePath.isEmpty() && overridePath != "/") {
// make sure we don't re-handle an overriden path if this was a refresh of info from API // make sure we don't re-handle an overriden path if this was a refresh of info from API
@ -543,10 +543,10 @@ void AddressManager::goToAddressFromObject(const QVariantMap& dataObject, const
} }
} }
void AddressManager::handleAPIError(QNetworkReply& errorReply) { void AddressManager::handleAPIError(QNetworkReply* errorReply) {
qCDebug(networking) << "AddressManager API error -" << errorReply.error() << "-" << errorReply.errorString(); qCDebug(networking) << "AddressManager API error -" << errorReply->error() << "-" << errorReply->errorString();
if (errorReply.error() == QNetworkReply::ContentNotFoundError) { if (errorReply->error() == QNetworkReply::ContentNotFoundError) {
// if this is a lookup that has no result, don't keep re-trying it // if this is a lookup that has no result, don't keep re-trying it
_previousLookup.clear(); _previousLookup.clear();
@ -874,14 +874,14 @@ QString AddressManager::getDomainID() const {
return DependencyManager::get<NodeList>()->getDomainHandler().getUUID().toString(); return DependencyManager::get<NodeList>()->getDomainHandler().getUUID().toString();
} }
void AddressManager::handleShareableNameAPIResponse(QNetworkReply& requestReply) { void AddressManager::handleShareableNameAPIResponse(QNetworkReply* requestReply) {
// make sure that this response is for the domain we're currently connected to // make sure that this response is for the domain we're currently connected to
auto domainID = DependencyManager::get<NodeList>()->getDomainHandler().getUUID(); auto domainID = DependencyManager::get<NodeList>()->getDomainHandler().getUUID();
if (requestReply.url().toString().contains(uuidStringWithoutCurlyBraces(domainID))) { if (requestReply->url().toString().contains(uuidStringWithoutCurlyBraces(domainID))) {
// check for a name or default name in the API response // check for a name or default name in the API response
QJsonObject responseObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject responseObject = QJsonDocument::fromJson(requestReply->readAll()).object();
QJsonObject domainObject = responseObject["domain"].toObject(); QJsonObject domainObject = responseObject["domain"].toObject();
const QString DOMAIN_NAME_KEY = "name"; const QString DOMAIN_NAME_KEY = "name";

8
libraries/networking/src/AddressManager.h
View file

@ -417,13 +417,13 @@ signals:
void goForwardPossible(bool isPossible); void goForwardPossible(bool isPossible);
private slots: private slots:
void handleAPIResponse(QNetworkReply& requestReply); void handleAPIResponse(QNetworkReply* requestReply);
void handleAPIError(QNetworkReply& errorReply); void handleAPIError(QNetworkReply* errorReply);
void handleShareableNameAPIResponse(QNetworkReply& requestReply); void handleShareableNameAPIResponse(QNetworkReply* requestReply);
private: private:
void goToAddressFromObject(const QVariantMap& addressMap, const QNetworkReply& reply); void goToAddressFromObject(const QVariantMap& addressMap, const QNetworkReply* reply);
// Set host and port, and return `true` if it was changed. // Set host and port, and return `true` if it was changed.
bool setHost(const QString& host, LookupTrigger trigger, quint16 port = 0); bool setHost(const QString& host, LookupTrigger trigger, quint16 port = 0);

2
libraries/networking/src/NodeList.cpp
View file

@ -549,7 +549,7 @@ void NodeList::handleICEConnectionToDomainServer() {
_domainHandler.getICEClientID(), _domainHandler.getICEClientID(),
_domainHandler.getPendingDomainID()); _domainHandler.getPendingDomainID());
} }
} }
void NodeList::pingPunchForDomainServer() { void NodeList::pingPunchForDomainServer() {
// make sure if we're here that we actually still need to ping the domain-server // make sure if we're here that we actually still need to ping the domain-server

4
libraries/networking/src/UserActivityLogger.cpp
View file

@ -75,8 +75,8 @@ void UserActivityLogger::logAction(QString action, QJsonObject details, JSONCall
params, NULL, multipart); params, NULL, multipart);
} }
void UserActivityLogger::requestError(QNetworkReply& errorReply) { void UserActivityLogger::requestError(QNetworkReply* errorReply) {
qCDebug(networking) << errorReply.error() << "-" << errorReply.errorString(); qCDebug(networking) << errorReply->error() << "-" << errorReply->errorString();
} }
void UserActivityLogger::launch(QString applicationVersion, bool previousSessionCrashed, int previousSessionRuntime) { void UserActivityLogger::launch(QString applicationVersion, bool previousSessionCrashed, int previousSessionRuntime) {

2
libraries/networking/src/UserActivityLogger.h
View file

@ -50,7 +50,7 @@ public slots:
void wentTo(AddressManager::LookupTrigger trigger, QString destinationType, QString destinationName); void wentTo(AddressManager::LookupTrigger trigger, QString destinationType, QString destinationName);
private slots: private slots:
void requestError(QNetworkReply& errorReply); void requestError(QNetworkReply* errorReply);
private: private:
UserActivityLogger(); UserActivityLogger();

4
libraries/ui/src/Tooltip.cpp
View file

@ -94,9 +94,9 @@ void Tooltip::requestHyperlinkImage() {
} }
} }
void Tooltip::handleAPIResponse(QNetworkReply& requestReply) { void Tooltip::handleAPIResponse(QNetworkReply* requestReply) {
// did a preview image come back? // did a preview image come back?
QJsonObject responseObject = QJsonDocument::fromJson(requestReply.readAll()).object(); QJsonObject responseObject = QJsonDocument::fromJson(requestReply->readAll()).object();
QJsonObject dataObject = responseObject["data"].toObject(); QJsonObject dataObject = responseObject["data"].toObject();
const QString PLACE_KEY = "place"; const QString PLACE_KEY = "place";

2
libraries/ui/src/Tooltip.h
View file

@ -49,7 +49,7 @@ signals:
void imageURLChanged(); void imageURLChanged();
private slots: private slots:
void handleAPIResponse(QNetworkReply& requestReply); void handleAPIResponse(QNetworkReply* requestReply);
private: private:
void requestHyperlinkImage(); void requestHyperlinkImage();