Merge pull request #3451 from birarda/fix-ssl-handshake-race

make sure the OAuthWebViewHandler is ready before the NodeList might need it
This commit is contained in:
Brad Hefta-Gaub 2014-09-18 13:29:54 -07:00
commit c48b3ae51e
2 changed files with 5 additions and 6 deletions

View file

@ -219,6 +219,10 @@ Application::Application(int& argc, char** argv, QElapsedTimer &startup_time) :
if (portStr) { if (portStr) {
listenPort = atoi(portStr); listenPort = atoi(portStr);
} }
// call the OAuthWebviewHandler static getter so that its instance lives in our thread
// make sure it is ready before the NodeList might need it
OAuthWebViewHandler::getInstance();
// start the nodeThread so its event loop is running // start the nodeThread so its event loop is running
_nodeThread->start(); _nodeThread->start();
@ -418,11 +422,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer &startup_time) :
connect(_window, &MainWindow::windowGeometryChanged, connect(_window, &MainWindow::windowGeometryChanged,
_runningScriptsWidget, &RunningScriptsWidget::setBoundary); _runningScriptsWidget, &RunningScriptsWidget::setBoundary);
// call the OAuthWebviewHandler static getter so that its instance lives in our thread
OAuthWebViewHandler::getInstance();
// make sure the High Fidelity root CA is in our list of trusted certs
OAuthWebViewHandler::addHighFidelityRootCAToSSLConfig();
_trayIcon->show(); _trayIcon->show();
#ifdef HAVE_RTMIDI #ifdef HAVE_RTMIDI

View file

@ -27,7 +27,7 @@ OAuthWebViewHandler::OAuthWebViewHandler() :
_webViewRedisplayTimer(), _webViewRedisplayTimer(),
_lastAuthorizationURL() _lastAuthorizationURL()
{ {
addHighFidelityRootCAToSSLConfig();
} }
const char HIGH_FIDELITY_CA[] = "-----BEGIN CERTIFICATE-----\n" const char HIGH_FIDELITY_CA[] = "-----BEGIN CERTIFICATE-----\n"