Mirrors/overte-HifiExperiments
3
0
Fork 0
mirror of https://github.com/HifiExperiments/overte.git synced 2025-05-30 19:11:24 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

show checkbox or radiobutton dependently on exclusiveGroup presence

Browse source
This commit is contained in:
beholder 2017-08-29 23:23:16 +03:00
parent cbbe03cee7
commit a0a43ebf26
4 changed files with 36 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
interface/resources/qml/desktop/Desktop.qml
View file

@ -58,14 +58,12 @@ FocusScope {
function addExclusionGroup(menuItem, exclusionGroup) function addExclusionGroup(menuItem, exclusionGroup)
{ {
console.debug('entering Desktop::addExclusionGroup: menuItem = ', menuItem, 'exclusionGroup = ', exclusionGroup);
exclusionGroupsByMenuItem.append( exclusionGroupsByMenuItem.append(
{ {
'menuItem' : menuItem.toString(), 'menuItem' : menuItem.toString(),
'exclusionGroup' : exclusionGroup.toString() 'exclusionGroup' : exclusionGroup.toString()
} }
); );
console.debug('Desktop::addExclusionGroup: ', exclusionGroup, 'rootMenu: ', this);
} }
} }

46
interface/resources/qml/hifi/tablet/TabletMenuItem.qml
View file

@ -26,24 +26,48 @@ Item {
visible: source.visible visible: source.visible
width: parent.width width: parent.width
CheckBox { Item {
id: check id: check
// FIXME: Should use radio buttons if source.exclusiveGroup.
anchors { anchors {
left: parent.left left: parent.left
leftMargin: hifi.dimensions.menuPadding.x + 15 leftMargin: hifi.dimensions.menuPadding.x + 15
verticalCenter: label.verticalCenter verticalCenter: label.verticalCenter
} }
width: 20
visible: source.visible && source.type === 1 && source.checkable width: checkbox.visible ? checkbox.width : radiobutton.width
checked: setChecked() height: checkbox.visible ? checkbox.height : radiobutton.height
function setChecked() {
if (!source || source.type !== 1 || !source.checkable) { CheckBox {
return false; id: checkbox
// FIXME: Should use radio buttons if source.exclusiveGroup.
width: 20
visible: source.visible && source.type === 1 && source.checkable && !source.exclusiveGroup
checked: setChecked()
function setChecked() {
if (!source || source.type !== 1 || !source.checkable) {
return false;
}
// FIXME this works for native QML menus but I don't think it will
// for proxied QML menus
return source.checked;
}
}
RadioButton {
id: radiobutton
// FIXME: Should use radio buttons if source.exclusiveGroup.
width: 20
visible: source.visible && source.type === 1 && source.checkable && source.exclusiveGroup
checked: setChecked()
function setChecked() {
if (!source || source.type !== 1 || !source.checkable) {
return false;
}
// FIXME this works for native QML menus but I don't think it will
// for proxied QML menus
return source.checked;
} }
// FIXME this works for native QML menus but I don't think it will
// for proxied QML menus
return source.checked;
} }
} }

3
interface/resources/qml/hifi/tablet/TabletMenuStack.qml
View file

@ -159,9 +159,6 @@ Item {
property Component exclusiveGroupMaker: Component { property Component exclusiveGroupMaker: Component {
ExclusiveGroup { ExclusiveGroup {
Component.onDestruction: {
console.debug('ExclusionGroup destroyed: ', this)
}
} }
} }

2
libraries/ui/src/VrMenu.cpp
View file

@ -56,7 +56,7 @@ public:
_from->removeEventFilter(this); _from->removeEventFilter(this);
} }
protected: protected:
bool eventFilter(QObject* o, QEvent* e) { virtual bool eventFilter(QObject* o, QEvent* e) override {
if (e->type() == QEvent::DynamicPropertyChange) { if (e->type() == QEvent::DynamicPropertyChange) {
QDynamicPropertyChangeEvent* dpc = static_cast<QDynamicPropertyChangeEvent*>(e); QDynamicPropertyChangeEvent* dpc = static_cast<QDynamicPropertyChangeEvent*>(e);
if (dpc->propertyName() == "exclusionGroup") if (dpc->propertyName() == "exclusionGroup")