From 9de6828b032b71e8ccb743643708e9ec0b02f8b4 Mon Sep 17 00:00:00 2001 From: Ryan Huffman Date: Mon, 13 Jul 2015 14:24:06 -0700 Subject: [PATCH] Remove readPendingDatagram from AudioMixer --- assignment-client/src/audio/AudioMixer.cpp | 27 ---------------------- assignment-client/src/audio/AudioMixer.h | 2 -- 2 files changed, 29 deletions(-) diff --git a/assignment-client/src/audio/AudioMixer.cpp b/assignment-client/src/audio/AudioMixer.cpp index d8c01dafcd..018f946771 100644 --- a/assignment-client/src/audio/AudioMixer.cpp +++ b/assignment-client/src/audio/AudioMixer.cpp @@ -543,11 +543,6 @@ void AudioMixer::sendAudioEnvironmentPacket(SharedNodePointer node) { } } -void AudioMixer::readPendingDatagram(const QByteArray& receivedPacket, const HifiSockAddr& senderSockAddr) { - auto nodeList = DependencyManager::get(); - nodeList->processNodeData(senderSockAddr, receivedPacket); -} - void AudioMixer::handleMicrophoneAudioNoEchoPacket(QSharedPointer packet, HifiSockAddr senderSockAddr) { auto nodeList = DependencyManager::get(); nodeList->findNodeAndUpdateWithDataFromPacket(packet); @@ -684,28 +679,6 @@ void AudioMixer::run() { _datagramProcessingThread = new QThread(this); _datagramProcessingThread->setObjectName("Datagram Processor Thread"); - // create an AudioMixerDatagramProcessor and move it to that thread - AudioMixerDatagramProcessor* datagramProcessor = new AudioMixerDatagramProcessor(nodeList->getNodeSocket(), thread()); - datagramProcessor->moveToThread(_datagramProcessingThread); - - // remove the NodeList as the parent of the node socket - nodeList->getNodeSocket().setParent(NULL); - nodeList->getNodeSocket().moveToThread(_datagramProcessingThread); - - // let the datagram processor handle readyRead from node socket - connect(&nodeList->getNodeSocket(), &QUdpSocket::readyRead, - datagramProcessor, &AudioMixerDatagramProcessor::readPendingDatagrams); - - // connect to the datagram processing thread signal that tells us we have to handle a packet - connect(datagramProcessor, &AudioMixerDatagramProcessor::packetRequiresProcessing, this, &AudioMixer::readPendingDatagram); - - // delete the datagram processor and the associated thread when the QThread quits - connect(_datagramProcessingThread, &QThread::finished, datagramProcessor, &QObject::deleteLater); - connect(datagramProcessor, &QObject::destroyed, _datagramProcessingThread, &QThread::deleteLater); - - // start the datagram processing thread - _datagramProcessingThread->start(); - nodeList->addNodeTypeToInterestSet(NodeType::Agent); nodeList->linkedDataCreateCallback = [](Node* node) { diff --git a/assignment-client/src/audio/AudioMixer.h b/assignment-client/src/audio/AudioMixer.h index c88c5a6242..50ec3c6d18 100644 --- a/assignment-client/src/audio/AudioMixer.h +++ b/assignment-client/src/audio/AudioMixer.h @@ -35,8 +35,6 @@ public slots: /// threaded run of assignment void run(); - void readPendingDatagram(const QByteArray& receivedPacket, const HifiSockAddr& senderSockAddr); - void sendStatsPacket(); static const InboundAudioStream::Settings& getStreamSettings() { return _streamSettings; }